Re: [PHP-CVS] cvs: php-src /ext/spl config.m4 spl_observer.c

2005-12-22 Thread Andi Gutmans
It's hard for me to believe though that memset() plus copying some values is noticeably slower. For such small structures I doubt it has any impact on the SPL Iterator performance (you're allocating on stack so allocation is not an issue). You can keep it this way, but my $.02 would be to only h

Re: [PHP-CVS] cvs: php-src /ext/spl config.m4 spl_observer.c

2005-12-22 Thread Marcus Boerger
Hello Andi, we would need to enforce structure packing change the type of zend_object_handle in zend_object_value or both. But even if we go that way we are not sure it works, so the only way that would always work is the memset. However setting all structure bytes to zero while on many platform

Re: [PHP-CVS] cvs: php-src /ext/spl config.m4 spl_observer.c

2005-12-22 Thread Andi Gutmans
Are you sure you want to fix it this way? It'll make things less maintainable. I'm sure there's a way to make it one implementation that works everywhere. At 01:36 PM 12/20/2005, Marcus Boerger wrote: helly Tue Dec 20 21:36:48 2005 EDT Modified files: /php-src/ext/splconfi

[PHP-CVS] cvs: php-src /ext/spl config.m4 spl_observer.c

2005-12-20 Thread Marcus Boerger
helly Tue Dec 20 21:36:48 2005 EDT Modified files: /php-src/ext/splconfig.m4 spl_observer.c Log: - Only apply workaround solution for 64 bit machines when necessary # Actually this can already be necessary on 32 bit machine and also not be # necessary on