[PHP-CVS] cvs: php-src /ext/sqlite sess_sqlite.c sqlite.c

2004-03-07 Thread Ilia Alshanetsky
iliaa Sun Mar 7 16:57:51 2004 EDT Modified files: /php-src/ext/sqlite sess_sqlite.c sqlite.c Log: Corrected string escape calculation. http://cvs.php.net/diff.php/php-src/ext/sqlite/sess_sqlite.c?r1=1.14r2=1.15ty=u Index: php-src/ext/sqlite/sess_sqlite.c

Re: [PHP-CVS] cvs: php-src /ext/sqlite sess_sqlite.c sqlite.c

2004-03-07 Thread Andi Gutmans
Why not just do (256.0 / 253.0)? At 09:57 PM 3/7/2004 +, Ilia Alshanetsky wrote: iliaa Sun Mar 7 16:57:51 2004 EDT Modified files: /php-src/ext/sqlite sess_sqlite.c sqlite.c Log: Corrected string escape calculation.

Re: [PHP-CVS] cvs: php-src /ext/sqlite sess_sqlite.c sqlite.c

2004-03-07 Thread Ilia Alshanetsky
On March 07, 2004 05:03 pm, Andi Gutmans wrote: Why not just do (256.0 / 253.0)? I think an intentional cast is less likely to be removed then a seemingly pointless .0. However, I don't feel strongly about either approach and if you insist the code can be changed. Ilia -- PHP CVS Mailing

[PHP-CVS] cvs: php-src /ext/sqlite sess_sqlite.c

2004-03-07 Thread Sascha Schumann
sas Sun Mar 7 17:35:27 2004 EDT Modified files: /php-src/ext/sqlite sess_sqlite.c Log: Avoid using floating point arithmetic and rely on safe_emalloc for the multiplication. The actual size requirement is spelled out as: ** The result is written

Re: [PHP-CVS] cvs: php-src /ext/sqlite sess_sqlite.c sqlite.c

2004-03-07 Thread Andi Gutmans
I don't insist. I just think it's nicer. But it's a matter of taste so it's your choice. At 05:09 PM 3/7/2004 -0500, Ilia Alshanetsky wrote: On March 07, 2004 05:03 pm, Andi Gutmans wrote: Why not just do (256.0 / 253.0)? I think an intentional cast is less likely to be removed then a seemingly

[PHP-CVS] cvs: php-src /ext/sqlite sess_sqlite.c

2004-03-06 Thread Ilia Alshanetsky
iliaa Sat Mar 6 13:11:59 2004 EDT Modified files: /php-src/ext/sqlite sess_sqlite.c Log: Fixed possible crash due to an integer overflow. http://cvs.php.net/diff.php/php-src/ext/sqlite/sess_sqlite.c?r1=1.13r2=1.14ty=u Index:

[PHP-CVS] cvs: php-src /ext/sqlite sess_sqlite.c

2004-01-12 Thread Ilia Alshanetsky
iliaa Mon Jan 12 17:48:59 2004 EDT Modified files: /php-src/ext/sqlite sess_sqlite.c Log: Fixed a bug that would cause the sqlite session database to grow endlessly. Index: php-src/ext/sqlite/sess_sqlite.c diff -u php-src/ext/sqlite/sess_sqlite.c:1.11

[PHP-CVS] cvs: php-src /ext/sqlite sess_sqlite.c

2004-01-12 Thread John Coggeshall
johnTue Jan 13 00:23:08 2004 EDT Modified files: /php-src/ext/sqlite sess_sqlite.c Log: Whoops... Ilia forgot a ')' Index: php-src/ext/sqlite/sess_sqlite.c diff -u php-src/ext/sqlite/sess_sqlite.c:1.12 php-src/ext/sqlite/sess_sqlite.c:1.13 ---

[PHP-CVS] cvs: php-src /ext/sqlite sess_sqlite.c

2003-07-02 Thread Marcus Boerger
helly Wed Jul 2 17:40:55 2003 EDT Modified files: /php-src/ext/sqlite sess_sqlite.c Log: funny fixes Index: php-src/ext/sqlite/sess_sqlite.c diff -u php-src/ext/sqlite/sess_sqlite.c:1.9 php-src/ext/sqlite/sess_sqlite.c:1.10 ---

[PHP-CVS] cvs: php-src /ext/sqlite sess_sqlite.c

2003-07-01 Thread Wez Furlong
wez Tue Jul 1 09:09:57 2003 EDT Modified files: /php-src/ext/sqlite sess_sqlite.c Log: WS Index: php-src/ext/sqlite/sess_sqlite.c diff -u php-src/ext/sqlite/sess_sqlite.c:1.1 php-src/ext/sqlite/sess_sqlite.c:1.2 --- php-src/ext/sqlite/sess_sqlite.c:1.1

[PHP-CVS] cvs: php-src /ext/sqlite sess_sqlite.c sqlite.c

2003-07-01 Thread Marcus Boerger
helly Tue Jul 1 13:55:32 2003 EDT Modified files: /php-src/ext/sqlite sqlite.c sess_sqlite.c Log: Fix warnings and allow builds without ext/session Index: php-src/ext/sqlite/sqlite.c diff -u php-src/ext/sqlite/sqlite.c:1.68 php-src/ext/sqlite/sqlite.c:1.69

[PHP-CVS] cvs: php-src /ext/sqlite sess_sqlite.c

2003-07-01 Thread Sterling Hughes
sterlingTue Jul 1 20:03:41 2003 EDT Modified files: /php-src/ext/sqlite sess_sqlite.c Log: make this actually work. Index: php-src/ext/sqlite/sess_sqlite.c diff -u php-src/ext/sqlite/sess_sqlite.c:1.3 php-src/ext/sqlite/sess_sqlite.c:1.4 ---

[PHP-CVS] cvs: php-src /ext/sqlite sess_sqlite.c

2003-07-01 Thread Sterling Hughes
sterlingTue Jul 1 20:04:58 2003 EDT Modified files: /php-src/ext/sqlite sess_sqlite.c Log: no c++ style comments Index: php-src/ext/sqlite/sess_sqlite.c diff -u php-src/ext/sqlite/sess_sqlite.c:1.4 php-src/ext/sqlite/sess_sqlite.c:1.5 ---

[PHP-CVS] cvs: php-src /ext/sqlite sess_sqlite.c

2003-07-01 Thread Sterling Hughes
sterlingTue Jul 1 20:43:00 2003 EDT Modified files: /php-src/ext/sqlite sess_sqlite.c Log: set synching to off cleanup some silly code Index: php-src/ext/sqlite/sess_sqlite.c diff -u php-src/ext/sqlite/sess_sqlite.c:1.5

[PHP-CVS] cvs: php-src /ext/sqlite sess_sqlite.c

2003-07-01 Thread Sterling Hughes
sterlingTue Jul 1 20:45:16 2003 EDT Modified files: /php-src/ext/sqlite sess_sqlite.c Log: ws fix Index: php-src/ext/sqlite/sess_sqlite.c diff -u php-src/ext/sqlite/sess_sqlite.c:1.6 php-src/ext/sqlite/sess_sqlite.c:1.7 ---

[PHP-CVS] cvs: php-src /ext/sqlite sess_sqlite.c

2003-07-01 Thread Sterling Hughes
sterlingTue Jul 1 20:56:32 2003 EDT Modified files: /php-src/ext/sqlite sess_sqlite.c Log: not necessary, already assumed binary safe (it has to be under the current session architecture), and anything else is fair play Index:

[PHP-CVS] cvs: php-src /ext/sqlite sess_sqlite.c

2003-07-01 Thread Sterling Hughes
sterlingTue Jul 1 23:12:06 2003 EDT Modified files: /php-src/ext/sqlite sess_sqlite.c Log: further improve the performance and clean up Index: php-src/ext/sqlite/sess_sqlite.c diff -u php-src/ext/sqlite/sess_sqlite.c:1.8