janiSat May 23 18:42:54 2009 UTC
Modified files:
/php-src/main rfc1867.c
Log:
fix build
http://cvs.php.net/viewvc.cgi/php-src/main/rfc1867.c?r1=1.211r2=1.212diff_format=u
Index: php-src/main/rfc1867.c
diff -u php-src/main/rfc1867.c:1.211
janiSat May 23 18:46:10 2009 UTC
Modified files:
/php-src/main rfc1867.c
Log:
ws
http://cvs.php.net/viewvc.cgi/php-src/main/rfc1867.c?r1=1.212r2=1.213diff_format=u
Index: php-src/main/rfc1867.c
diff -u php-src/main/rfc1867.c:1.212
lbarnaudFri May 1 00:13:22 2009 UTC
Modified files:
/php-src/main rfc1867.c
Log:
Removed code handling non-unicode input (was used when !UG(unicode))
http://cvs.php.net/viewvc.cgi/php-src/main/rfc1867.c?r1=1.206r2=1.207diff_format=u
Index:
lbarnaudFri May 1 00:15:07 2009 UTC
Modified files:
/php-src/main rfc1867.c
Log:
Removed code for register_globals in file uploads
http://cvs.php.net/viewvc.cgi/php-src/main/rfc1867.c?r1=1.207r2=1.208diff_format=u
Index: php-src/main/rfc1867.c
lbarnaudFri May 1 00:18:10 2009 UTC
Modified files:
/php-src/main rfc1867.c
Log:
cleanup
http://cvs.php.net/viewvc.cgi/php-src/main/rfc1867.c?r1=1.208r2=1.209diff_format=u
Index: php-src/main/rfc1867.c
diff -u php-src/main/rfc1867.c:1.208
lbarnaudFri May 1 00:36:43 2009 UTC
Modified files:
/php-src/main rfc1867.c
Log:
revert to allow Andrei to make his changes
http://cvs.php.net/viewvc.cgi/php-src/main/rfc1867.c?r1=1.209r2=1.210diff_format=u
Index: php-src/main/rfc1867.c
diff -u
lbarnaudThu Sep 18 19:44:01 2008 UTC
Modified files:
/php-src/main rfc1867.c
Log:
Fixed cleaning of uploaded files
http://cvs.php.net/viewvc.cgi/php-src/main/rfc1867.c?r1=1.201r2=1.202diff_format=u
Index: php-src/main/rfc1867.c
diff -u
lbarnaudSun Sep 14 14:55:29 2008 UTC
Modified files:
/php-src/main rfc1867.c
Log:
Fix invalid read in freed area
http://cvs.php.net/viewvc.cgi/php-src/main/rfc1867.c?r1=1.200r2=1.201diff_format=u
Index: php-src/main/rfc1867.c
diff -u
lbarnaudMon Sep 8 09:12:02 2008 UTC
Modified files:
/php-src/main rfc1867.c
Log:
comment out debug printf
http://cvs.php.net/viewvc.cgi/php-src/main/rfc1867.c?r1=1.197r2=1.198diff_format=u
Index: php-src/main/rfc1867.c
diff -u
lbarnaudMon Sep 8 09:12:51 2008 UTC
Modified files:
/php-src/main rfc1867.c
Log:
fix empty-value case in rfc1867 post handler
http://cvs.php.net/viewvc.cgi/php-src/main/rfc1867.c?r1=1.198r2=1.199diff_format=u
Index: php-src/main/rfc1867.c
diff
lbarnaudMon Sep 8 09:20:33 2008 UTC
Modified files:
/php-src/main rfc1867.c
Log:
Fix the Content-Type contains ';' case in rfc1867 post handler
http://cvs.php.net/viewvc.cgi/php-src/main/rfc1867.c?r1=1.199r2=1.200diff_format=u
Index:
lbarnaudSun Sep 7 14:17:24 2008 UTC
Modified files:
/php-src/main rfc1867.c
Log:
More accurate max_file_size / upload_max_filesize (fixes #45124)
http://cvs.php.net/viewvc.cgi/php-src/main/rfc1867.c?r1=1.196r2=1.197diff_format=u
Index:
lbarnaudSat Sep 6 08:27:38 2008 UTC
Modified files:
/ZendEngine2zend.h
/php-src/main rfc1867.c rfc1867.h
Log:
Ported rfc1867 hooks to HEAD
http://cvs.php.net/viewvc.cgi/ZendEngine2/zend.h?r1=1.361r2=1.362diff_format=u
Index:
lbarnaudSat Sep 6 17:17:45 2008 UTC
Modified files:
/php-src/main rfc1867.c
Log:
Fixed #43540 (rfc1867 handler newlength problem)
http://cvs.php.net/viewvc.cgi/php-src/main/rfc1867.c?r1=1.195r2=1.196diff_format=u
Index: php-src/main/rfc1867.c
tony2001Fri Mar 14 13:10:23 2008 UTC
Modified files:
/php-src/main rfc1867.c
Log:
check if return value of write() is -1 and abort upload in this case setting
the correct error status
derick Tue Dec 18 10:53:00 2007 UTC
Modified files:
/php-src/main rfc1867.c
Log:
- Fixed typo.
http://cvs.php.net/viewvc.cgi/php-src/main/rfc1867.c?r1=1.190r2=1.191diff_format=u
Index: php-src/main/rfc1867.c
diff -u php-src/main/rfc1867.c:1.190
tony2001Thu Jul 13 12:17:26 2006 UTC
Modified files:
/php-src/main rfc1867.c
Log:
fix C++ comments in C code and comment out unused variable
http://cvs.php.net/viewvc.cgi/php-src/main/rfc1867.c?r1=1.185r2=1.186diff_format=u
Index:
It can be closed, I think.
-Andrei
On Nov 11, 2005, at 9:38 AM, Antony Dovgal wrote:
Once again..
Is the bug #34362 still valid after this fix ?
On 11.11.2005 20:34, Andrei Zmievski wrote:
andreiFri Nov 11 12:34:19 2005 EDT
Modified files: /php-src/main
On 12.11.2005 12:12, Andrei Zmievski wrote:
It can be closed, I think.
Yup.
It's already done.
--
Wbr,
Antony Dovgal
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
andrei Sat Nov 12 06:12:01 2005 EDT
Modified files:
/php-src/main rfc1867.c
Log:
Grr. Re-re-fix the fix.
http://cvs.php.net/diff.php/php-src/main/rfc1867.c?r1=1.178r2=1.179ty=u
Index: php-src/main/rfc1867.c
diff -u php-src/main/rfc1867.c:1.178
helly Fri Nov 11 11:50:10 2005 EDT
Modified files:
/php-src/main rfc1867.c
Log:
- Fix build
http://cvs.php.net/diff.php/php-src/main/rfc1867.c?r1=1.176r2=1.177ty=u
Index: php-src/main/rfc1867.c
diff -u php-src/main/rfc1867.c:1.176
Does it fix this issue http://bugs.php.net/bug.php?id=34362 ?
On 11.11.2005 19:50, Marcus Boerger wrote:
helly Fri Nov 11 11:50:10 2005 EDT
Modified files:
/php-src/main rfc1867.c
Log:
- Fix build
andrei Fri Nov 11 12:34:19 2005 EDT
Modified files:
/php-src/main rfc1867.c
Log:
Re-fix Marcus's fix.
http://cvs.php.net/diff.php/php-src/main/rfc1867.c?r1=1.177r2=1.178ty=u
Index: php-src/main/rfc1867.c
diff -u php-src/main/rfc1867.c:1.177
Once again..
Is the bug #34362 still valid after this fix ?
On 11.11.2005 20:34, Andrei Zmievski wrote:
andrei Fri Nov 11 12:34:19 2005 EDT
Modified files:
/php-src/main rfc1867.c
Log:
Re-fix Marcus's fix.
andrei Tue Sep 27 13:50:00 2005 EDT
Modified files:
/php-src/main rfc1867.c
Log:
Unicode fixes.
http://cvs.php.net/diff.php/php-src/main/rfc1867.c?r1=1.175r2=1.176ty=u
Index: php-src/main/rfc1867.c
diff -u php-src/main/rfc1867.c:1.175
andrei Wed Aug 31 16:42:18 2005 EDT
Modified files:
/php-src/main rfc1867.c
Log:
Further work on Unicode support in file uploads.
http://cvs.php.net/diff.php/php-src/main/rfc1867.c?r1=1.174r2=1.175ty=u
Index: php-src/main/rfc1867.c
diff -u
iliaa Mon Feb 14 19:25:39 2005 EDT
Modified files:
/php-src/main rfc1867.c
Log:
Prune uploaded file names to \ on all OSes, read comments for explanation.
http://cvs.php.net/diff.php/php-src/main/rfc1867.c?r1=1.169r2=1.170ty=u
Index:
iliaa Mon Jan 31 21:33:07 2005 EDT
Modified files:
/php-src/main rfc1867.c
Log:
Final version of filename upload handling.
http://cvs.php.net/diff.php/php-src/main/rfc1867.c?r1=1.168r2=1.169ty=u
Index: php-src/main/rfc1867.c
diff -u
moriyoshi Mon Jan 24 11:47:19 2005 EDT
Modified files:
/php-src/main rfc1867.c
Log:
- Revert irrelevant part.
http://cvs.php.net/diff.php/php-src/main/rfc1867.c?r1=1.166r2=1.167ty=u
Index: php-src/main/rfc1867.c
diff -u
I can understand your reasoning for wanting to changing the multibyte
specific code, but why is the non-multibyte related code being altered?
You also effectively re-introduced a bug that Stefan's fix addressed,
which was escape char (\) being considered to be part of the path when
Hi,
On 2005/01/25, at 1:59, Ilia Alshanetsky wrote:
I can understand your reasoning for wanting to changing the multibyte
specific code, but why is the non-multibyte related code being
altered? You also effectively re-introduced a bug that Stefan's fix
addressed, which was escape char (\)
iliaa Mon Jan 24 17:35:24 2005 EDT
Modified files:
/php-src/main rfc1867.c
Log:
Use multibyte specific code for handling files and generic basename based
code in all other instances.
sesser Sat Nov 20 13:49:37 2004 EDT
Modified files:
/php-src/main rfc1867.c
Log:
Fixed: strip quotes from filename
http://cvs.php.net/diff.php/php-src/main/rfc1867.c?r1=1.164r2=1.165ty=u
Index: php-src/main/rfc1867.c
diff -u
iliaa Wed Nov 10 19:38:06 2004 EDT
Modified files:
/php-src/main rfc1867.c
Log:
Fixed bug #30750 (Meaningful error message when upload directory is not
accessible).
http://cvs.php.net/diff.php/php-src/main/rfc1867.c?r1=1.163r2=1.164ty=u
Index:
sesser Mon Sep 13 12:00:23 2004 EDT
Modified files:
/php-src/main rfc1867.c
Log:
only allow valid arrays at this point
http://cvs.php.net/diff.php/php-src/main/rfc1867.c?r1=1.162r2=1.163ty=u
Index: php-src/main/rfc1867.c
diff -u
sesser Sun Sep 12 06:45:15 2004 EDT
Modified files:
/php-src/main rfc1867.c
Log:
New Rule: Never try to repair potential malicious user input
http://cvs.php.net/diff.php/php-src/main/rfc1867.c?r1=1.161r2=1.162ty=u
Index: php-src/main/rfc1867.c
diff
pollita Wed Aug 11 00:27:01 2004 EDT
Modified files:
/php-src/main rfc1867.c
Log:
Minor format specifier fixes
http://cvs.php.net/diff.php/php-src/main/rfc1867.c?r1=1.160r2=1.161ty=u
Index: php-src/main/rfc1867.c
diff -u php-src/main/rfc1867.c:1.160
iliaa Sun Jul 25 15:19:26 2004 EDT
Modified files:
/php-src/main rfc1867.c
Log:
Fixed bug #29369 (Uploaded files with ' or in their names get their names
truncated at those characters).
sesser Sun May 23 06:00:59 2004 EDT
Modified files:
/php-src/main rfc1867.c
Log:
This is more correct.
http://cvs.php.net/diff.php/php-src/main/rfc1867.c?r1=1.157r2=1.158ty=u
Index: php-src/main/rfc1867.c
diff -u php-src/main/rfc1867.c:1.157
derick Fri May 21 04:11:43 2004 EDT
Modified files:
/php-src/main rfc1867.c
Log:
- Fixed bug #28456 (Problem with enclosed / in uploaded file names)
http://cvs.php.net/diff.php/php-src/main/rfc1867.c?r1=1.155r2=1.156ty=u
Index: php-src/main/rfc1867.c
derick Fri May 21 04:16:13 2004 EDT
Modified files:
/php-src/main rfc1867.c
Log:
- Fixed TSRM problem in latest commit.
http://cvs.php.net/diff.php/php-src/main/rfc1867.c?r1=1.156r2=1.157ty=u
Index: php-src/main/rfc1867.c
diff -u
derick Tue May 11 11:30:54 2004 EDT
Modified files:
/php-src/main rfc1867.c
Log:
- Fixed defines
http://cvs.php.net/diff.php/php-src/main/rfc1867.c?r1=1.154r2=1.155ty=u
Index: php-src/main/rfc1867.c
diff -u php-src/main/rfc1867.c:1.154
derick Wed Mar 24 09:28:41 2004 EDT
Modified files:
/ZendEngine2zend_operators.c
/php-src/main rfc1867.c
Log:
- Revert bogus commit
http://cvs.php.net/diff.php/ZendEngine2/zend_operators.c?r1=1.186r2=1.187ty=u
Index:
sesser Thu Feb 12 13:27:34 2004 EDT
Modified files:
/php-src/main rfc1867.c
Log:
better write into the correct buffer
http://cvs.php.net/diff.php/php-src/main/rfc1867.c?r1=1.150r2=1.151ty=u
Index: php-src/main/rfc1867.c
diff -u
derick Sun Dec 7 09:47:36 2003 EDT
Modified files:
/php-src/main rfc1867.c
Log:
- Add comment, I put this ina week ago and it already confused me :)
Index: php-src/main/rfc1867.c
diff -u php-src/main/rfc1867.c:1.148 php-src/main/rfc1867.c:1.149
---
If we allow odd increments (the code actually increased the limit by 1)
the boundary check is worthless. The last time I commited something I
added a +2 so catch all kinds of off-by-one or off-by-two (this already
catched the filename)
Example: num_vars = 10 and num_var_max = 11
if (num_vars =
Okay, thank you for letting me know it in detail. BTW There should have
been more cleaner code :) I'll take a look at it if time permits.
Moriyoshi
On 2003/11/14, at 0:25, Stefan Esser wrote:
If we allow odd increments (the code actually increased the limit by 1)
the boundary check is worthless.
sesser Wed Nov 12 17:34:59 2003 EDT
Modified files:
/php-src/main rfc1867.c
Log:
Fix odd increments to repair the boundary checks.
Index: php-src/main/rfc1867.c
diff -u php-src/main/rfc1867.c:1.145 php-src/main/rfc1867.c:1.146
---
sesser Wed Nov 12 17:34:59 2003 EDT
Modified files:
/php-src/main rfc1867.c
Log:
Fix odd increments to repair the boundary checks.
I might be missing something, but what is the exact problem behind the
description? As far as I'm concerned, that weird increment is necessary
hirokawaWed Nov 5 18:27:42 2003 EDT
Modified files:
/php-src/main rfc1867.c
Log:
added buffer reallocation for filename.
Index: php-src/main/rfc1867.c
diff -u php-src/main/rfc1867.c:1.144 php-src/main/rfc1867.c:1.145
---
sesser Mon Nov 3 04:16:25 2003 EDT
Modified files:
/php-src/main rfc1867.c
Log:
It is usually a good idea to write only into allocated bufferspace.
Index: php-src/main/rfc1867.c
diff -u php-src/main/rfc1867.c:1.142 php-src/main/rfc1867.c:1.143
---
sesser Mon Nov 3 06:46:34 2003 EDT
Modified files:
/php-src/main rfc1867.c
Log:
Fixed possible crashbug.
Index: php-src/main/rfc1867.c
diff -u php-src/main/rfc1867.c:1.143 php-src/main/rfc1867.c:1.144
--- php-src/main/rfc1867.c:1.143Mon
moriyoshi Thu Jul 3 11:26:12 2003 EDT
Modified files:
/php-src/main rfc1867.c
Log:
Fix build
Index: php-src/main/rfc1867.c
diff -u php-src/main/rfc1867.c:1.140 php-src/main/rfc1867.c:1.141
--- php-src/main/rfc1867.c:1.140Wed Jul 2
iliaa Wed Jul 2 20:55:20 2003 EDT
Modified files:
/php-src/main rfc1867.c
Log:
Compiler warning fix.
Index: php-src/main/rfc1867.c
diff -u php-src/main/rfc1867.c:1.138 php-src/main/rfc1867.c:1.139
--- php-src/main/rfc1867.c:1.138Sat Jun 28
sniper Wed Jul 2 22:59:05 2003 EDT
Modified files:
/php-src/main rfc1867.c
Log:
Cut the long line a bit for readability..
Index: php-src/main/rfc1867.c
diff -u php-src/main/rfc1867.c:1.139 php-src/main/rfc1867.c:1.140
--- php-src/main/rfc1867.c:1.139
55 matches
Mail list logo
