In addition, the memory allocated by FormatMessage() should
be free'd using LocalFree(), not free().
--Wez.
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
ot; <[EMAIL PROTECTED]>
Cc: "Marcus Boerger" <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]>
Sent: Thursday, December 18, 2003 11:47 AM
Subject: Re: [PHP-CVS] cvs: php-src /win32 winutil.c
> Hello Wez,
>
> Thursday, December 18, 2003, 12:23:27 PM, you wrote:
>
> > T
Hello Wez,
Thursday, December 18, 2003, 12:23:27 PM, you wrote:
> There is a deeper problem; this function is actually called
> from many win32 extensions where the result is correctly free'd,
> so we cannot use a static buffer here at all.
That is wrong behavior. The behavior of dl_error() has
wez Thu Dec 18 06:32:20 2003 EDT
Modified files:
/php-src/win32 winutil.c
Log:
make it totally safe again
Index: php-src/win32/winutil.c
diff -u php-src/win32/winutil.c:1.13 php-src/win32/winutil.c:1.14
--- php-src/win32/winutil.c:1.13Thu Dec 18
er" <[EMAIL PROTECTED]>
Cc: <[EMAIL PROTECTED]>
Sent: Thursday, December 18, 2003 11:16 AM
Subject: Re: [PHP-CVS] cvs: php-src /win32 winutil.c
> Hello,
>
> Thursday, December 18, 2003, 12:05:22 PM, you wrote:
>
> > helly Thu Dec 18 06:05:22 2003 EDT
>
>
Hello,
Thursday, December 18, 2003, 12:05:22 PM, you wrote:
> helly Thu Dec 18 06:05:22 2003 EDT
> Modified files:
> /php-src/win32winutil.c
> Log:
> Leak for b3 and find a better solution until RC1
The win guru's liked this behavior more for b3.
But we fo
wez Thu Dec 18 06:16:17 2003 EDT
Modified files:
/php-src/win32 winutil.c
Log:
make sure this is initialized to NULL as we don't check the return
value of the FormatMessage function; we could end up using a stale
pointer.
Index: php-src/win32/win
helly Thu Dec 18 06:05:22 2003 EDT
Modified files:
/php-src/win32 winutil.c
Log:
Leak for b3 and find a better solution until RC1
Index: php-src/win32/winutil.c
diff -u php-src/win32/winutil.c:1.11 php-src/win32/winutil.c:1.12
--- php-src/win32/winutil.c:
