iliaa Wed Dec 4 12:16:19 2002 EDT
Modified files:
/php4/ext/gd/libgd gd_topal.c
Log:
Fixed a memory leak inside gdImageTrueColorToPalette().
Index: php4/ext/gd/libgd/gd_topal.c
diff -u php4/ext/gd/libgd/gd_topal.c:1.9 php4/ext/gd/libgd/gd_topal.c:1.10
---
On Thu, Oct 17, 2002 at 12:06:30AM -0700, Rasmus Lerdorf wrote :
> > > So you are saying you want to make it optional? Because as it is there is
> > > no way to not give a value.
> >
> > Exactly.
>
> I don't see any really compelling reason to do that. When you convert a
> truecolor image
> > So you are saying you want to make it optional? Because as it is there is
> > no way to not give a value.
>
> Exactly.
I don't see any really compelling reason to do that. When you convert a
truecolor image to a palette-based one, not providing the size of this
palette doesn't make any
On Wed, Oct 16, 2002 at 11:25:14PM -0700, Rasmus Lerdorf wrote :
> > On Wed, Oct 16, 2002 at 11:12:25PM -0700, Rasmus Lerdorf wrote :
> > > It's not an optional arg though. So by leaving it off, do you mean if an
> > > invalid value is given? I don't like changing args like that.
> >
> > Ye
> On Wed, Oct 16, 2002 at 11:12:25PM -0700, Rasmus Lerdorf wrote :
> > It's not an optional arg though. So by leaving it off, do you mean if an
> > invalid value is given? I don't like changing args like that.
>
> Yes I know it's not optional. But having it default to 256
> colors makes
On Wed, Oct 16, 2002 at 11:12:25PM -0700, Rasmus Lerdorf wrote :
> It's not an optional arg though. So by leaving it off, do you mean if an
> invalid value is given? I don't like changing args like that.
Yes I know it's not optional. But having it default to 256
colors makes sense if t
It's not an optional arg though. So by leaving it off, do you mean if an
invalid value is given? I don't like changing args like that.
-Rasmus
On Thu, 17 Oct 2002, Markus Fischer wrote:
> On Wed, Oct 16, 2002 at 09:52:53PM -0700, Rasmus Lerdorf wrote :
> > It's not an issue in the external gd
On Wed, Oct 16, 2002 at 09:52:53PM -0700, Rasmus Lerdorf wrote :
> It's not an issue in the external gd since this function doesn't work at
> all there. They had colorsWanted hardcoded to 256.
Ah!
Ok, another suggestion. Wouldn't it make sense to have the
last parameter default to
It's not an issue in the external gd since this function doesn't work at
all there. They had colorsWanted hardcoded to 256.
-Rasmus
On Thu, 17 Oct 2002, Markus Fischer wrote:
> Just a sidenote: I think if this would also be fixed in
> gd/gd.c then we could prevent a segfault with the e
Just a sidenote: I think if this would also be fixed in
gd/gd.c then we could prevent a segfault with the external gd
library too.
On Wed, Oct 16, 2002 at 10:34:45PM -, Rasmus Lerdorf wrote :
> rasmusWed Oct 16 18:34:45 2002 EDT
>
> Modified files:
rasmus Wed Oct 16 18:34:45 2002 EDT
Modified files:
/php4/ext/gd/libgd gd_topal.c
Log:
Fix for bug #19941
Index: php4/ext/gd/libgd/gd_topal.c
diff -u php4/ext/gd/libgd/gd_topal.c:1.7 php4/ext/gd/libgd/gd_topal.c:1.8
--- php4/ext/gd/libgd/gd_topal.c:1.7
rasmus Sun Oct 6 13:47:51 2002 EDT
Modified files:
/php4/ext/gd/libgd gd_topal.c
Log:
Fix for bug 19781
Index: php4/ext/gd/libgd/gd_topal.c
diff -u php4/ext/gd/libgd/gd_topal.c:1.6 php4/ext/gd/libgd/gd_topal.c:1.7
--- php4/ext/gd/libgd/gd_topal.c:1.6S
rasmus Sun Oct 6 03:19:08 2002 EDT
Modified files:
/php4/ext/gd/libgd gd_topal.c
Log:
Ok, perhaps it's too late at night, but I see absolutely no reason for
this chunk of code here. Why is it writing a palette.map file to disk
in the middle of this functio
13 matches
Mail list logo
