Re: [PHP-CVS] cvs: php4 /main fopen_wrappers.c

2003-03-27 Thread Sterling Hughes
On Thu, 2003-03-27 at 11:23, Moriyoshi Koizumi wrote: > Moriyoshi Koizumi <[EMAIL PROTECTED]> wrote: > > Moriyoshit > > Oh, I'm no shit... > Uh-oh, I think you just got a new nickname. empty_string can be free'd by efree() which is what we're worrying about more anyway. -Sterling > Moriyoshi

Re: [PHP-CVS] cvs: php4 /main fopen_wrappers.c

2003-03-27 Thread Moriyoshi Koizumi
Moriyoshi Koizumi <[EMAIL PROTECTED]> wrote: > Moriyoshit Oh, I'm no shit... Moriyoshi -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php4 /main fopen_wrappers.c

2003-03-27 Thread Moriyoshi Koizumi
How about using empty_string? As it can't be freed by STR_FREE(), we can reduce certain risks. Moriyoshit Sterling Hughes <[EMAIL PROTECTED]> wrote: > On Thu, 2003-03-27 at 01:15, Andi Gutmans wrote: > > OK... :) I hope no one tries to efree() this though. > > > > I hope so too. I'm not sure

Re: [PHP-CVS] cvs: php4 /main fopen_wrappers.c

2003-03-27 Thread Sterling Hughes
On Thu, 2003-03-27 at 01:15, Andi Gutmans wrote: > OK... :) I hope no one tries to efree() this though. > I hope so too. I'm not sure, between this and return NULL, and then having callers check for it. -Sterling > > At 11:03 PM 3/26/2003 +, Sterling Hughes wrote: > >sterling

Re: [PHP-CVS] cvs: php4 /main fopen_wrappers.c

2003-03-27 Thread Jani Taskinen
MFH? On Wed, 26 Mar 2003, Sterling Hughes wrote: >sterling Wed Mar 26 18:03:48 2003 EDT > > Modified files: >/php4/main fopen_wrappers.c > Log: > really fix > > >Index: php4/main/fopen_wrappers.c >diff -u php4/main/fopen_wrappers.c:1.160 php4/main/fope

Re: [PHP-CVS] cvs: php4 /main fopen_wrappers.c

2003-03-26 Thread Andi Gutmans
OK... :) I hope no one tries to efree() this though. At 11:03 PM 3/26/2003 +, Sterling Hughes wrote: sterlingWed Mar 26 18:03:48 2003 EDT Modified files: /php4/main fopen_wrappers.c Log: really fix Index: php4/main/fopen_wrappers.c diff -u php4/main/fopen_wrappers.c

Re: [PHP-CVS] cvs: php4 /main fopen_wrappers.c

2003-03-26 Thread Andi Gutmans
Are you sure this is the right place to fix it? I would fix the place which calls this function because you might end up crashing on the returned null in the places which call this. At 11:01 PM 3/26/2003 +, Sterling Hughes wrote: sterlingWed Mar 26 18:01:39 2003 EDT Modifi

[PHP-CVS] cvs: php4 /main fopen_wrappers.c

2003-03-26 Thread Sterling Hughes
sterlingWed Mar 26 18:03:48 2003 EDT Modified files: /php4/main fopen_wrappers.c Log: really fix Index: php4/main/fopen_wrappers.c diff -u php4/main/fopen_wrappers.c:1.160 php4/main/fopen_wrappers.c:1.161 --- php4/main/fopen_wrappers.c:1.160Wed M

[PHP-CVS] cvs: php4 /main fopen_wrappers.c

2003-03-26 Thread Sterling Hughes
sterlingWed Mar 26 18:01:39 2003 EDT Modified files: /php4/main fopen_wrappers.c Log: fix segfault Index: php4/main/fopen_wrappers.c diff -u php4/main/fopen_wrappers.c:1.159 php4/main/fopen_wrappers.c:1.160 --- php4/main/fopen_wrappers.c:1.159Sun

[PHP-CVS] cvs: php4 /main fopen_wrappers.c

2003-02-23 Thread Jani Taskinen
sniper Sun Feb 23 17:30:02 2003 EDT Modified files: /php4/main fopen_wrappers.c Log: MFB: Fix for open_basedir error message Index: php4/main/fopen_wrappers.c diff -u php4/main/fopen_wrappers.c:1.158 php4/main/fopen_wrappers.c:1.159 --- php4/main/fopen_wrapper

Re: [PHP-CVS] cvs: php4 /main fopen_wrappers.c

2002-12-01 Thread Shane Caraveo
See my postings on php-dev about this. This particular patch is just one part of the problem. Shane Jani Taskinen wrote: MFH?? And are there possibly some bug reports caused by this..? --Jani On Sun, 1 Dec 2002, Shane Caraveo wrote: shane Sun Dec 1 16:28:28 2002 EDT

Re: [PHP-CVS] cvs: php4 /main fopen_wrappers.c

2002-12-01 Thread Jani Taskinen
MFH?? And are there possibly some bug reports caused by this..? --Jani On Sun, 1 Dec 2002, Shane Caraveo wrote: >shane Sun Dec 1 16:28:28 2002 EDT > > Modified files: >/php4/main fopen_wrappers.c > Log: > php_error_docref aborts cgi. This

Re: [PHP-CVS] cvs: php4 /main fopen_wrappers.c

2002-12-01 Thread Shane Caraveo
Because of how cgi handles this in the first place. If a person uses bang lines, they would get a warning issued all the time prior to their script even executing, if they are outputing warnings. Shane Marcus Börger wrote: Why not simply change from E_ERROR to E_WARNING? marcus At 22:28 01.12

Re: [PHP-CVS] cvs: php4 /main fopen_wrappers.c

2002-12-01 Thread Marcus Börger
Why not simply change from E_ERROR to E_WARNING? marcus At 22:28 01.12.2002, Shane Caraveo wrote: shane Sun Dec 1 16:28:28 2002 EDT Modified files: /php4/main fopen_wrappers.c Log: php_error_docref aborts cgi. This broke using php as cgi under apache/mod_cgi with the cg

[PHP-CVS] cvs: php4 /main fopen_wrappers.c

2002-12-01 Thread Shane Caraveo
shane Sun Dec 1 16:28:28 2002 EDT Modified files: /php4/main fopen_wrappers.c Log: php_error_docref aborts cgi. This broke using php as cgi under apache/mod_cgi with the cgi-script directive and bang lines in php scripts. removing it allows this to work ag

[PHP-CVS] cvs: php4 /main fopen_wrappers.c

2002-11-08 Thread Ilia Alshanetsky
iliaa Fri Nov 8 17:48:02 2002 EDT Modified files: /php4/main fopen_wrappers.c Log: Made open_basedir error more descriptive. Index: php4/main/fopen_wrappers.c diff -u php4/main/fopen_wrappers.c:1.152 php4/main/fopen_wrappers.c:1.153 --- php4/main/fopen_wr

[PHP-CVS] cvs: php4 /main fopen_wrappers.c TSRM tsrm_virtual_cwd.c tsrm_virtual_cwd.h

2002-11-05 Thread Ilia Alshanetsky
iliaa Tue Nov 5 09:50:17 2002 EDT Modified files: /TSRM tsrm_virtual_cwd.h tsrm_virtual_cwd.c /php4/main fopen_wrappers.c Log: Added 4th argument to virtual_file_ex() that specifies whether or not realpath() should be used during path resolving. In

[PHP-CVS] cvs: php4 /main fopen_wrappers.c

2002-10-04 Thread Brian France
bfrance Fri Oct 4 18:16:19 2002 EDT Modified files: /php4/main fopen_wrappers.c Log: Fixed a problem where opendir with / and having / in open_basedir ini option didn't work. It was removing the trailing slashes and then addeding

[PHP-CVS] cvs: php4 /main fopen_wrappers.c

2002-09-28 Thread Rasmus Lerdorf
rasmus Sat Sep 28 12:27:10 2002 EDT Modified files: /php4/main fopen_wrappers.c Log: Uh, this is what I meant to do. Fix for #19292 Index: php4/main/fopen_wrappers.c diff -u php4/main/fopen_wrappers.c:1.149 php4/main/fopen_wrappers.c:1.150 --- php4/main/f

[PHP-CVS] cvs: php4 /main fopen_wrappers.c

2002-09-28 Thread Rasmus Lerdorf
rasmus Sat Sep 28 12:10:43 2002 EDT Modified files: /php4/main fopen_wrappers.c Log: Probable fix for bug #19292 Index: php4/main/fopen_wrappers.c diff -u php4/main/fopen_wrappers.c:1.148 php4/main/fopen_wrappers.c:1.149 --- php4/main/fopen_wrappers.c:1.14

[PHP-CVS] cvs: php4 /main fopen_wrappers.c

2002-09-22 Thread Ilia Alshanetsky
iliaa Sun Sep 22 14:30:38 2002 EDT Modified files: /php4/main fopen_wrappers.c Log: Fixed bug #19395 Index: php4/main/fopen_wrappers.c diff -u php4/main/fopen_wrappers.c:1.147 php4/main/fopen_wrappers.c:1.148 --- php4/main/fopen_wrappers.c:1.147Mon Se

[PHP-CVS] cvs: php4 /main fopen_wrappers.c

2002-09-09 Thread Anantha Kesari H Y
hyanantha Mon Sep 9 06:56:28 2002 EDT Modified files: /php4/main fopen_wrappers.c Log: NetWare related changes/modifications Index: php4/main/fopen_wrappers.c diff -u php4/main/fopen_wrappers.c:1.146 php4/main/fopen_wrappers.c:1.147 --- php4/main/fop