Re: [PHP-CVS] cvs: php4 /main output.c

2003-04-04 Thread Sascha Schumann
On Fri, 4 Apr 2003, Jani Taskinen wrote: > > Heh..you just couldn't wait me to MFH, could you? Well, apparently the news have not reached you yet. Some people are unhappy with the WS commits all over the place, so please suspend such commits for now, until we have an agreemen

Re: [PHP-CVS] cvs: php4 /main output.c

2003-04-04 Thread Jani Taskinen
Heh..you just couldn't wait me to MFH, could you? --Jani On Fri, 4 Apr 2003, Sascha Schumann wrote: >sasFri Apr 4 03:40:48 2003 EDT > > Modified files: >/php4/main output.c > Log: > Backout Jani's commit to resync branches > > -- <- For

Re: [PHP-CVS] cvs: php4 /main output.c

2003-04-04 Thread Rasmus Lerdorf
You are twisting my words completely. I simply said that for minor white-space issues, like "a=1" vs. "a = 1", the lesser of the evils is to just leave it be since these whitespace commits are a pain in the ass when it comes to branch merging, cvs history tracking of problems, etc. -Rasmus On Fr

Re: [PHP-CVS] cvs: php4 /main output.c

2003-04-04 Thread Sascha Schumann
On Fri, 4 Apr 2003, Andi Gutmans wrote: > I don't think we should back-out these kind of whitespace fixes. I tend to > agree with Jani and I think he's doing a good job whitespacing code. I also Well, indent(1) will probably achieve the same result with the right options.. > think that R

Re: [PHP-CVS] cvs: php4 /main output.c

2003-04-04 Thread Andi Gutmans
I don't think we should back-out these kind of whitespace fixes. I tend to agree with Jani and I think he's doing a good job whitespacing code. I also think that Rasmus reasoning for not commiting correctly whitespaced code because we have lots of broken code in PHP, is not very strong. Let's tr

[PHP-CVS] cvs: php4 /main output.c

2003-04-04 Thread Sascha Schumann
sas Fri Apr 4 03:40:48 2003 EDT Modified files: /php4/main output.c Log: Backout Jani's commit to resync branches Index: php4/main/output.c diff -u php4/main/output.c:1.154 php4/main/output.c:1.155 --- php4/main/output.c:1.154Thu Apr 3 13:44:00 2003

Re: [PHP-CVS] cvs: php4 /main output.c

2003-04-03 Thread Sascha Schumann
On Thu, 3 Apr 2003, Jani Taskinen wrote: > sniperThu Apr 3 13:44:00 2003 EDT > > Modified files: > /php4/mainoutput.c > Log: > WS & CS fix Jani, in addition to regularly polluting the CVS history, you are also desyncing the various branches. This does n

[PHP-CVS] cvs: php4 /main output.c

2003-04-03 Thread Jani Taskinen
sniper Thu Apr 3 13:44:00 2003 EDT Modified files: /php4/main output.c Log: WS & CS fix Index: php4/main/output.c diff -u php4/main/output.c:1.153 php4/main/output.c:1.154 --- php4/main/output.c:1.153Thu Apr 3 13:19:15 2003 +++ php4/main/output.c Thu Apr

[PHP-CVS] cvs: php4 /main output.c

2003-04-03 Thread Sascha Schumann
sas Thu Apr 3 13:19:15 2003 EDT Modified files: /php4/main output.c Log: Add some checks and avoid passing invalid data to call_user_function_ex. Fixes some heap corruption and allocation of negative amounts of memory. Index: php4/main/output.c dif

[PHP-CVS] cvs: php4 /main output.c

2003-04-02 Thread Moriyoshi Koizumi
moriyoshi Wed Apr 2 19:50:17 2003 EDT Modified files: /php4/main output.c Log: Fixed memleak in output buffering facility Index: php4/main/output.c diff -u php4/main/output.c:1.151 php4/main/output.c:1.152 --- php4/main/output.c:1.151Tue Apr 1 14

[PHP-CVS] cvs: php4 /main output.c

2003-04-01 Thread Sascha Schumann
sas Tue Apr 1 14:14:47 2003 EDT Modified files: /php4/main output.c Log: Fix an uninitialized read, default to FAILURE Index: php4/main/output.c diff -u php4/main/output.c:1.150 php4/main/output.c:1.151 --- php4/main/output.c:1.150Tue Mar 25 03:07:1

[PHP-CVS] cvs: php4 /main output.c

2003-02-03 Thread Hartmut Holzgraefe
hholzgraMon Feb 3 18:36:20 2003 EDT Modified files: /php4/main output.c Log: proto-fix Index: php4/main/output.c diff -u php4/main/output.c:1.146 php4/main/output.c:1.147 --- php4/main/output.c:1.146Mon Jan 27 12:22:22 2003 +++ php4/main/output.

[PHP-CVS] cvs: php4 /main output.c

2003-01-27 Thread Ilia Alshanetsky
iliaa Mon Jan 27 12:22:23 2003 EDT Modified files: /php4/main output.c Log: Removed pointless checks. Index: php4/main/output.c diff -u php4/main/output.c:1.145 php4/main/output.c:1.146 --- php4/main/output.c:1.145Tue Dec 31 10:58:52 2002 +++ php4/main

Re: [PHP-CVS] cvs: php4 /main output.c

2002-10-07 Thread Derick Rethans
On Fri, 4 Oct 2002, Marcus Börger wrote: > This affects some of the newly introduced tests and the ob discussion... > > Derick could you verify that your test uses the correct ini file when running: > > sapi/cli/php -c php.ini-dist run-tests.php tests/strings/004.phpt > > Remember the handling

[PHP-CVS] cvs: php4 /main output.c

2002-10-07 Thread Zeev Suraski
zeevMon Oct 7 07:21:06 2002 EDT Modified files: /php4/main output.c Log: Whitespace Index: php4/main/output.c diff -u php4/main/output.c:1.141 php4/main/output.c:1.142 --- php4/main/output.c:1.141Sun Oct 6 08:02:53 2002 +++ php4/main/output.c Mon

Re: [PHP-CVS] cvs: php4 /main output.c

2002-10-04 Thread Marcus Börger
This affects some of the newly introduced tests and the ob discussion... Derick could you verify that your test uses the correct ini file when running: sapi/cli/php -c php.ini-dist run-tests.php tests/strings/004.phpt Remember the handling and test for ini detection is currently NOT correct. As

[PHP-CVS] cvs: php4 /main output.c

2002-10-04 Thread Marcus Börger
helly Fri Oct 4 13:11:36 2002 EDT Modified files: /php4/main output.c Log: suggest paranthesis around || and && Index: php4/main/output.c diff -u php4/main/output.c:1.138 php4/main/output.c:1.139 --- php4/main/output.c:1.138Thu Oct 3 09:32:01 2002 +

[PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /main output.c

2002-10-03 Thread Jon Parise
On Thu, Oct 03, 2002 at 08:05:51PM +0900, Yasuo Ohgaki wrote: > >Can you please re-test things regarding to this? I reverted Yasuo's > >commits and I might have overlooked something. > > What kind of diff you are using? > I guess you are willing to revert my patches, but you don't. > > BTW, st

[PHP-CVS] cvs: php4 /main output.c

2002-10-03 Thread James Moore
jmoore Thu Oct 3 07:56:10 2002 EDT Modified files: /php4/main output.c Log: Keep comments and code in sync. Index: php4/main/output.c diff -u php4/main/output.c:1.136 php4/main/output.c:1.137 --- php4/main/output.c:1.136Thu Oct 3 07:08:09 2002 +++ ph

Re: [PHP-CVS] cvs: php4 /main output.c

2002-10-03 Thread Marcus Börger
Not related...i only fixed the logic what information to display. At 13:01 03.10.2002, Derick Rethans wrote: >On Wed, 2 Oct 2002, Marcus Börger wrote: > > > helly Wed Oct 2 11:10:11 2002 EDT > > > > Modified files: > > /php4/mainoutput.c > > Log: > > Modified get_status

[PHP-CVS] cvs: php4 /main output.c

2002-10-03 Thread Sebastian Bergmann
sebastian Thu Oct 3 07:08:09 2002 EDT Modified files: /php4/main output.c Log: Fix warnings. Index: php4/main/output.c diff -u php4/main/output.c:1.135 php4/main/output.c:1.136 --- php4/main/output.c:1.135Thu Oct 3 06:35:32 2002 +++ php4/main/ou

Re: [PHP-CVS] cvs: php4 /main output.c

2002-10-03 Thread Yasuo Ohgaki
Derick Rethans wrote: > On Wed, 2 Oct 2002, Marcus Börger wrote: > > >>helly Wed Oct 2 11:10:11 2002 EDT >> >> Modified files: >>/php4/mainoutput.c >> Log: >> Modified get_status(): Display chunk_size allways and size which is in >> most cases initial_size

Re: [PHP-CVS] cvs: php4 /main output.c

2002-10-03 Thread Derick Rethans
On Wed, 2 Oct 2002, Marcus Börger wrote: > helly Wed Oct 2 11:10:11 2002 EDT > > Modified files: > /php4/mainoutput.c > Log: > Modified get_status(): Display chunk_size allways and size which is in > most cases initial_size as well as block_size only w

Re: [PHP-CVS] cvs: php4 /main output.c

2002-10-03 Thread Derick Rethans
On Thu, 3 Oct 2002, Yasuo Ohgaki wrote: > yohgaki Thu Oct 3 04:54:14 2002 EDT > > Modified files: > /php4/mainoutput.c > Log: > Added comment for php_output_set_status(). > Please use this function if you would like to prevent unwanted flush >

[PHP-CVS] cvs: php4 /main output.c

2002-10-03 Thread Yasuo Ohgaki
yohgaki Thu Oct 3 04:54:14 2002 EDT Modified files: /php4/main output.c Log: Added comment for php_output_set_status(). Please use this function if you would like to prevent unwanted flush by implicit_flush=On or ob_implicit_flush(). Index: php4/

[PHP-CVS] cvs: php4 /main output.c

2002-10-02 Thread Yasuo Ohgaki
yohgaki Thu Oct 3 00:17:41 2002 EDT Modified files: /php4/main output.c Log: Added missing proto and foldings. Index: php4/main/output.c diff -u php4/main/output.c:1.131 php4/main/output.c:1.132 --- php4/main/output.c:1.131Wed Oct 2 23:58:12 2002 +++

[PHP-CVS] cvs: php4 /main output.c

2002-10-02 Thread Yasuo Ohgaki
yohgaki Wed Oct 2 22:55:19 2002 EDT Modified files: /php4/main output.c Log: Made some functions inline. Added static for unexported functions. Index: php4/main/output.c diff -u php4/main/output.c:1.129 php4/main/output.c:1.130 --- php4/main/output.c:1.1

[PHP-CVS] cvs: php4 /main output.c

2002-10-02 Thread Marcus Börger
helly Wed Oct 2 11:10:11 2002 EDT Modified files: /php4/main output.c Log: Modified get_status(): Display chunk_size allways and size which is in most cases initial_size as well as block_size only when used. Index: php4/main/output.c diff -u php4/main/

[PHP-CVS] cvs: php4 /main output.c

2002-10-01 Thread Yasuo Ohgaki
yohgaki Tue Oct 1 06:01:56 2002 EDT Modified files: /php4/main output.c Log: Fixed bug #17825. Double zval_ptr_dtor(). Index: php4/main/output.c diff -u php4/main/output.c:1.124 php4/main/output.c:1.125 --- php4/main/output.c:1.124Mon Sep 30 22:43:33 2

[PHP-CVS] cvs: php4 /main output.c

2002-09-30 Thread Yasuo Ohgaki
yohgaki Mon Sep 30 22:43:33 2002 EDT Modified files: /php4/main output.c Log: Fixed implicit flush. Index: php4/main/output.c diff -u php4/main/output.c:1.123 php4/main/output.c:1.124 --- php4/main/output.c:1.123Mon Sep 30 19:46:43 2002 +++ php4/main/ou

[PHP-CVS] cvs: php4 /main output.c

2002-09-30 Thread Yasuo Ohgaki
yohgaki Mon Sep 30 19:46:43 2002 EDT Modified files: /php4/main output.c Log: Users can shoot themselves by their own output handler always. Therefore, this check is overkill and it should be documented limitation, IMO. Anyway, a little optimization.

[PHP-CVS] cvs: php4 /main output.c

2002-09-23 Thread Zeev Suraski
zeevMon Sep 23 10:18:43 2002 EDT Modified files: /php4/main output.c Log: Fix bug #19525 Index: php4/main/output.c diff -u php4/main/output.c:1.120 php4/main/output.c:1.121 --- php4/main/output.c:1.120Sun Sep 1 07:33:19 2002 +++ php4/main/output.c