[PHP-CVS] cvs: php4 /main output.c

2003-04-04 Thread Sascha Schumann
sas Fri Apr 4 03:40:48 2003 EDT Modified files: /php4/main output.c Log: Backout Jani's commit to resync branches Index: php4/main/output.c diff -u php4/main/output.c:1.154 php4/main/output.c:1.155 --- php4/main/output.c:1.154Thu Apr 3 13:44:00

Re: [PHP-CVS] cvs: php4 /main output.c

2003-04-04 Thread Andi Gutmans
I don't think we should back-out these kind of whitespace fixes. I tend to agree with Jani and I think he's doing a good job whitespacing code. I also think that Rasmus reasoning for not commiting correctly whitespaced code because we have lots of broken code in PHP, is not very strong. Let's

Re: [PHP-CVS] cvs: php4 /main output.c

2003-04-04 Thread Rasmus Lerdorf
You are twisting my words completely. I simply said that for minor white-space issues, like a=1 vs. a = 1, the lesser of the evils is to just leave it be since these whitespace commits are a pain in the ass when it comes to branch merging, cvs history tracking of problems, etc. -Rasmus On Fri,

Re: [PHP-CVS] cvs: php4 /main output.c

2003-04-04 Thread Jani Taskinen
Heh..you just couldn't wait me to MFH, could you? --Jani On Fri, 4 Apr 2003, Sascha Schumann wrote: sasFri Apr 4 03:40:48 2003 EDT Modified files: /php4/main output.c Log: Backout Jani's commit to resync branches -- - For Sale! -

Re: [PHP-CVS] cvs: php4 /main output.c

2003-04-04 Thread Sascha Schumann
On Fri, 4 Apr 2003, Jani Taskinen wrote: Heh..you just couldn't wait me to MFH, could you? Well, apparently the news have not reached you yet. Some people are unhappy with the WS commits all over the place, so please suspend such commits for now, until we have an agreement

[PHP-CVS] cvs: php4 /main output.c

2003-04-03 Thread Sascha Schumann
sas Thu Apr 3 13:19:15 2003 EDT Modified files: /php4/main output.c Log: Add some checks and avoid passing invalid data to call_user_function_ex. Fixes some heap corruption and allocation of negative amounts of memory. Index: php4/main/output.c

[PHP-CVS] cvs: php4 /main output.c

2003-04-03 Thread Jani Taskinen
sniper Thu Apr 3 13:44:00 2003 EDT Modified files: /php4/main output.c Log: WS CS fix Index: php4/main/output.c diff -u php4/main/output.c:1.153 php4/main/output.c:1.154 --- php4/main/output.c:1.153Thu Apr 3 13:19:15 2003 +++ php4/main/output.c Thu Apr

Re: [PHP-CVS] cvs: php4 /main output.c

2003-04-03 Thread Sascha Schumann
On Thu, 3 Apr 2003, Jani Taskinen wrote: sniperThu Apr 3 13:44:00 2003 EDT Modified files: /php4/mainoutput.c Log: WS CS fix Jani, in addition to regularly polluting the CVS history, you are also desyncing the various branches. This does not

[PHP-CVS] cvs: php4 /main output.c

2003-04-02 Thread Moriyoshi Koizumi
moriyoshi Wed Apr 2 19:50:17 2003 EDT Modified files: /php4/main output.c Log: Fixed memleak in output buffering facility Index: php4/main/output.c diff -u php4/main/output.c:1.151 php4/main/output.c:1.152 --- php4/main/output.c:1.151Tue Apr 1

[PHP-CVS] cvs: php4 /main output.c

2003-04-01 Thread Sascha Schumann
sas Tue Apr 1 14:14:47 2003 EDT Modified files: /php4/main output.c Log: Fix an uninitialized read, default to FAILURE Index: php4/main/output.c diff -u php4/main/output.c:1.150 php4/main/output.c:1.151 --- php4/main/output.c:1.150Tue Mar 25

[PHP-CVS] cvs: php4 /main output.c

2003-02-03 Thread Hartmut Holzgraefe
hholzgraMon Feb 3 18:36:20 2003 EDT Modified files: /php4/main output.c Log: proto-fix Index: php4/main/output.c diff -u php4/main/output.c:1.146 php4/main/output.c:1.147 --- php4/main/output.c:1.146Mon Jan 27 12:22:22 2003 +++

[PHP-CVS] cvs: php4 /main output.c

2003-01-27 Thread Ilia Alshanetsky
iliaa Mon Jan 27 12:22:23 2003 EDT Modified files: /php4/main output.c Log: Removed pointless checks. Index: php4/main/output.c diff -u php4/main/output.c:1.145 php4/main/output.c:1.146 --- php4/main/output.c:1.145Tue Dec 31 10:58:52 2002 +++

Re: [PHP-CVS] cvs: php4 /main output.c

2002-10-07 Thread Derick Rethans
On Fri, 4 Oct 2002, Marcus Börger wrote: This affects some of the newly introduced tests and the ob discussion... Derick could you verify that your test uses the correct ini file when running: sapi/cli/php -c php.ini-dist run-tests.php tests/strings/004.phpt Remember the handling and

[PHP-CVS] cvs: php4 /main output.c

2002-10-04 Thread Marcus Börger
helly Fri Oct 4 13:11:36 2002 EDT Modified files: /php4/main output.c Log: suggest paranthesis around || and Index: php4/main/output.c diff -u php4/main/output.c:1.138 php4/main/output.c:1.139 --- php4/main/output.c:1.138Thu Oct 3 09:32:01 2002

Re: [PHP-CVS] cvs: php4 /main output.c

2002-10-04 Thread Marcus Börger
This affects some of the newly introduced tests and the ob discussion... Derick could you verify that your test uses the correct ini file when running: sapi/cli/php -c php.ini-dist run-tests.php tests/strings/004.phpt Remember the handling and test for ini detection is currently NOT correct.

[PHP-CVS] cvs: php4 /main output.c

2002-10-03 Thread Yasuo Ohgaki
yohgaki Thu Oct 3 04:54:14 2002 EDT Modified files: /php4/main output.c Log: Added comment for php_output_set_status(). Please use this function if you would like to prevent unwanted flush by implicit_flush=On or ob_implicit_flush(). Index:

[PHP-CVS] cvs: php4 /main output.c

2002-10-01 Thread Yasuo Ohgaki
yohgaki Tue Oct 1 06:01:56 2002 EDT Modified files: /php4/main output.c Log: Fixed bug #17825. Double zval_ptr_dtor(). Index: php4/main/output.c diff -u php4/main/output.c:1.124 php4/main/output.c:1.125 --- php4/main/output.c:1.124Mon Sep 30 22:43:33

[PHP-CVS] cvs: php4 /main output.c

2002-09-30 Thread Yasuo Ohgaki
yohgaki Mon Sep 30 22:43:33 2002 EDT Modified files: /php4/main output.c Log: Fixed implicit flush. Index: php4/main/output.c diff -u php4/main/output.c:1.123 php4/main/output.c:1.124 --- php4/main/output.c:1.123Mon Sep 30 19:46:43 2002 +++

[PHP-CVS] cvs: php4 /main output.c

2002-09-23 Thread Zeev Suraski
zeevMon Sep 23 10:18:43 2002 EDT Modified files: /php4/main output.c Log: Fix bug #19525 Index: php4/main/output.c diff -u php4/main/output.c:1.120 php4/main/output.c:1.121 --- php4/main/output.c:1.120Sun Sep 1 07:33:19 2002 +++ php4/main/output.c