Keep the patch in there for now.
--Wez.
On Sun, 16 Feb 2003, Moriyoshi Koizumi wrote:
> So should I revert the patch on HEAD then?
>
> Moriyoshi
>
> Wez Furlong <[EMAIL PROTECTED]> wrote:
>
> > Actually, the return values throughout that function are all bogus...
> > Don't worry about reverting
So should I revert the patch on HEAD then?
Moriyoshi
Wez Furlong <[EMAIL PROTECTED]> wrote:
> Actually, the return values throughout that function are all bogus...
> Don't worry about reverting (for 4.3).
> I'll add this to my TODO for PHP 5.
>
> --Wez.
>
> On Sat, 15 Feb 2003, Wez Furlong wro
Actually, the return values throughout that function are all bogus...
Don't worry about reverting (for 4.3).
I'll add this to my TODO for PHP 5.
--Wez.
On Sat, 15 Feb 2003, Wez Furlong wrote:
> This is a bogus patch; the return value of the php_stream_copy_to_XXX
> functions are the number of by
This is a bogus patch; the return value of the php_stream_copy_to_XXX
functions are the number of bytes that were copied, and this patch
breaks that.
The correct fix for #22234 is to fix php_copy_file() to handle a 0
return from this function.
Please revert!
--Wez.
On Sat, 15 Feb 2003, Moriyosh
moriyoshi Sat Feb 15 14:56:13 2003 EDT
Modified files:
/php4/main streams.c
Log:
Fixed bug #22234
Index: php4/main/streams.c
diff -u php4/main/streams.c:1.154 php4/main/streams.c:1.155
--- php4/main/streams.c:1.154 Thu Feb 13 16:08:04 2003
+++ php4/m
wez Thu Feb 13 16:08:05 2003 EDT
Modified files:
/php4/main streams.c
Log:
MFB: Fix for bug #22199
Index: php4/main/streams.c
diff -u php4/main/streams.c:1.153 php4/main/streams.c:1.154
--- php4/main/streams.c:1.153 Thu Feb 13 12:20:20 2003
+++ php4/ma
wez Thu Feb 13 12:20:21 2003 EDT
Modified files:
/php4/main streams.c
Log:
A probable cure for many getcwd/relative include related problems for win32.
Index: php4/main/streams.c
diff -u php4/main/streams.c:1.152 php4/main/streams.c:1.153
--- php4/main/s
iliaa Thu Feb 13 11:22:04 2003 EDT
Modified files:
/php4/main streams.c
Log:
Fixed a typo.
Index: php4/main/streams.c
diff -u php4/main/streams.c:1.151 php4/main/streams.c:1.152
--- php4/main/streams.c:1.151 Thu Feb 13 10:09:39 2003
+++ php4/main/streams
iliaa Thu Feb 13 10:09:39 2003 EDT
Modified files:
/php4/main streams.c
Log:
Simplified the mode validation code & added support for read+write mode to
'x' mode.
Index: php4/main/streams.c
diff -u php4/main/streams.c:1.150 php4/main/streams.c:1.151
--- p
wez Thu Feb 13 09:52:54 2003 EDT
Modified files:
/php4/main streams.c
Log:
Clarify error message.
Index: php4/main/streams.c
diff -u php4/main/streams.c:1.149 php4/main/streams.c:1.150
--- php4/main/streams.c:1.149 Thu Feb 13 09:40:16 2003
+++ php4/mai
wez Thu Feb 13 06:12:57 2003 EDT
Modified files:
/php4/main streams.c
Log:
Whitespace-fix these goto labels.
Index: php4/main/streams.c
diff -u php4/main/streams.c:1.146 php4/main/streams.c:1.147
--- php4/main/streams.c:1.146 Wed Feb 12 20:17:45 2003
+
wez Wed Feb 12 20:17:45 2003 EDT
Modified files:
/php4/main streams.c
Log:
Fix for Bug #21815 (fpassthru ignored buffered data but then complained anyway)
Index: php4/main/streams.c
diff -u php4/main/streams.c:1.145 php4/main/streams.c:1.146
--- php4/mai
sas Thu Jan 30 16:06:35 2003 EDT
Modified files:
/php4/main streams.c
Log:
Fix sticky EOF problem
Sometimes streams signal a temporary EOF, because all current data
has been consumed. But that does not preclude the possibility that
more data will beco
wez Mon Jan 6 18:27:03 2003 EDT
Modified files:
/php4/main streams.c
Log:
Fix for Bug #20827: where stat is a macro on Tru64.
Patch from <[EMAIL PROTECTED]>
Index: php4/main/streams.c
diff -u php4/main/streams.c:1.141 php4/main/streams.c:1.142
--- php
wez Sun Dec 22 21:56:46 2002 EDT
Modified files:
/php4/main streams.c
Log:
MFB: fpos_t -> off_t
Index: php4/main/streams.c
diff -u php4/main/streams.c:1.137 php4/main/streams.c:1.138
--- php4/main/streams.c:1.137 Sun Dec 22 13:05:36 2002
+++ php4/main
iliaa Tue Dec 10 11:39:59 2002 EDT
Modified files:
/php4/main streams.c
Log:
MFB
Index: php4/main/streams.c
diff -u php4/main/streams.c:1.133 php4/main/streams.c:1.134
--- php4/main/streams.c:1.133 Mon Dec 9 11:14:28 2002
+++ php4/main/streams.c Tue Dec
wez Mon Dec 9 05:38:35 2002 EDT
Modified files:
/php4/main streams.c
Log:
MFB: #20831 fix
Index: php4/main/streams.c
diff -u php4/main/streams.c:1.131 php4/main/streams.c:1.132
--- php4/main/streams.c:1.131 Fri Nov 22 20:24:08 2002
+++ php4/main/strea
helly Fri Nov 22 20:24:08 2002 EDT
Modified files:
/php4/main streams.c
Log:
MFB: Fix memleak in debug mode
Index: php4/main/streams.c
diff -u php4/main/streams.c:1.130 php4/main/streams.c:1.131
--- php4/main/streams.c:1.130 Mon Nov 18 12:23:21 2002
+++
helly Mon Nov 18 12:23:22 2002 EDT
Modified files:
/php4/main streams.c
Log:
Fix warning as discussed with Wez.
Index: php4/main/streams.c
diff -u php4/main/streams.c:1.129 php4/main/streams.c:1.130
--- php4/main/streams.c:1.129 Mon Nov 18 07:37:19 2002
wez Mon Nov 18 07:37:20 2002 EDT
Modified files:
/php4/main streams.c
Log:
wb -> r+b
Index: php4/main/streams.c
diff -u php4/main/streams.c:1.128 php4/main/streams.c:1.129
--- php4/main/streams.c:1.128 Mon Nov 18 06:39:42 2002
+++ php4/main/streams.c M
iliaa Sat Nov 16 19:06:51 2002 EDT
Modified files:
/php4/main streams.c
Log:
Fixed a problem that would cause include/require("/dir/file") to fail on
Windows.
Index: php4/main/streams.c
diff -u php4/main/streams.c:1.126 php4/main/streams.c:1.127
--- php4
iliaa Sun Nov 10 00:14:27 2002 EDT
Modified files:
/php4/main streams.c
Log:
Fixed a bug that in many situations would cause open_basedir restriction to
be bypassed. Most notable exception, is the inclusion of files via include(),
with a partial path.
wez Thu Oct 31 23:58:23 2002 EDT
Modified files:
/php4/main streams.c
Log:
Probable fix for #20180.
Index: php4/main/streams.c
diff -u php4/main/streams.c:1.122 php4/main/streams.c:1.123
--- php4/main/streams.c:1.122 Mon Oct 28 07:37:31 2002
+++ php4/m
iliaa Mon Oct 28 07:37:31 2002 EDT
Modified files:
/php4/main streams.c
Log:
Fix win32 build.
Index: php4/main/streams.c
diff -u php4/main/streams.c:1.121 php4/main/streams.c:1.122
--- php4/main/streams.c:1.121 Sun Oct 27 22:45:21 2002
+++ php4/main/stre
iliaa Sun Oct 27 19:28:11 2002 EDT
Modified files:
/php4/main streams.c
Log:
Fixed bug #20110.
Index: php4/main/streams.c
diff -u php4/main/streams.c:1.119 php4/main/streams.c:1.120
--- php4/main/streams.c:1.119 Sun Oct 27 18:34:48 2002
+++ php4/main/str
shane Sun Oct 27 18:34:48 2002 EDT
Modified files:
/php4/main streams.c
Log:
dont memmove a null pointer. caught by bounds checker.
Index: php4/main/streams.c
diff -u php4/main/streams.c:1.118 php4/main/streams.c:1.119
--- php4/main/streams.c:1.118 Sun
shane Sun Oct 27 18:01:46 2002 EDT
Modified files:
/php4/main streams.c
Log:
fix Bug #20126
write returns an int, with < 0 being a failure.
Index: php4/main/streams.c
diff -u php4/main/streams.c:1.117 php4/main/streams.c:1.118
--- php4/main/streams.c:1.1
moriyoshi Sun Oct 20 21:33:31 2002 EDT
Modified files:
/php4/main streams.c
Log:
MFH
Index: php4/main/streams.c
diff -u php4/main/streams.c:1.113 php4/main/streams.c:1.114
--- php4/main/streams.c:1.113 Sun Oct 20 16:44:10 2002
+++ php4/main/stream
iliaa Sun Oct 20 16:44:11 2002 EDT
Modified files:
/php4/main streams.c
Log:
Fixed incorrect handling of files starting with a .
Index: php4/main/streams.c
diff -u php4/main/streams.c:1.112 php4/main/streams.c:1.113
--- php4/main/streams.c:1.112 Sat O
Nope. The problem was that size_t is unsigned, but -1 is signed.
--Wez.
On 10/19/02, "Sander Roobol" <[EMAIL PROTECTED]> wrote:
> On Sat, Oct 19, 2002 at 10:34:10AM -, Wez Furlong wrote:
> > - if (justread > 0) {
> > + if (justread != (size_t)-1) {
>
> Shouldn't that be
On Sat, Oct 19, 2002 at 10:34:10AM -, Wez Furlong wrote:
> - if (justread > 0) {
> + if (justread != (size_t)-1) {
Shouldn't that be someting like this?
>>> if (justread != sizeof(size_t)-1) {
Sander
--
PHP CVS Mailing List (http://www.php.net/)
To unsubs
wez Sat Oct 19 06:34:10 2002 EDT
Modified files:
/php4/main streams.c
Log:
Probable fix for #19944
Index: php4/main/streams.c
diff -u php4/main/streams.c:1.110 php4/main/streams.c:1.111
--- php4/main/streams.c:1.110 Fri Oct 18 16:39:49 2002
+++ php4/ma
wez Tue Oct 15 12:38:11 2002 EDT
Modified files:
/php4/main streams.c
Log:
Fix mem leak for zero-byte files.
Index: php4/main/streams.c
diff -u php4/main/streams.c:1.106 php4/main/streams.c:1.107
--- php4/main/streams.c:1.106 Tue Oct 15 12:04:46 2002
wez Tue Oct 15 12:04:47 2002 EDT
Modified files:
/php4/main streams.c
Log:
Some buffer paranoia.
Also, make feof() detection safer (ala recent changes to zlib extension).
Index: php4/main/streams.c
diff -u php4/main/streams.c:1.105 php4/main/streams.c
wez Mon Oct 14 01:38:50 2002 EDT
Modified files:
/php4/main streams.c
Log:
*cough*
Fix inverted logic for the assert.
Index: php4/main/streams.c
diff -u php4/main/streams.c:1.104 php4/main/streams.c:1.105
--- php4/main/streams.c:1.104 Sun Oct 13 22:
wez Sun Oct 13 19:43:46 2002 EDT
Modified files:
/php4/main streams.c
Log:
Remove some old code.
Index: php4/main/streams.c
diff -u php4/main/streams.c:1.102 php4/main/streams.c:1.103
--- php4/main/streams.c:1.102 Sun Oct 13 18:52:33 2002
+++ php4/mai
wez Sun Oct 13 18:52:33 2002 EDT
Modified files:
/php4/main streams.c
Log:
Fix a nasty nasty bug:
When not enough data to satisfy a read was found in the buffer, fgets modifies
the buf pointer to point to the position to store the next chunk. It then
r
wez Fri Oct 11 22:31:43 2002 EDT
Modified files:
/php4/main streams.c
Log:
Write in blocks of the current chunk_size for a stream.
Should resolve problems with network writes.
Index: php4/main/streams.c
diff -u php4/main/streams.c:1.99 php4/main/strea
wez Fri Oct 11 22:56:34 2002 EDT
Modified files:
/php4/main streams.c
Log:
paranoia
Index: php4/main/streams.c
diff -u php4/main/streams.c:1.100 php4/main/streams.c:1.101
--- php4/main/streams.c:1.100 Fri Oct 11 22:31:42 2002
+++ php4/main/streams.c F
sas Sun Oct 6 23:12:06 2002 EDT
Modified files:
/php4/main streams.c
Log:
stdio buffers data in user land. By calling fflush(3), this
data is sent to the kernel using write(2). fsync'ing a
file descriptor is not required -- writing to a fd has the same
wez Sun Oct 6 19:27:53 2002 EDT
Modified files:
/php4/main streams.c
Log:
Try to ensure that we return the number of bytes requested during fread().
Index: php4/main/streams.c
diff -u php4/main/streams.c:1.97 php4/main/streams.c:1.98
--- php4/main/stre
sas Fri Oct 4 15:48:59 2002 EDT
Modified files:
/php4/main streams.c
Log:
Fix EOF cases
Noticed by: Ilia
Index: php4/main/streams.c
diff -u php4/main/streams.c:1.94 php4/main/streams.c:1.95
--- php4/main/streams.c:1.94Fri Oct 4 15:36:09 2002
sas Fri Oct 4 15:36:10 2002 EDT
Modified files:
/php4/main streams.c
Log:
Interrupt loop, if the stream op fails.
Index: php4/main/streams.c
diff -u php4/main/streams.c:1.93 php4/main/streams.c:1.94
--- php4/main/streams.c:1.93Fri Oct 4 15:08:43 2
iliaa Fri Oct 4 14:44:47 2002 EDT
Modified files:
/php4/main streams.c
Log:
Fixed bug #19746
Index: php4/main/streams.c
diff -u php4/main/streams.c:1.90 php4/main/streams.c:1.91
--- php4/main/streams.c:1.90Fri Oct 4 14:21:40 2002
+++ php4/main/strea
helly Thu Oct 3 12:06:42 2002 EDT
Modified files:
/php4/main streams.c
Log:
fix position handling
Index: php4/main/streams.c
diff -u php4/main/streams.c:1.88 php4/main/streams.c:1.89
--- php4/main/streams.c:1.88Wed Oct 2 09:25:38 2002
+++ php4/main/
helly Wed Oct 2 09:25:38 2002 EDT
Modified files:
/php4/main streams.c
Log:
Another missing variable init
#Wez shouldn't "stream->filterhead->fops->flush()" affect return value also?
Index: php4/main/streams.c
diff -u php4/main/streams.c:1.87 php4/main
helly Wed Oct 2 09:18:01 2002 EDT
Modified files:
/php4/main streams.c
Log:
Missing variable init
Index: php4/main/streams.c
diff -u php4/main/streams.c:1.86 php4/main/streams.c:1.87
--- php4/main/streams.c:1.86Sat Sep 28 18:10:46 2002
+++ php4/main/
wez Thu Sep 26 12:22:28 2002 EDT
Modified files:
/php4/main streams.c
Log:
Fix for #19580. (Incorrectly warning about lost data when that is not the
case on systems without fopencookie).
Index: php4/main/streams.c
diff -u php4/main/streams.c:1.83 php4
wez Mon Sep 23 19:39:46 2002 EDT
Modified files:
/php4/main streams.c
Log:
Correct a buglet in the newly introduced buffer code.
# Andi: this might have been the cause of that problem you mentioned.
Index: php4/main/streams.c
diff -u php4/main/streams
wez Mon Sep 23 15:10:33 2002 EDT
Modified files:
/php4/main streams.c
Log:
Ensure that the seekable stream returned for include("http://";) under win32
is based on a temporary file rather than a memory stream.
Index: php4/main/streams.c
diff -u php4/m
wez Mon Sep 23 11:21:17 2002 EDT
Modified files:
/php4/main streams.c
Log:
Hopefully fix the other warnings that my last warning-fixing commit caused.
Index: php4/main/streams.c
diff -u php4/main/streams.c:1.77 php4/main/streams.c:1.78
--- php4/main/str
51 matches
Mail list logo
