Pierre, the code and skip messages like this contradict each other:
> +--SKIPIF--
> +<?php
> +if (substr(PHP_OS, 0, 3) == 'WIN') {
> + die('skip.. only for Windows');
> +}
You're checking that OS is Windows but message says that test is only
for windows. If your intention was to skip this test on Windows, than
message like "skip... not for Windows" would better suit this case.
Otherwise, you need to change "if" condition.
2011/9/6 Pierre Joye <paj...@php.net>:
> pajoye Tue, 06 Sep 2011 07:32:37 +0000
>
> Revision: http://svn.php.net/viewvc?view=revision&revision=316227
>
> Log:
> - skip on win
>
> Changed paths:
> U
> php/php-src/branches/PHP_5_3/ext/standard/tests/directory/open_basedir_001.phpt
> U
> php/php-src/branches/PHP_5_4/ext/standard/tests/directory/open_basedir_001.phpt
> U php/php-src/trunk/ext/standard/tests/directory/open_basedir_001.phpt
>
> Modified:
> php/php-src/branches/PHP_5_3/ext/standard/tests/directory/open_basedir_001.phpt
> ===================================================================
> ---
> php/php-src/branches/PHP_5_3/ext/standard/tests/directory/open_basedir_001.phpt
> 2011-09-06 07:29:59 UTC (rev 316226)
> +++
> php/php-src/branches/PHP_5_3/ext/standard/tests/directory/open_basedir_001.phpt
> 2011-09-06 07:32:37 UTC (rev 316227)
> @@ -1,5 +1,10 @@
> --TEST--
> openbase_dir runtime tightning
> +--SKIPIF--
> +<?php
> +if (substr(PHP_OS, 0, 3) == 'WIN') {
> + die('skip.. only for Windows');
> +}
> --INI--
> open_basedir=/usr/local
> --FILE--
>
> Modified:
> php/php-src/branches/PHP_5_4/ext/standard/tests/directory/open_basedir_001.phpt
> ===================================================================
> ---
> php/php-src/branches/PHP_5_4/ext/standard/tests/directory/open_basedir_001.phpt
> 2011-09-06 07:29:59 UTC (rev 316226)
> +++
> php/php-src/branches/PHP_5_4/ext/standard/tests/directory/open_basedir_001.phpt
> 2011-09-06 07:32:37 UTC (rev 316227)
> @@ -1,5 +1,10 @@
> --TEST--
> openbase_dir runtime tightning
> +--SKIPIF--
> +<?php
> +if (substr(PHP_OS, 0, 3) == 'WIN') {
> + die('skip.. only for Windows');
> +}
> --INI--
> open_basedir=/usr/local
> --FILE--
>
> Modified: php/php-src/trunk/ext/standard/tests/directory/open_basedir_001.phpt
> ===================================================================
> --- php/php-src/trunk/ext/standard/tests/directory/open_basedir_001.phpt
> 2011-09-06 07:29:59 UTC (rev 316226)
> +++ php/php-src/trunk/ext/standard/tests/directory/open_basedir_001.phpt
> 2011-09-06 07:32:37 UTC (rev 316227)
> @@ -1,5 +1,10 @@
> --TEST--
> openbase_dir runtime tightning
> +--SKIPIF--
> +<?php
> +if (substr(PHP_OS, 0, 3) == 'WIN') {
> + die('skip.. only for Windows');
> +}
> --INI--
> open_basedir=/usr/local
> --FILE--
>
>
> --
> PHP CVS Mailing List (http://www.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
>
--
Regards,
Shein Alexey
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
