laruence Mon, 19 Dec 2011 10:05:48 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=321159
Log:
Codes standard Remove useless empty lines
Changed paths:
U php/php-src/branches/PHP_5_4/Zend/zend_compile.c
U
laruence Mon, 05 Dec 2011 12:33:56 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=320425
Log:
Fix typo
Changed paths:
U php/php-src/branches/PHP_5_4/Zend/zend_compile.c
U php/php-src/trunk/Zend/zend_compile.c
Modified:
pierrick Tue, 06 Dec 2011 06:44:22 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=320485
Log:
Coding standard
Changed paths:
U php/php-src/branches/PHP_5_4/Zend/zend_compile.c
U php/php-src/trunk/Zend/zend_compile.c
Modified:
felipe Fri, 18 Nov 2011 13:56:41 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=319487
Log:
- CS
Changed paths:
U php/php-src/branches/PHP_5_4/Zend/zend_compile.c
U php/php-src/trunk/Zend/zend_compile.c
Modified:
Hi Felipe:
On 18 Nov 2011, at 14:56, Felipe Pena wrote:
felipe Fri, 18 Nov 2011 13:56:41 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=319487
- else if (!strncmp(mname, ZEND_DESTRUCTOR_FUNC_NAME, mname_len)) {
ce-destructor
On Fri, Nov 18, 2011 at 3:07 PM, Stefan Marr p...@stefan-marr.de wrote:
Would it be a problem to revert that change, or at least 'table' it again?
http://svn.php.net/viewvc/php/php-src/trunk/CODING_STANDARDS?revision=296679view=markup
Nothing to discuss, love, hate, etc., just apply them :-)
Hi,
2011/11/18 Stefan Marr p...@stefan-marr.de:
Hi Felipe:
On 18 Nov 2011, at 14:56, Felipe Pena wrote:
felipe Fri, 18 Nov 2011 13:56:41 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=319487
- else if (!strncmp(mname,
Hi:
On 18 Nov 2011, at 15:16, Felipe Pena wrote:
Hi,
2011/11/18 Stefan Marr p...@stefan-marr.de:
Hi Felipe:
On 18 Nov 2011, at 14:56, Felipe Pena wrote:
felipe Fri, 18 Nov 2011 13:56:41 +
Revision:
Then at least follow what 3. states as the first (and deducted from that)
most important statement:
Be generous with whitespace
Please, make it look like a table.
That is not against the coding standards. (Which IMHO should leave room for
exceptions when it comes to readability)
Be
On 18 Nov 2011, at 15:36, Felipe Pena wrote:
'Be generous with whitespace' is the opposite of what you want to do.
I.e. generous != stingy. :P
I was obviously to imprecise in my request:
Index: Zend/zend_compile.c
===
---
On Fri, Nov 18, 2011 at 4:03 PM, Stefan Marr p...@stefan-marr.de wrote:
On 18 Nov 2011, at 15:36, Felipe Pena wrote:
'Be generous with whitespace' is the opposite of what you want to do.
I.e. generous != stingy. :P
I was obviously to imprecise in my request:
I do not want to sound harsh but
felipe Thu, 17 Nov 2011 21:07:52 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=319422
Log:
- Fix build
Changed paths:
U php/php-src/branches/PHP_5_4/Zend/zend_compile.c
U php/php-src/trunk/Zend/zend_compile.c
Modified:
gron Sat, 05 Nov 2011 02:05:28 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=318794
Log:
Fixed inconsistent whitespace.
# Belongs to svn rev. 318793.
Changed paths:
U php/php-src/branches/PHP_5_4/Zend/zend_compile.c
U
tony2001 Thu, 03 Nov 2011 08:39:12 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=318723
Log:
use jmp_addr only when it's initialized
Changed paths:
U php/php-src/branches/PHP_5_4/Zend/zend_compile.c
U
Hi Antony:
On 02 Nov 2011, at 22:05, Antony Dovgal wrote:
tony2001 Wed, 02 Nov 2011 21:05:36 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=318705
Log:
initialize variable and fix segfaulting tests
Thanks for catching this one and the one
On 11/03/2011 01:21 PM, Stefan Marr wrote:
Hi Antony:
On 02 Nov 2011, at 22:05, Antony Dovgal wrote:
tony2001 Wed, 02 Nov 2011 21:05:36 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=318705
Log:
initialize variable and fix segfaulting
tony2001 Wed, 02 Nov 2011 21:05:36 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=318705
Log:
initialize variable and fix segfaulting tests
Changed paths:
U php/php-src/branches/PHP_5_4/Zend/zend_compile.c
U
tony2001 Wed, 02 Nov 2011 21:12:13 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=318706
Log:
fix folding, ws and cs
Changed paths:
U php/php-src/branches/PHP_5_4/Zend/zend_compile.c
U php/php-src/trunk/Zend/zend_compile.c
Modified:
gron Sat, 08 Oct 2011 23:47:16 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=317930
Log:
Use ZEND_ constants instead of plain strings for names of magic methods.
# No functional changes.
Changed paths:
U
laruence Fri, 07 Oct 2011 04:14:31 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=317849
Log:
Remove unecessary codes
Changed paths:
U php/php-src/branches/PHP_5_4/Zend/zend_compile.c
U php/php-src/trunk/Zend/zend_compile.c
Modified:
derick Tue, 13 Sep 2011 15:17:11 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=316654
Log:
- Fixed compiler warnings (patch by Kalle Sommer Nielsen)
Changed paths:
U php/php-src/branches/PHP_5_4/Zend/zend_compile.c
U
On Tue, 2011-08-16 at 12:37 -0700, Stas Malyshev wrote:
Hi!
On 8/16/11 6:19 AM, Johannes Schlüter wrote:
It saves one character of typing.
For me, it's the reason enough to prohibit it altogether :) Writing
weird code to save one character of typing is the worst habit we could
bjoriTue, 16 Aug 2011 10:46:49 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=315002
Log:
Improve errormessage on wrong use statements
Changed paths:
U php/php-src/branches/PHP_5_4/Zend/zend_compile.c
U
Hi Hannes:
On 16 Aug 2011, at 12:46, Hannes Magnusson wrote:
+ if (!strcmp(Z_STRVAL_P(name), strict)) {
+ zend_error(E_COMPILE_ERROR, You seem to be trying to
use a different language...);
+ }
Could we change that error to be a bit more explicit
On Tue, Aug 16, 2011 at 13:05, Stefan Marr p...@stefan-marr.de wrote:
Hi Hannes:
On 16 Aug 2011, at 12:46, Hannes Magnusson wrote:
+ if (!strcmp(Z_STRVAL_P(name), strict)) {
+ zend_error(E_COMPILE_ERROR, You seem to be trying to
use a different language...);
On 16 Aug 2011, at 13:23, Hannes Magnusson wrote:
On Tue, Aug 16, 2011 at 13:05, Stefan Marr p...@stefan-marr.de wrote:
Hi Hannes:
On 16 Aug 2011, at 12:46, Hannes Magnusson wrote:
+ if (!strcmp(Z_STRVAL_P(name), strict)) {
+ zend_error(E_COMPILE_ERROR,
On Tue, Aug 16, 2011 at 13:39, Stefan Marr p...@stefan-marr.de wrote:
On 16 Aug 2011, at 13:23, Hannes Magnusson wrote:
On Tue, Aug 16, 2011 at 13:05, Stefan Marr p...@stefan-marr.de wrote:
Hi Hannes:
On 16 Aug 2011, at 12:46, Hannes Magnusson wrote:
+ if
On Tue, 2011-08-16 at 13:44 +0200, Hannes Magnusson wrote:
use foobar; has no effect, at all, and you will get an warning
message telling you that.
It has an effect. In
namespace strict { class C {} }
namespace foo { use strict; new strict\C; }
It saves one character of typing. Without the
2011/8/16 Johannes Schlüter johan...@schlueters.de:
On Tue, 2011-08-16 at 13:44 +0200, Hannes Magnusson wrote:
use foobar; has no effect, at all, and you will get an warning
message telling you that.
It has an effect. In
namespace strict { class C {} }
namespace foo { use strict; new
Hi!
On 8/16/11 6:19 AM, Johannes Schlüter wrote:
It saves one character of typing.
For me, it's the reason enough to prohibit it altogether :) Writing
weird code to save one character of typing is the worst habit we could
promote. But I digress since the idea of this patch was obviously not
gron Mon, 15 Aug 2011 08:29:48 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=314921
Log:
Addendum for patch to bug #55214: Class name was freed before method literal
referring to it.
# Thanks to Felipe for catching this.
# The fix duplicates
felipe Sun, 31 Jul 2011 12:27:47 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=313991
Log:
- Fixed bug #55326 (Trait method copying misindentifies serialization callbacks)
patch by: Gustavo Lopes (cataphract@php)
Bug:
gron Sat, 23 Jul 2011 18:12:31 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=313638
Log:
Fixed incorrect initialization when copied op_array.vars was NULL (TRAITS)
Changed paths:
U php/php-src/branches/PHP_5_4/Zend/zend_compile.c
U
dmitry Mon, 11 Jul 2011 07:10:30 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=313125
Log:
Fixed bug #55150 (php -a segfaults)
Bug: https://bugs.php.net/55150 (Assigned) php -a segfaults
Changed paths:
U
felipe Fri, 08 Jul 2011 19:52:21 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=313078
Log:
- CS and WS
Changed paths:
U php/php-src/branches/PHP_5_4/Zend/zend_compile.c
U php/php-src/trunk/Zend/zend_compile.c
Modified:
felipe Sun, 19 Jun 2011 20:16:08 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=312303
Log:
- Removed unnecessary TSRMLS_FETCH
Changed paths:
U php/php-src/branches/PHP_5_4/Zend/zend_compile.c
U php/php-src/trunk/Zend/zend_compile.c
felipe Mon, 20 Jun 2011 01:21:47 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=312320
Log:
- Avoid re-hash here too
Changed paths:
U php/php-src/branches/PHP_5_4/Zend/zend_compile.c
U php/php-src/trunk/Zend/zend_compile.c
felipe Mon, 20 Jun 2011 01:36:23 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=312321
Log:
- Simplify function code
Changed paths:
U php/php-src/branches/PHP_5_4/Zend/zend_compile.c
U php/php-src/trunk/Zend/zend_compile.c
felipe Mon, 20 Jun 2011 02:04:13 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=312322
Log:
- Optimize property finding by zend_hash_quick_find
Changed paths:
U php/php-src/branches/PHP_5_4/Zend/zend_compile.c
U
pajoye Tue, 17 May 2011 10:39:18 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=311123
Log:
- WS
Changed paths:
U php/php-src/branches/PHP_5_4/Zend/zend_compile.c
U php/php-src/trunk/Zend/zend_compile.c
Modified:
40 matches
Mail list logo
