[PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c tests/bug60749.phpt tests/ipv6.phpt

2012-01-13 Thread Boris Lytochkin
lytboris Fri, 13 Jan 2012 18:34:21 + Revision: http://svn.php.net/viewvc?view=revision&revision=322213 Log: Fixed bug #60585 (php build fails with USE flag snmp when IPv6 support is disabled) Fixed bug #60749 (SNMP module should not strip non-standard SNMP por

[PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-09-02 Thread Boris Lytochkin
lytboris Fri, 02 Sep 2011 10:07:01 + Revision: http://svn.php.net/viewvc?view=revision&revision=316031 Log: remove extra white space Changed paths: U php/php-src/trunk/ext/snmp/snmp.c Modified: php/php-src/trunk/ext/snmp/snmp.c =

[PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-08-31 Thread Boris Lytochkin
lytboris Wed, 31 Aug 2011 20:15:32 + Revision: http://svn.php.net/viewvc?view=revision&revision=315924 Log: tune text align Changed paths: U php/php-src/trunk/ext/snmp/snmp.c Modified: php/php-src/trunk/ext/snmp/snmp.c ==

[PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c tests/snmp-object.phpt tests/snmp3-error.phpt

2011-08-31 Thread Boris Lytochkin
lytboris Wed, 31 Aug 2011 08:28:13 + Revision: http://svn.php.net/viewvc?view=revision&revision=315862 Log: more tuning based on discussion in FR #40816: * parse all OIDs earlier, detect all wrong OIDs before any query is made (GET-operations) * introduce

[PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c tests/snmp2_get.phpt tests/snmpget.phpt

2011-08-27 Thread Boris Lytochkin
lytboris Sat, 27 Aug 2011 07:24:44 + Revision: http://svn.php.net/viewvc?view=revision&revision=315606 Log: reformat OID parsing procedure, fail whole SNMP query on single OID parsing failure Changed paths: U php/php-src/trunk/ext/snmp/snmp.c U php

[PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c tests/README tests/ipv6.phpt tests/snmp_include.inc tests/wrong_hostname.phpt

2011-08-20 Thread Boris Lytochkin
lytboris Sat, 20 Aug 2011 15:53:44 + Revision: http://svn.php.net/viewvc?view=revision&revision=315236 Log: Adding IPv6 support (FR #42918) Bug: https://bugs.php.net/42918 (Assigned) IPv6 addresses not supported in SNMP extension Changed paths: U

[PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-07-23 Thread Boris Lytochkin
lytboris Sat, 23 Jul 2011 07:40:40 + Revision: http://svn.php.net/viewvc?view=revision&revision=313620 Log: provide backwards compatibility for 'p' in zend_parse_parameters() Changed paths: U php/php-src/trunk/ext/snmp/snmp.c Modified: php/php-src/trunk

[PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c tests/snmp-object-error.phpt tests/snmp-object.phpt

2011-07-17 Thread Boris Lytochkin
lytboris Sun, 17 Jul 2011 18:17:43 + Revision: http://svn.php.net/viewvc?view=revision&revision=313338 Log: swap non_repeaters and max_repetitions in walk query, max_repetitions whould be used more frequently Changed paths: _U php/php-src/trunk/ext/snmp/

[PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-07-17 Thread Boris Lytochkin
lytboris Sun, 17 Jul 2011 13:57:28 + Revision: http://svn.php.net/viewvc?view=revision&revision=313324 Log: update ARG_INFO_EX for walk and get methods, fix comments Changed paths: U php/php-src/trunk/ext/snmp/snmp.c Modified: php/php-src/trunk/ext/snmp

[PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c tests/snmp-object-errno-errstr.phpt tests/snmp-object-error.phpt tests/snmp-object-properties.phpt tests/snmp-object-setSecurity_error.phpt tests/snm

2011-06-12 Thread Boris Lytochkin
lytboris Sun, 12 Jun 2011 11:58:49 + Revision: http://svn.php.net/viewvc?view=revision&revision=312092 Log: move SNMP VERSION constants into SNMP class itself Changed paths: U php/php-src/trunk/ext/snmp/snmp.c U php/php-src/trunk/ext/snmp/tests/snm

[PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-06-12 Thread Boris Lytochkin
lytboris Sun, 12 Jun 2011 11:25:20 + Revision: http://svn.php.net/viewvc?view=revision&revision=312090 Log: fix typo in comment Changed paths: U php/php-src/trunk/ext/snmp/snmp.c Modified: php/php-src/trunk/ext/snmp/snmp.c ==

[PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c tests/snmp-object-errno-errstr.phpt

2011-05-10 Thread Boris Lytochkin
lytboris Tue, 10 May 2011 11:48:10 + Revision: http://svn.php.net/viewvc?view=revision&revision=310887 Log: method renaming: SNMP::get_errno() -> SNMP::getErrno() SNMP::get_error() -> SNMP::getError() Changed paths: U php/php-src/trunk/ext/snmp/snmp.c

[PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-05-09 Thread Boris Lytochkin
lytboris Mon, 09 May 2011 19:34:07 + Revision: http://svn.php.net/viewvc?view=revision&revision=310861 Log: remove method open, __construct is enough Changed paths: U php/php-src/trunk/ext/snmp/snmp.c Modified: php/php-src/trunk/ext/snmp/snmp.c

[PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-05-08 Thread Boris Lytochkin
lytboris Sun, 08 May 2011 09:20:58 + Revision: http://svn.php.net/viewvc?view=revision&revision=310836 Log: fix error reporting on OID not increasing calling arguments markup Changed paths: U php/php-src/trunk/ext/snmp/snmp.c Modified: php/php-src/trunk

[PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-03-19 Thread Boris Lytochkin
lytboris Sat, 19 Mar 2011 20:50:39 + Revision: http://svn.php.net/viewvc?view=revision&revision=309453 Log: revert r309111 (name_len was not a typo) Changed paths: U php/php-src/trunk/ext/snmp/snmp.c Modified: php/php-src/trunk/ext/snmp/snmp.c =

[PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-03-10 Thread Boris Lytochkin
lytboris Fri, 11 Mar 2011 07:21:13 + Revision: http://svn.php.net/viewvc?view=revision&revision=309111 Log: fix typo in SNMP_SNPRINT_VALUE usage: use val_len, not name_length Changed paths: U php/php-src/trunk/ext/snmp/snmp.c Modified: php/php-src/trunk

[PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c tests/snmp2_walk.phpt

2011-03-04 Thread Boris Lytochkin
lytboris Fri, 04 Mar 2011 19:23:25 + Revision: http://svn.php.net/viewvc?view=revision&revision=308932 Log: * tune snmp2_walk.phpt * more net-snmp v5.3 compatibility (OPAQUE_SPECIAL_TYPES) Changed paths: U php/php-src/trunk/ext/snmp/snmp.c U php/ph

[PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-03-02 Thread Boris Lytochkin
lytboris Wed, 02 Mar 2011 22:12:02 + Revision: http://svn.php.net/viewvc?view=revision&revision=308875 Log: fix warnings mentioned in 'Parameter Parsing Report' Changed paths: U php/php-src/trunk/ext/snmp/snmp.c Modified: php/php-src/trunk/ext/snmp/snmp

Re: [PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-02-26 Thread Lytochkin Boris
Sure, #54108 On Sat, Feb 26, 2011 at 11:33 PM, Pierre Joye wrote: > can you open a bug at bugs.php.net with the patch please? > > -- > Pierre > > @pierrejoye | http://blog.thepimp.net | http://www.libgd.org > -- Boris Lytochkin -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, vi

Re: [PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-02-26 Thread Pierre Joye
can you open a bug at bugs.php.net with the patch please? Thanks! On Sat, Feb 26, 2011 at 9:31 PM, Lytochkin Boris wrote: > It is a pain to run it on FreeBSD, there is a bug in run-tests.php: > === > --- run-tests.php       (revision 308673) > +++ run-tests.php       (working copy) >

Re: [PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-02-26 Thread Antony Dovgal
- RETURN_FALSE; + RETVAL_FALSE; + return; What's the point? #define RETURN_FALSE{ RETVAL_FALSE; return; } On 02/26/2011 10:08 PM, Boris Lytochkin wrote: > lytboris Sat, 26 Feb 201

Re: [PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-02-26 Thread Lytochkin Boris
It is a pain to run it on FreeBSD, there is a bug in run-tests.php: === --- run-tests.php (revision 308673) +++ run-tests.php (working copy) @@ -567,7 +567,7 @@ case 'm': $leak_check = true;

Re: [PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-02-26 Thread Lytochkin Boris
Just to indicate that this is not php function return and some other processing (in caller function) follows. On Sat, Feb 26, 2011 at 11:30 PM, Antony Dovgal wrote: > -                       RETURN_FALSE; > +                       RETVAL_FALSE; > +                       return; > > What's the poi

Re: [PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-02-26 Thread Pierre Joye
btw, you can use valgrind as well with the tests suite. That should help you to catch other possible leaks or bad memory access. On Sat, Feb 26, 2011 at 8:08 PM, Boris Lytochkin wrote: > lytboris                                 Sat, 26 Feb 2011 19:08:55 + > > Revision: http://svn.php.net/view

[PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-02-26 Thread Boris Lytochkin
lytboris Sat, 26 Feb 2011 19:08:55 + Revision: http://svn.php.net/viewvc?view=revision&revision=308710 Log: remove compiler warnings fix various memory leaks seen with --enable-debug Changed paths: U php/php-src/trunk/ext/snmp/snmp.c Modified: php/php-s

[PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-02-25 Thread Boris Lytochkin
lytboris Fri, 25 Feb 2011 19:22:15 + Revision: http://svn.php.net/viewvc?view=revision&revision=308682 Log: fix parse errors for non_repeaters & max_repetitions: aligment errors Changed paths: U php/php-src/trunk/ext/snmp/snmp.c Modified: php/php-src/tr

[PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-02-19 Thread Boris Lytochkin
lytboris Sat, 19 Feb 2011 11:13:10 + Revision: http://svn.php.net/viewvc?view=revision&revision=308479 Log: push most of SNMP query options into objid_query structure Changed paths: U php/php-src/trunk/ext/snmp/snmp.c Modified: php/php-src/trunk/ext/snm

[PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-02-17 Thread Boris Lytochkin
lytboris Thu, 17 Feb 2011 12:12:22 + Revision: http://svn.php.net/viewvc?view=revision&revision=308429 Log: enable HAVE_SHUTDOWN_SNMP_LOGGING Changed paths: U php/php-src/trunk/ext/snmp/snmp.c Modified: php/php-src/trunk/ext/snmp/snmp.c

[PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-02-14 Thread Felipe Pena
felipe Tue, 15 Feb 2011 00:07:26 + Revision: http://svn.php.net/viewvc?view=revision&revision=308346 Log: - Fixed crash on unserialize(serialize(new SNMP)) Changed paths: U php/php-src/trunk/ext/snmp/snmp.c Modified: php/php-src/trunk/ext/snmp/snmp.c

[PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-02-14 Thread Felipe Pena
felipe Mon, 14 Feb 2011 23:58:52 + Revision: http://svn.php.net/viewvc?view=revision&revision=308345 Log: - Fixed memory leak on serialize(new SNMP) Changed paths: U php/php-src/trunk/ext/snmp/snmp.c Modified: php/php-src/trunk/ext/snmp/snmp.c ===

[PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-02-14 Thread Felipe Pena
felipe Mon, 14 Feb 2011 23:43:22 + Revision: http://svn.php.net/viewvc?view=revision&revision=308344 Log: - Fixed memory leak Changed paths: U php/php-src/trunk/ext/snmp/snmp.c Modified: php/php-src/trunk/ext/snmp/snmp.c ==

[PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-02-05 Thread Boris Lytochkin
lytboris Sat, 05 Feb 2011 13:22:38 + Revision: http://svn.php.net/viewvc?view=revision&revision=308046 Log: fix crash caused by incorrect offset altering Changed paths: U php/php-src/trunk/ext/snmp/snmp.c Modified: php/php-src/trunk/ext/snmp/snmp.c

[PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c tests/snmp-object-properties.phpt

2011-02-04 Thread Boris Lytochkin
lytboris Sat, 05 Feb 2011 00:29:31 + Revision: http://svn.php.net/viewvc?view=revision&revision=308037 Log: added r/o info property with basic session info, fix crash in _get_properties in trunk Changed paths: U php/php-src/trunk/ext/snmp/snmp.c U

[PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-02-01 Thread Pierre Joye
pajoye Tue, 01 Feb 2011 13:57:06 + Revision: http://svn.php.net/viewvc?view=revision&revision=307914 Log: - fix build, wrong version id Changed paths: U php/php-src/trunk/ext/snmp/snmp.c Modified: php/php-src/trunk/ext/snmp/snmp.c

Re: [PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-02-01 Thread Pierre Joye
yes, but this branch is trunk and is not supposed to be 5.2 compatible. If you want to get it out with previous versions support, then go through pecl as well. But without such external releases it will just clutter the codes. Cheers, On Tue, Feb 1, 2011 at 9:51 AM, Lytochkin Boris wrote: > Hi.

Re: [PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-02-01 Thread Lytochkin Boris
Hi. I use this module in my production Cacti environment, which uses 5.2 branch. As I use FreeBSD, I'm able to build snmp extension separately from base php as .so module and I use this possibility :) As long as Cacti would need 5.2 to run I will mantain those ugly checks (I believe this legacy w

Re: [PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-02-01 Thread Pierre Joye
hi, I wonder why you need that as we don't release snmp outside php. I would suggest to either drop these backward compatible checks (cleaner code) or consider to do release through pecl as well and then these checks make sense. Cheers, On Tue, Feb 1, 2011 at 9:20 AM, Boris Lytochkin wrote: > l

[PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-02-01 Thread Boris Lytochkin
lytboris Tue, 01 Feb 2011 08:20:13 + Revision: http://svn.php.net/viewvc?view=revision&revision=307898 Log: preprocessed changes made in rev.307894: keeping ext/snmp backwards compatible Changed paths: U php/php-src/trunk/ext/snmp/snmp.c Modified: php/p

[PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-01-31 Thread Felipe Pena
felipe Tue, 01 Feb 2011 01:02:00 + Revision: http://svn.php.net/viewvc?view=revision&revision=307894 Log: - Fixed build Changed paths: U php/php-src/trunk/ext/snmp/snmp.c Modified: php/php-src/trunk/ext/snmp/snmp.c