Re: [PHP-CVS] cvs: php-src(PHP_4_3) /ext/session session.c

2004-09-04 Thread Masaki Fujimoto
Hello, this seems rather old commit anyway, may I ask why this is not merged into php-5 trees? I think without this, some scripts will misbehave in php 5. for instance: (php.ini) ...snip... session.use_cookies = 1 session.cookie_lifetime = 0 ...snip... (foo.php) if (!empty($_COOKIE[$session_na

Re: [PHP-CVS] cvs: php-src(PHP_4_3) /ext/session session.c

2003-12-08 Thread Jani Taskinen
Oops? :) (thanks for fixing it) --Jani On Mon, 8 Dec 2003, Ard Biesheuvel wrote: >abies Mon Dec 8 05:01:12 2003 EDT > > Modified files: (Branch: PHP_4_3) >/php-src/ext/session session.c > Log: > Fix build > > >Index: php-s

Re: [PHP-CVS] cvs: php-src(PHP_4_3) /ext/session session.c

2003-07-22 Thread Zeev Suraski
At 14:56 22/07/2003, Sascha Schumann wrote: > Can you give me a concrete example of when you think this macro doesn't > behave properly? If it's correct, I'll try to fix it. Note that the last > time you had problems with this (and other) macros these were actually bugs > in the session module.

Re: [PHP-CVS] cvs: php-src(PHP_4_3) /ext/session session.c

2003-07-22 Thread Sascha Schumann
> Can you give me a concrete example of when you think this macro doesn't > behave properly? If it's correct, I'll try to fix it. Note that the last > time you had problems with this (and other) macros these were actually bugs > in the session module. That was another instance showing the in

Re: [PHP-CVS] cvs: php-src(PHP_4_3) /ext/session session.c

2003-07-22 Thread Zeev Suraski
At 13:49 22/07/2003, Sascha Schumann wrote: On Tue, 22 Jul 2003, Zeev Suraski wrote: > At 12:22 22/07/2003, Sascha Schumann wrote: > > If it is not irregular, the engine code should be able to > > deal with it correctly. Right now, it falls over itself > > quickly and dies ungracefull

Re: [PHP-CVS] cvs: php-src(PHP_4_3) /ext/session session.c

2003-07-22 Thread Zeev Suraski
At 13:46 22/07/2003, Sascha Schumann wrote: On Tue, 22 Jul 2003, Zeev Suraski wrote: > At 12:22 22/07/2003, Sascha Schumann wrote: > > If it is not irregular, the engine code should be able to > > deal with it correctly. Right now, it falls over itself > > quickly and dies ungracefull

Re: [PHP-CVS] cvs: php-src(PHP_4_3) /ext/session session.c

2003-07-22 Thread Sascha Schumann
On Tue, 22 Jul 2003, Zeev Suraski wrote: > At 12:22 22/07/2003, Sascha Schumann wrote: > > If it is not irregular, the engine code should be able to > > deal with it correctly. Right now, it falls over itself > > quickly and dies ungracefully. > > Then ZEND_SET_SYMBOL_WITH_LENGTH shou

Re: [PHP-CVS] cvs: php-src(PHP_4_3) /ext/session session.c

2003-07-22 Thread Sascha Schumann
On Tue, 22 Jul 2003, Zeev Suraski wrote: > At 12:22 22/07/2003, Sascha Schumann wrote: > > If it is not irregular, the engine code should be able to > > deal with it correctly. Right now, it falls over itself > > quickly and dies ungracefully. > > Then ZEND_SET_SYMBOL_WITH_LENGTH shou

Re: [PHP-CVS] cvs: php-src(PHP_4_3) /ext/session session.c

2003-07-22 Thread Zeev Suraski
At 12:22 22/07/2003, Sascha Schumann wrote: If it is not irregular, the engine code should be able to deal with it correctly. Right now, it falls over itself quickly and dies ungracefully. Then ZEND_SET_SYMBOL_WITH_LENGTH should be fixed. I'm not sure who wrote it, but it wasn't Andi

Re: [PHP-CVS] cvs: php-src(PHP_4_3) /ext/session session.c

2003-07-22 Thread Sascha Schumann
On Tue, 22 Jul 2003, Zeev Suraski wrote: > At 04:10 22/07/2003, Sascha Schumann wrote: > >sas Mon Jul 21 21:10:31 2003 EDT > > > > Modified files: (Branch: PHP_4_3) > > /php-src/ext/sessionsession.c > > Log: > > Proper fix for #24592 > > > > The core is

Re: [PHP-CVS] cvs: php-src(PHP_4_3) /ext/session session.c

2003-07-22 Thread Zeev Suraski
At 04:10 22/07/2003, Sascha Schumann wrote: sas Mon Jul 21 21:10:31 2003 EDT Modified files: (Branch: PHP_4_3) /php-src/ext/sessionsession.c Log: Proper fix for #24592 The core issue is that undefined variables are refcounted (refcount != 0) while is_