[PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard string.c

2008-08-06 Thread Derick Rethans
On Tue, 5 Aug 2008, Olivier Hill wrote: > What should be MFH'ed? > > I haven't touched HEAD with this. I don't have cvs access here, will > only be able to commit friday. > > Is there still regression issues or my last patch fixed it? Looks fine - I missed your patch on the list though. regard

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard string.c

2008-08-05 Thread Olivier Hill
What should be MFH'ed? I haven't touched HEAD with this. I don't have cvs access here, will only be able to commit friday. Is there still regression issues or my last patch fixed it? Thanks Olivier (Mobile) On 8/5/08, Lukas Kahwe Smith <[EMAIL PROTECTED]> wrote: > > On 31.07.2008, at 09:18, D

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard string.c

2008-08-05 Thread Lukas Kahwe Smith
On 31.07.2008, at 09:18, Derick Rethans wrote: On Mon, 28 Jul 2008, Olivier Hill wrote: Indeed, I forgot to test that case. If I remember correctly, there was no test cases for that function, so I'll fix this tonight and add some tests. I didn't see a commit - have you forgotten about i

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard string.c

2008-07-31 Thread Derick Rethans
On Mon, 28 Jul 2008, Olivier Hill wrote: > Indeed, I forgot to test that case. If I remember correctly, there was > no test cases for that function, so I'll fix this tonight and add some > tests. I didn't see a commit - have you forgotten about it? regards, Derick -- HEAD before 5_3!: http://t

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard string.c

2008-07-28 Thread Olivier Hill
Indeed, I forgot to test that case. If I remember correctly, there was no test cases for that function, so I'll fix this tonight and add some tests. Regards On 7/28/08, Derick Rethans <[EMAIL PROTECTED]> wrote: > On Wed, 25 Jun 2008, Olivier Hill wrote: > >> ohillWed Jun 25 12:1

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard string.c

2008-07-28 Thread Derick Rethans
On Wed, 25 Jun 2008, Olivier Hill wrote: > ohill Wed Jun 25 12:16:17 2008 UTC > > Modified files: (Branch: PHP_5_3) > /php-src/ext/standard string.c > Log: > New parameter parsing API The following change introduces a regression: @@ -4135,24 +4095,23 @@

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard string.c

2008-06-30 Thread Antony Dovgal
On 30.06.2008 14:39, Antony Dovgal wrote: tony2001Mon Jun 30 10:39:35 2008 UTC Added files: (Branch: PHP_5_3) /pecl/sdo/SCA/Bindings/atom Atom1.0.xsd xhtml1-strict.xsd ServiceRequestHandler.php Proxy.php

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard string.c

2008-01-25 Thread Hannes Magnusson
On Jan 25, 2008 2:31 AM, Ilia Alshanetsky <[EMAIL PROTECTED]> wrote: > iliaa Fri Jan 25 01:31:11 2008 UTC > > Modified files: (Branch: PHP_5_3) > /php-src/ext/standard string.c > Log: > > Adjust new chr() param handling to address chr("") calls > > http://cvs.

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard string.c

2008-01-25 Thread Antony Dovgal
Ilia, the tests are still broken. On 25.01.2008 04:31, Ilia Alshanetsky wrote: > iliaa Fri Jan 25 01:31:11 2008 UTC > > Modified files: (Branch: PHP_5_3) > /php-src/ext/standard string.c > Log: > > Adjust new chr() param handling to address chr("") calls >

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard string.c

2008-01-24 Thread Dmitry Stogov
Hi Ilia, This patch was committed into PHP_5_3 only, and it breaks two tests. Could you please revert it or fix test files and commit to HEAD. ext/standard/tests/array/array_filter_variation9.phpt ext/standard/tests/strings/chr_ord.phpt Thanks. Dmitry. Ilia Alshanetsky wrote: iliaa