Re: [PHP-CVS] cvs: php-src /ext/pdo_mysql mysql_statement.c

2005-07-14 Thread Wez Furlong
Then explain why half the test cases fail silently with the code as it was, and why all tests pass and run perfectly now? --Wez. Andrey Hristov wrote: Hi Wez, I do never commit code which makes test case fail. Here not tests failed therefore I did commit the code. In addition, (my_ulonglong)

Re: [PHP-CVS] cvs: php-src /ext/pdo_mysql mysql_statement.c

2005-07-14 Thread Andrey Hristov
Hi Wez, I do never commit code which makes test case fail. Here not tests failed therefore I did commit the code. In addition, (my_ulonglong) -1 is not 0. The first value is returned from mysql_stmt_affected_rows() and mysql_affected_rows() to indicate a failure. Both functions return unsigned lo

Re: [PHP-CVS] cvs: php-src /ext/pdo_mysql mysql_statement.c

2005-07-13 Thread Andi Gutmans
Is this a build error in Beta 3? Was just about to post it... Andi At 02:20 AM 7/14/2005 +, Wez Furlong wrote: wez Wed Jul 13 22:20:52 2005 EDT Modified files: /php-src/ext/pdo_mysql mysql_statement.c Log: gah! http://cvs.php.net/diff.php/php-src/ext/pdo_mysql/

Re: [PHP-CVS] cvs: php-src /ext/pdo_mysql mysql_statement.c

2005-07-09 Thread Andrey Hristov
Wez Furlong wrote: wez Sat Jul 9 22:00:38 2005 EDT Modified files: /php-src/ext/pdo_mysql mysql_statement.c Log: Get precise lengths from the server, as suggested by Andrey. Wez, I don't think this patch fixes the problem because mysql_stmt_result_meta