Uncommon is totally irrelevant. Stable, robust code is what is. What
is this - the "Cross your fingers and hope it works programming language"??
Nah, it's more along the lines of "works for me" :-)
Ilia
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/u
It is malloc + PQescapeString + free, which in most cases are completely
unnecessary. While as Christopher demonstrates sequence name could
contain special chars, I'd wager that is a VERY uncommon situation.
Uncommon is totally irrelevant. Stable, robust code is what is. What
is this - the "
Oh, that's a different story then...
At 01:54 PM 7/7/2005 +0800, Christopher Kings-Lynne wrote:
It does impose a v7.4 and above libpq requirement, however.
Chris
Andi Gutmans wrote:
Yeah, definitely seems like PQexecParams is the safest and easiest way of
doing so.
In general, I'm always in f
How about using a stack variable for this temporary allocation?
On 7/7/05, Ilia Alshanetsky <[EMAIL PROTECTED]> wrote:
> Edink,
>
> It is malloc + PQescapeString + free, which in most cases are completely
> unnecessary. While as Christopher demonstrates sequence name could
> contain special chars
Edink,
It is malloc + PQescapeString + free, which in most cases are completely
unnecessary. While as Christopher demonstrates sequence name could
contain special chars, I'd wager that is a VERY uncommon situation.
Ilia
Edin Kadribasic wrote:
Hi Ilia,
Would you please revert this change?
Hi Ilia,
Would you please revert this change?
Saving one malloc/free in a function that has to query DB server anyway is not
going to give you much performance improvement, while other methods are not
portable across different PostgreSQL versions.
Edin
On Thursday 07 July 2005 02:52, Ilia Als
It does impose a v7.4 and above libpq requirement, however.
Chris
Andi Gutmans wrote:
Yeah, definitely seems like PQexecParams is the safest and easiest way
of doing so.
In general, I'm always in favor of using bound parameters exactly for
this reason.
Andi
At 10:44 AM 7/7/2005 +0800, Chris
Yeah, definitely seems like PQexecParams is the safest and easiest way of
doing so.
In general, I'm always in favor of using bound parameters exactly for this
reason.
Andi
At 10:44 AM 7/7/2005 +0800, Christopher Kings-Lynne wrote:
By the way, using PQexecParams is by far the easiest fastest an
Have you ever tried creating a sequence with an apostrophes in its name
in PostgreSQL?
Easily, and don't forget about schema qualification either:
test=# create sequence "isn't this ""grand""?";
CREATE SEQUENCE
test=# \ds
List of relations
Schema |Name | Type
I don't get this at all? How come you reject sequences that contain
apostrophes?
Chris
Ilia Alshanetsky wrote:
iliaa Wed Jul 6 20:52:20 2005 EDT
Modified files:
/php-src/ext/pdo_pgsql pgsql_driver.c
Log:
Faster sequence id retrieval.
http://cvs.p
By the way, using PQexecParams is by far the easiest fastest and safest
way of doing this...
Chris
Ilia Alshanetsky wrote:
iliaa Wed Jul 6 22:17:21 2005 EDT
Modified files:
/php-src/ext/pdo_pgsql pgsql_driver.c
Log:
Leave it up to the user to decide if to
Leave it up to the user to decide if to escape the sequence name or not.
What was wrong with the original coding? Can't you juse leave teh
PQescapeString in there?
Chris
http://cvs.php.net/diff.php/php-src/ext/pdo_pgsql/pgsql_driver.c?r1=1.47&r2=1.48&ty=u
Index: php-src/ext/pdo_pgsql/pgs
Thanks for the suggestion, I'll look into it tomorrow morning.
Ilia
Christopher Kings-Lynne wrote:
By the way, using PQexecParams is by far the easiest fastest and safest
way of doing this...
Chris
Ilia Alshanetsky wrote:
iliaaWed Jul 6 22:17:21 2005 EDT
Modified files:
Christopher Kings-Lynne wrote:
I don't get this at all? How come you reject sequences that contain
apostrophes?
Have you ever tried creating a sequence with an apostrophes in its name
in PostgreSQL?
Ilia
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.ne
Nope, 32 bit value not a 64 bit one.
ilia
Wez Furlong wrote:
Is this what you're really looking for?
PDO_API char *php_pdo_int64_to_str(pdo_int64_t i64 TSRMLS_DC)
--Wez.
On 6/29/05, Ilia Alshanetsky <[EMAIL PROTECTED]> wrote:
iliaa Wed Jun 29 20:07:44 2005 EDT
Modified files:
Is this what you're really looking for?
PDO_API char *php_pdo_int64_to_str(pdo_int64_t i64 TSRMLS_DC)
--Wez.
On 6/29/05, Ilia Alshanetsky <[EMAIL PROTECTED]> wrote:
> iliaa Wed Jun 29 20:07:44 2005 EDT
>
> Modified files:
> /php-src/ext/pdo_pgsql pgsql_driver.c
> Log:
>
16 matches
Mail list logo
