Re: [PHP-CVS] cvs: php-src /ext/standard formatted_print.c

2007-06-03 Thread Brian Shire
Yep, I think tests/strings/printf_64bit.phpt should actually cover this one though (once I commit the changes to fix these tests I broke). Let me know if you need any more specific tests though, basically printf("%u", -1) is now 18446744073709551615 rather than 4294967295 on 64-bit. O

Re: [PHP-CVS] cvs: php-src /ext/standard formatted_print.c

2007-06-03 Thread Ilia Alshanetsky
Brian, Can you please add a test case. Thanks, Ilia -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src /ext/standard formatted_print.c

2007-01-17 Thread Antony Dovgal
Just a grammar nit-pick, but in those new error messages, "then" should be "than." :-) Fixed, thanks. Also, just noticed the period at the end of the messages, which the vast majority of messages elsewhere don't have, so seems like they should be removed. (I sent a patch a few months ago to

Re: [PHP-CVS] cvs: php-src /ext/standard formatted_print.c

2007-01-16 Thread Matt Wilmas
Hi Ilia, - Original Message - From: "Ilia Alshanetsky" Sent: Saturday, January 13, 2007 > iliaa Sat Jan 13 16:32:29 2007 UTC > > Modified files: > /php-src/ext/standard formatted_print.c > Log: > > MFB: Improve validation of argnum, width and precision. > [.

[PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/standard formatted_print.c /ext/standard/tests/serialize 003.phpt /ext/standard/tests/strings sprintf_f.phpt /main snprintf.c snprintf.h sppr

2006-12-06 Thread Antony Dovgal
On 12/06/2006 05:18 PM, Matt Wilmas wrote: Hi Antony, The changes to formatted_print.c caught my eye because I was going to inquire about/resubmit a patch from August to add new features the the *printf() functions... :-) I see you've added g/G (and E). In appenddouble, however, I noticed that

Re: [PHP-CVS] cvs: php-src /ext/standard formatted_print.c /ext/standard/tests/serialize 003.phpt /ext/standard/tests/strings sprintf_f.phpt /main snprintf.c snprintf.h spprintf.c ZendEngine2 zend

2006-12-06 Thread Matt Wilmas
Hi Antony, The changes to formatted_print.c caught my eye because I was going to inquire about/resubmit a patch from August to add new features the the *printf() functions... :-) I see you've added g/G (and E). In appenddouble, however, I noticed that the F specifier is missing. Nothing to me p