On Monday 24 November 2008 20:31:02 Arnaud Le Blanc wrote:
> lbarnaud Mon Nov 24 19:31:02 2008 UTC
>
> Modified files:
> /php-src/ext/standard string.c
> Log:
Log message should have been:
Fix invalid read in strtr().
>
>
> http://cvs.php.net/viewvc.
Em Sáb, 2008-11-22 às 00:29 +0200, Jani Taskinen escreveu:
> You should always mention when closing bug reports that the bug is fixed in
> only
> some branch, especially this close to a release from branch that the fix was
> NOT
> included in. (I added the note for you, this is just a reminder
You should always mention when closing bug reports that the bug is fixed in only
some branch, especially this close to a release from branch that the fix was NOT
included in. (I added the note for you, this is just a reminder :)
--Jani
Felipe Pena kirjoitti:
felipe Fri Nov 21 19:14:
On Thu, 30 Nov 2006, Andrei Zmievski wrote:
> andreiThu Nov 30 21:20:56 2006 UTC
>
> Modified files:
> /php-src/ext/standard string.c
> Log:
> Mark strtr() as Unicode-safe.
>
> # Right, Derick?
Yes, affirmative.
Derick
--
PHP CVS Mailing List
No, check out unicode-progress.txt.
-Andrei
On Aug 31, 2006, at 8:56 AM, Andrei Zmievski wrote:
It's cool that you fixed it, but all that is going to change when the
functions are upgraded..
-Andrei
On Aug 31, 2006, at 7:19 AM, Antony Dovgal wrote:
tony2001Thu Aug 31 14:19
On 31.08.2006 19:56, Andrei Zmievski wrote:
It's cool that you fixed it, but all that is going to change when the
functions are upgraded..
I thought they are already Unicode aware, aren't they?
--
Wbr,
Antony Dovgal
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http:/
It's cool that you fixed it, but all that is going to change when the
functions are upgraded..
-Andrei
On Aug 31, 2006, at 7:19 AM, Antony Dovgal wrote:
tony2001Thu Aug 31 14:19:33 2006 UTC
Modified files:
/php-src/ext/standard string.c
Log:
more z/Z fixes
--
On Sat, 22 Oct 2005, Rolland Santimano wrote:
> @@ -1917,7 +1917,7 @@
>
> /* {{{ php_u_stristr
> Unicode version of case insensitve strstr */
> -PHPAPI UChar *php_u_stristr(UChar *s, UChar *t, int32_t s_len, int32_t t_len)
> +\PHPAPI UChar *php_u_stristr(UChar *s, UChar *t, int32_t s_len, i
On Sat, 22 Oct 2005, Rolland Santimano wrote:
--- Jani Taskinen <[EMAIL PROTECTED]> wrote:
What's a "codept" ??
--Jani
Ah, that would be "codepoint"
It would be nice if you didn't shorten these things.
(read: FIX IT! :)
--Jani
--
PHP CVS Mailing List (http://www.p
--- Jani Taskinen <[EMAIL PROTECTED]> wrote:
>
> What's a "codept" ??
>
> --Jani
Ah, that would be "codepoint"
> On Sat, 22 Oct 2005, Rolland Santimano wrote:
>
> >
> > rolland Sat Oct 22 01:52:55 2005 EDT
> >
> > Modified files:
> >/php-src/ext/standardstring.c
What's a "codept" ??
--Jani
On Sat, 22 Oct 2005, Rolland Santimano wrote:
rolland Sat Oct 22 01:52:55 2005 EDT
Modified files:
/php-src/ext/standardstring.c
Log:
- php_u_stristr: Code comments
http://cvs.php.net/diff.php/php-src/ext/standard/string.c?r1=1.499
Seems it is broken.
Dmitry.
> -Original Message-
> From: Rolland Santimano [mailto:[EMAIL PROTECTED]
> Sent: Monday, October 03, 2005 9:00 PM
> To: php-cvs@lists.php.net
> Subject: [PHP-CVS] cvs: php-src /ext/standard string.c
>
>
> rolland Mon Oct 3 13:00:05 2005 EDT
>
This one needs to be tested really thoroughly..
-Andrei
On Oct 3, 2005, at 10:00 AM, Rolland Santimano wrote:
rolland Mon Oct 3 13:00:05 2005 EDT
Modified files:
/php-src/ext/standard string.c
Log:
- Unicode impl of strip_tags()
--
PHP CVS Mailing List (http://www.ph
Rolland,
+PHPAPI void php_unify_string_types(zval **p, zval **q TSRMLS_DC)
+{
+if (p == NULL || q == NULL) {
+return;
+}
+
+if (Z_TYPE_PP(p) == IS_UNICODE) {
+if (Z_TYPE_PP(q) == IS_BINARY) {
+convert_to_binary_ex(p);
+} else {
+convert
On Sep 5, 2005, at 3:55 AM, Rolland Santimano wrote:
+while (i < input_len) {
+U16_FWD_1((UChar *)input, i, input_len);
+input_codepts++;
There's u_countChar32() function that counts the number of codepoints.
+if (input_type == IS_UNICODE) {
+resu
On Thu, 8 Sep 2005, Rolland Santimano wrote:
> rolland Thu Sep 8 01:05:38 2005 EDT
>
> Modified files:
> /php-src/ext/standard string.c
> Log:
> - Unicode impl of substr_replace()
Can you please update the "unicode-process.txt" file in the root of CVS
Hi Roland,
This patch introduced crashes in substr_replace().
Probably I fixed all of them.
Please check your patches before commit.
Do "make test" and "make utest" before and after patch to see that you broke
nothing.
Dmitry.
> -Original Message-
> From: Rolland Santimano [mailto:[EMAI
Rolland,
The implementation of this is problematic for two reasons:
1) You are assuming well-formed UTF-16 here. It would be better to use
U16_PREV() macro to obtain a codepoint and then put it in proper place
with zend_codepoint_to_uchar().
2) Combining sequences are not respected. We can
--- Dmitry Stogov <[EMAIL PROTECTED]> wrote:
> Hi Roland,
>
> Please be more carefull with your patches.
> Compile PHP with --enable-debug and run "make test" and "make utest"
> before and after patch to see that you don't break something.
>
> Now I fixed all (I hope) implode() bugs that you int
On Wed, 17 Aug 2005, Rolland Santimano wrote:
+/* {{{ proto php_u_ucwords()
+ Uppercase the first character of every word in an Unicode string */
+static void php_u_ucwords(zval *ustr, zval *retval)
Don't make protos for internal functions.
(just remove the word 'proto' from these)
On Aug 17, 2005, at 10:27 AM, Dmitry Stogov wrote:
Zend/zend_API.c:
zend_error(error_type, "Method %s%s%s() cannot be a NULL
function",
scope ? scope->name : EMPTY_STR, scope ? "::" : "", ptr->fname);
This place doesn't need EMPTY_STR. ("" is enough)
If EMPTY_STR is supposed to be used on
Hi,
> Dmitriy,
>
> Where did EMPTY_STR come from?
It was defined by me.
> It seems to be used in non-Unicode
> context also:
>
> Zend/zend_API.c:
>zend_error(error_type, "Method %s%s%s() cannot be a NULL
> function",
> scope ? scope->name : EMPTY_STR, scope ? "::" : "", ptr->fname);
Th
Dmitriy,
Where did EMPTY_STR come from? It seems to be used in non-Unicode
context also:
Zend/zend_API.c:
zend_error(error_type, "Method %s%s%s() cannot be a NULL function",
scope ? scope->name : EMPTY_STR, scope ? "::" : "", ptr->fname);
Besides, it generates a compile warning. Should we
Why not pass it as parameter to the function instead?
The parameters were changed already anyway..
--Jani
On Tue, 16 Aug 2005, Marcus Boerger wrote:
helly Tue Aug 16 16:22:38 2005 EDT
Modified files:
/php-src/ext/standardstring.c
Log:
- TSRM Fix
http://c
Hi Roland,
Please be more carefull with your patches.
Compile PHP with --enable-debug and run "make test" and "make utest" before
and after patch to see that you don't break something.
Now I fixed all (I hope) implode() bugs that you introduced.
Dmitry.
> -Original Message-
> From: Roll
On Aug 16, 2005, at 5:04 AM, Rolland Santimano wrote:
+ if (Z_TYPE_P(delim) != IS_UNICODE && Z_TYPE_P(delim) != IS_BINARY) {
+ convert_to_string_ex(&delim);
+ }
+ Z_TYPE_P(retval) = return_type = Z_TYPE_P(delim); /* ... to start
off */
This is not correct. If the de
Hello Andrei,
for the return_value this *might* result in the same behavior. The
REPLACE_ZVAL_VALUE() macro checks refount and is_ref first which is
what i wanted to avoid. The changes i did ensure the both are neither
read nor changed.
regards
marcus
Friday, March 11, 2005, 9:40:16 PM, you wr
Why not use REPLACE_ZVAL_VALUE() macro?
On Thu, 10 Mar 2005, Marcus Boerger wrote:
> helly Thu Mar 10 18:42:16 2005 EDT
>
> Modified files:
> /php-src/ext/standard string.c
> Log:
> - Do not touch return_valu's refcount or is_ref
>
> http://cvs.php.net/diff
On Thu, 18 Mar 2004, Dmitry Stogov wrote:
> dmitryThu Mar 18 04:48:46 2004 EDT
>
> Modified files:
> /php-src/ext/standard string.c
> Log:
> BUG #27457 was fixed (using temporary hash table with string keys only)
Please update the bugreport and add a news entry and t
Please add a regression test for this bug.
--Jani
On Fri, 26 Sep 2003, Sara Golemon wrote:
>pollitaFri Sep 26 13:57:13 2003 EDT
>
> Modified files:
>/php-src/ext/standard string.c
> Log:
> Bug Fix#25671 Corruption in subarrays in subject w
"Sara Golemon" <[EMAIL PROTECTED]> wrote:
> - result = *subject_entry;
> + MAKE_STD_ZVAL(result);
> + SEPARATE_ZVAL(subject_entry);
> + *result = **subject_entry;
> +
31 matches
Mail list logo
