Re: [PHP-CVS] cvs: php4 /ext/mbstring mbstring.c

2002-10-26 Thread Moriyoshi Koizumi
> For once: DISCUSS things before you remove patches by others. I don't > care if it was wrong, but removing code added by others without > DISCUSSing is considered quite RUDE. (Just like typing in capitals). If you want to tell Yasuo to do so, I would like you to try to discuss the things befo

Re: [PHP-CVS] cvs: php4 /ext/mbstring mbstring.c

2002-10-26 Thread Yasuo Ohgaki
Derick Rethans wrote: On Sat, 26 Oct 2002, Yasuo Ohgaki wrote: yohgaki Fri Oct 25 22:08:05 2002 EDT Modified files: /php4/ext/mbstring mbstring.c Log: Remove useless check. # Problem was in other place For once: DISCUSS things before you remove patches by others. I don

Re: [PHP-CVS] cvs: php4 /ext/mbstring mbstring.c

2002-10-26 Thread Derick Rethans
On Sat, 26 Oct 2002, Yasuo Ohgaki wrote: > yohgaki Fri Oct 25 22:08:05 2002 EDT > > Modified files: > /php4/ext/mbstringmbstring.c > Log: > Remove useless check. > # Problem was in other place For once: DISCUSS things before you remove patches by

Re: [PHP-CVS] cvs: php4 /ext/mbstring mbstring.c

2002-10-16 Thread Moriyoshi Koizumi
> I modified to support encoding_translation setting per directory basis. > Please try modified code in cvs. verified. It seems to work well. Moriyoshi -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php4 /ext/mbstring mbstring.c

2002-10-16 Thread Rui Hirokawa
I modified to support encoding_translation setting per directory basis. Please try modified code in cvs. Rui On Wed, 16 Oct 2002 01:23:04 +0900 Moriyoshi Koizumi <[EMAIL PROTECTED]> wrote: > Hello, > > I think this change won't enough for the expected behaviour, because > > sapi_register_tre

Re: [PHP-CVS] cvs: php4 /ext/mbstring mbstring.c

2002-10-15 Thread Moriyoshi Koizumi
Hello, I think this change won't enough for the expected behaviour, because sapi_register_treat_data(mbstr_treat_data); is only invoked in tne PHP_MINIT_FUNCTION(mbstring), and would never be invoked on a request when the encoding_translation is turned off globally, and it is on in per-dir se

Re: [PHP-CVS] cvs: php4 /ext/mbstring mbstring.c mbstring.hphp_mbregex.c php_mbregex.h

2002-10-07 Thread Moriyoshi Koizumi
> Please don't merge until after we branched the real PHP_4_3 branch... > Also, please do not add new features until then. The first milestone of php-i18n.sourceforge.jp project is merging the new code base into PHP_4_3 release... I suppose it would be a little late, so I won't try to do it des

Re: [PHP-CVS] cvs: php4 /ext/mbstring mbstring.c mbstring.hphp_mbregex.c php_mbregex.h

2002-10-07 Thread Derick Rethans
On Mon, 7 Oct 2002, Moriyoshi Koizumi wrote: > moriyoshi Mon Oct 7 13:59:49 2002 EDT > > Added files: > /php4/ext/mbstringphp_mbregex.h > > Modified files: > /php4/ext/mbstringmbstring.c mbstring.h php_mbregex.c > Log:

Re: [PHP-CVS] cvs: php4 /ext/mbstring mbstring.c mbstring.h php_mbregex.c php_mbregex.h

2002-10-07 Thread Moriyoshi Koizumi
Perhaps this appears to be breaking the build, because I've made a slight change to the dependency between mbstring.c and php_mbregex.c. In such case, please do "make clean" before complaining to me :) "Moriyoshi Koizumi" <[EMAIL PROTECTED]> wrote: > moriyoshi Mon Oct 7 13:59:49 200