Re: [PHP-CVS] cvs: php4 /ext/standard basic_functions.c php_string.hstring.c

2002-10-18 Thread Andi Gutmans
This should follow naming standards and start with str_ Andi At 03:27 AM 10/17/2002 +, Ilia Alshanetsky wrote: iliaa Wed Oct 16 23:27:19 2002 EDT Modified files: /php4/ext/standard basic_functions.c php_string.h string.c Log: Added word_count() function that allows coun

Re: [PHP-CVS] cvs: php4 /ext/standard basic_functions.c php_string.hstring.c

2002-10-18 Thread Andi Gutmans
At 06:42 PM 10/17/2002 -0400, Ilia A. wrote: I'll correct the name of the function I've added, I applogize for the oversight. I do not think we should rename existing functions because it would break BC and force us add to add even more function aliases. We already have 400+ function alises in PHP

Re: [PHP-CVS] cvs: php4 /ext/standard basic_functions.c php_string.hstring.c

2002-10-18 Thread Andi Gutmans
At 06:25 PM 10/17/2002 -0400, Jon Parise wrote: On Fri, Oct 18, 2002 at 12:22:10AM +0200, Andi Gutmans wrote: > This should follow naming standards and start with str_ We also ready have 'wordwrap'. This adds 'word_count'. You suggest staying with 'str_'. I think, whatever is decided, we shou

Re: [PHP-CVS] cvs: php4 /ext/standard basic_functions.c php_string.hstring.c

2002-09-25 Thread Adam Maccabee Trachtenberg
I think it would be better to either use a correct algorithm or not to add this function at all. I think it's a reasonable expectation on a user's part to assume that foo_shuffle() actually does a proper shuffle. We got all sorts of complaints about the array shuffling code being broken. -adam O