Re: [PHP-CVS] svn: /php/php-src/trunk/ext/standard/ basic_functions.c exec.c exec.h

2011-10-24 Thread Rui Hirokawa
Hi Pierre, I only tested on Linux. This patch is not related to Win32, because the quotation is always escaped on Win32. I will add the test script within couple of days, and I will updated the document soon. Rui Pierre Joye wrote: > hi Rui, > > Did you test it that on other platforms than l

Re: [PHP-CVS] svn: /php/php-src/trunk/ext/standard/ basic_functions.c exec.c exec.h

2011-10-24 Thread Pierre Joye
hi Rui, Did you test it that on other platforms than linux? It will also be nice to add tests case for this as this function (actually both escape args and cmds) has suffered from lack of testing on all platforms in the last php releases. Btw, update the upgrading guide too :) On Sun, Oct 23, 2

Re: [PHP-CVS] svn: /php/php-src/trunk/ext/standard/ basic_functions.c

2011-09-05 Thread Ferenc Kovacs
\o/ thanks for fixing! On Mon, Sep 5, 2011 at 11:27 AM, Hannes Magnusson wrote: > bjori                                    Mon, 05 Sep 2011 09:27:23 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=316134 > > Log: > Not all submodules have MINIT, but they have MINFO and need t

Re: [PHP-CVS] svn: /php/php-src/trunk/ext/standard/ basic_functions.c file.c file.h

2010-08-16 Thread Kalle Sommer Nielsen
Hi Johannes 2010/8/16 Kalle Sommer Nielsen : > kalle                                    Mon, 16 Aug 2010 21:56:35 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=302376 > > Log: > Fixed the context parameter on copy() to actually have an effect > > # After looking at the logs,

Re: [PHP-CVS] svn: /php/php-src/trunk/ext/standard/ basic_functions.c image.c php_image.h

2010-05-07 Thread Hannes Magnusson
On Wed, May 5, 2010 at 15:37, Pierre Joye wrote: > pajoye                                   Wed, 05 May 2010 13:37:40 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=299021 > > Log: > - #51063, implement getimagesizefromstring > > Bug: http://bugs.php.net/51063 (Assigned) Add

Re: [PHP-CVS] svn: /php/php-src/trunk/ext/standard/ basic_functions.c

2010-04-22 Thread Antony Dovgal
On 22.04.2010 02:04, Kalle Sommer Nielsen wrote: > kalleWed, 21 Apr 2010 22:04:19 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=298275 > > Log: > Added missing zend_parse_parameters_none() call to sys_getloadavg() Please don't forget to

Re: [PHP-CVS] svn: /php/php-src/trunk/ext/standard/ basic_functions.c streamsfuncs.c streamsfuncs.h var_unserializer.c

2010-04-12 Thread Johannes Schlüter
Hi, On Mon, 2010-04-12 at 08:25 +, Pierre Joye wrote: > - switch (ZEND_NUM_ARGS()) { > - case 2: > - if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "rl", > &arg1, &arg2) == FAILURE) { > - RETURN_FALSE; > - } > - break; > -