[PHP-CVS] cvs: php4 /ext/standard info.c

2002-09-08 Thread Sander Roobol
sander Sun Sep 8 04:08:35 2002 EDT Modified files: /php4/ext/standard info.c Log: Fix typo Index: php4/ext/standard/info.c diff -u php4/ext/standard/info.c:1.200 php4/ext/standard/info.c:1.201 --- php4/ext/standard/info.c:1.200 Sat Sep 7 19:14:22 20

Re: [PHP-CVS] cvs: php4(apache_hooks) /sapi/apache php_apache.c

2002-09-08 Thread Andi Gutmans
If these are new functions you shouldn't have the aliases but only the names which conform to our coding standards, i.e., apache_*. Andi At 11:49 PM 8/26/2002 +, lukas schroeder wrote: >+ /* tables & arrays */ >+ PHP_FALIAS(headers_in, >apache_request_headers_in,

Re: [PHP-CVS] cvs: php4 /ext/domxml php_domxml.c

2002-09-08 Thread Andi Gutmans
Same here. Guys, if certain functions are new then why add non-coding standard conforming names? I think having a function called "free" is really sucky. We should only keep old function names if we feel it'll break too many old scripts. As free is a new function it won't. Andi At 07:25 AM 8/

Re: [PHP-CVS] cvs: php4 /ext/gd gd.c

2002-09-08 Thread Andi Gutmans
Yes we did. Andi At 07:40 PM 8/27/2002 +, Marcus Börger wrote: >helly Tue Aug 27 15:40:56 2002 EDT > > Modified files: > /php4/ext/gdgd.c > Log: > php_error_docref > > BUT didn't we decide to disable those functions when not supported > instead of displaying a

Re: [PHP-CVS] cvs: php4(apache_hooks) /sapi/apache mod_php4.c php_apache_http.h

2002-09-08 Thread Andi Gutmans
At 08:57 PM 8/27/2002 +, George Schlossnagle wrote: > To allow for the stacked handlers, the entirety of zend_stack.c was > imported into mod_php4.c. There is a patch pending to zend_stack.c to > add the functionality so that all the redundant code can be removed. > What patch is that?

Re: [PHP-CVS] cvs: php4 /ext/ftp ftp.c php_ftp.c

2002-09-08 Thread Andi Gutmans
There should be a standard way of writing this. It kind of sucks to have two lines with almost exactly the same code. At 10:13 AM 9/5/2002 +, Anantha Kesari H Y wrote: >+#if defined(NETWARE) && !defined(USE_WINSOCK) >+ if (getsockname(ftp->fd, (struct sockaddr*) &ftp->localaddr, >(uns

Re: [PHP-CVS] cvs: php4 /ext/ftp ftp.c php_ftp.c

2002-09-08 Thread Sterling Hughes
> There should be a standard way of writing this. It kind of sucks to have > two lines with almost exactly the same code. > > At 10:13 AM 9/5/2002 +, Anantha Kesari H Y wrote: > >+#if defined(NETWARE) && !defined(USE_WINSOCK) > >+ if (getsockname(ftp->fd, (struct sockaddr*) &ftp->local

Re: [PHP-CVS] cvs: php4 /ext/domxml php_domxml.c

2002-09-08 Thread Christian Stocker
Hi This commit was reverted some minutes after the commit. It was a non intentional commit and there is no function called domxml_doc_free right now in the source tree. But anyway, this "free" was only used as a method within the DomDocument class. There was never a function called just free, bu

Re: [PHP-CVS] cvs: php4 /ext/domxml php_domxml.c

2002-09-08 Thread Andi Gutmans
At 03:59 PM 9/8/2002 +0200, Christian Stocker wrote: >Hi > >This commit was reverted some minutes after the commit. It was a non >intentional commit and there is no function called domxml_doc_free right >now in the source tree. > >But anyway, this "free" was only used as a method within the DomDoc

[PHP-CVS] cvs: php4 / makedist.ZendEngine2

2002-09-08 Thread Andi Gutmans
andiSun Sep 8 11:38:44 2002 EDT Modified files: /php4 makedist.ZendEngine2 Log: - Simplify makedist Index: php4/makedist.ZendEngine2 diff -u php4/makedist.ZendEngine2:1.2 php4/makedist.ZendEngine2:1.3 --- php4/makedist.ZendEngine2:1.2 Mon Ma

[PHP-CVS] cvs: php4 /ext/standard basic_functions.c ftp_fopen_wrapper.c

2002-09-08 Thread Stefan Esser
sesser Sun Sep 8 12:45:32 2002 EDT Modified files: /php4/ext/standard basic_functions.c ftp_fopen_wrapper.c Log: Added EXPERIMENTAL ftps fopen wrapper. For now this leaks the control connection stream because you cannot close the control connection in ss

[PHP-CVS] cvs: CVSROOT / avail

2002-09-08 Thread Sterling Hughes
sterlingSun Sep 8 13:18:00 2002 EDT Modified files: /CVSROOTavail Log: give jmoore Zend access Index: CVSROOT/avail diff -u CVSROOT/avail:1.490 CVSROOT/avail:1.491 --- CVSROOT/avail:1.490 Fri Sep 6 20:40:40 2002 +++ CVSROOT/avail Sun Sep

[PHP-CVS] cvs: php4 /sapi/nsapi config.m4

2002-09-08 Thread Dan Kalowsky
kalowskySun Sep 8 14:13:57 2002 EDT Modified files: /php4/sapi/nsapiconfig.m4 Log: Fix for bug #19290 # Untested Index: php4/sapi/nsapi/config.m4 diff -u php4/sapi/nsapi/config.m4:1.14 php4/sapi/nsapi/config.m4:1.15 --- php4/sapi/nsapi/config

[PHP-CVS] cvs: php4 /ext/standard ftp_fopen_wrapper.c

2002-09-08 Thread Stefan Esser
sesser Sun Sep 8 15:11:08 2002 EDT Modified files: /php4/ext/standard ftp_fopen_wrapper.c Log: Control connection gets closed in ssl mode now, too. Index: php4/ext/standard/ftp_fopen_wrapper.c diff -u php4/ext/standard/ftp_fopen_wrapper.c:1.28 php4/ex

[PHP-CVS] cvs: php4 / NEWS

2002-09-08 Thread Stefan Esser
sesser Sun Sep 8 15:15:46 2002 EDT Modified files: /php4 NEWS Log: Added ftps:// fopen() wrapper to NEWS. Index: php4/NEWS diff -u php4/NEWS:1.1114 php4/NEWS:1.1115 --- php4/NEWS:1.1114Sat Sep 7 20:34:55 2002 +++ php4/NEWS Sun Sep 8 15:15:

[PHP-CVS] cvs: php4 /ext/standard ftp_fopen_wrapper.c

2002-09-08 Thread Stefan Esser
sesser Sun Sep 8 15:35:43 2002 EDT Modified files: /php4/ext/standard ftp_fopen_wrapper.c Log: ftp(s) fopen() wrapper does no longer ignore the ip returned by PASV. Index: php4/ext/standard/ftp_fopen_wrapper.c diff -u php4/ext/standard/ftp_fopen_wrappe

[PHP-CVS] cvs: php4 /ext/standard ftp_fopen_wrapper.c

2002-09-08 Thread Shane Caraveo
shane Sun Sep 8 16:52:03 2002 EDT Modified files: /php4/ext/standard ftp_fopen_wrapper.c Log: someone missed code requiring ssl Index: php4/ext/standard/ftp_fopen_wrapper.c diff -u php4/ext/standard/ftp_fopen_wrapper.c:1.30 php4/ext/standard/ftp_fopen_w

[PHP-CVS] cvs: php4 /ext/cyrus config.m4

2002-09-08 Thread Jon Parise
jon Sun Sep 8 16:59:53 2002 EDT Modified files: /php4/ext/cyrus config.m4 Log: Capitalization Index: php4/ext/cyrus/config.m4 diff -u php4/ext/cyrus/config.m4:1.7 php4/ext/cyrus/config.m4:1.8 --- php4/ext/cyrus/config.m4:1.7Wed Sep 4 13:41:

[PHP-CVS] cvs: php4 / NEWS

2002-09-08 Thread Jani Taskinen
sniper Sun Sep 8 17:06:23 2002 EDT Modified files: /php4 NEWS Log: nice..nice.. Index: php4/NEWS diff -u php4/NEWS:1.1115 php4/NEWS:1.1116 --- php4/NEWS:1.1115Sun Sep 8 15:15:45 2002 +++ php4/NEWS Sun Sep 8 17:06:22 2002 @@ -3,8 +3,8 @@ ? ?

[PHP-CVS] cvs: php4 / NEWS

2002-09-08 Thread Jani Taskinen
sniper Sun Sep 8 17:48:59 2002 EDT Modified files: /php4 NEWS Log: s/send/sent/ Index: php4/NEWS diff -u php4/NEWS:1.1116 php4/NEWS:1.1117 --- php4/NEWS:1.1116Sun Sep 8 17:06:22 2002 +++ php4/NEWS Sun Sep 8 17:48:59 2002 @@ -3,7 +3,7 @@ ? ?

[PHP-CVS] cvs: php4 /ext/standard ftp_fopen_wrapper.c /main network.c php_network.h

2002-09-08 Thread Stefan Esser
sesser Sun Sep 8 18:26:11 2002 EDT Modified files: /php4/ext/standard ftp_fopen_wrapper.c /php4/main network.c php_network.h Log: Added possibility to reuse an old SSL session id. Ugly but needed for f.e.: debians ftpd-ssl Index: php4/ex

[PHP-CVS] cvs: php4 / CODING_STANDARDS

2002-09-08 Thread Yasuo Ohgaki
yohgaki Sun Sep 8 18:38:57 2002 EDT Modified files: /php4 CODING_STANDARDS Log: It seems we're better to mention about missing functions. PHP_FUNCTION -> ZEND_FUNCTION Index: php4/CODING_STANDARDS diff -u php4/CODING_STANDARDS:1.18 php4/CODING_STAND

Re: [PHP-CVS] cvs: php4 / CODING_STANDARDS

2002-09-08 Thread derick
On Sun, 8 Sep 2002, Yasuo Ohgaki wrote: > yohgaki Sun Sep 8 18:38:57 2002 EDT > > Modified files: > /php4 CODING_STANDARDS > Log: > It seems we're better to mention about missing functions. > PHP_FUNCTION -> ZEND_FUNCTION erm, where was this decided

Re: [PHP-CVS] cvs: php4 / CODING_STANDARDS

2002-09-08 Thread Edin Kadribasic
On Sun, 08 Sep 2002 22:38:57 - "Yasuo Ohgaki" <[EMAIL PROTECTED]> wrote: > yohgaki Sun Sep 8 18:38:57 2002 EDT > > Modified files: > /php4 CODING_STANDARDS > Log: > It seems we're better to mention about missing functions. > PHP_FUNCTION -> ZEND_F

RE: [PHP-CVS] cvs: php4 / CODING_STANDARDS

2002-09-08 Thread James Cox
> +[10] Do no define that is not available. For instance, if > library available is > + missing function(s), do not define function nor raise error > for missing > + function(s). > + yasuo, i really don't mean to sound nasty, or anything like this... but if you want to check in text lik

[PHP-CVS] cvs: php4 / CODING_STANDARDS

2002-09-08 Thread Jon Parise
jon Sun Sep 8 19:00:34 2002 EDT Modified files: /php4 CODING_STANDARDS Log: Reword item 10 for greater clarity. Index: php4/CODING_STANDARDS diff -u php4/CODING_STANDARDS:1.19 php4/CODING_STANDARDS:1.20 --- php4/CODING_STANDARDS:1.19 Sun Sep 8 1

Re: [PHP-CVS] cvs: php4 / CODING_STANDARDS

2002-09-08 Thread Jon Parise
On Sun, Sep 08, 2002 at 11:56:39PM +0100, James Cox wrote: > yasuo, i really don't mean to sound nasty, or anything like this... but if > you want to check in text like this, please send it via php-dev for > review... this just doesn't make any sense. > > What you wanted to say is: > > [10] Do

RE: [PHP-CVS] cvs: php4 / CODING_STANDARDS

2002-09-08 Thread James Cox
> I just committed a reworded version. I'm sorry I didn't catch your > response first, though, or I would have opened it up to further > critique. > Jon, i wouldn't worry about it too much... (yours made more sense than mine :)) but it was just something that had niggled me over the last few m

[PHP-CVS] cvs: php4(PHP_4_2_0) /ext/mbstring mbstring.c

2002-09-08 Thread Yasuo Ohgaki
yohgaki Sun Sep 8 20:01:44 2002 EDT Modified files: (Branch: PHP_4_2_0) /php4/ext/mbstring mbstring.c Log: MFH. This should fix all var initilization problems finally. Index: php4/ext/mbstring/mbstring.c diff -u php4/ext/mbstring/mbstring.c:1.48.2.16 php4/e

[PHP-CVS] cvs: php4(PHP_4_2_0) /main SAPI.c

2002-09-08 Thread Yasuo Ohgaki
yohgaki Sun Sep 8 20:32:40 2002 EDT Modified files: (Branch: PHP_4_2_0) /php4/main SAPI.c Log: Fixed typo. Index: php4/main/SAPI.c diff -u php4/main/SAPI.c:1.129.2.3 php4/main/SAPI.c:1.129.2.4 --- php4/main/SAPI.c:1.129.2.3 Sat Jul 27 09:15:42 2002 +++ php

[PHP-CVS] cvs: php4(PHP_4_2_0) / NEWS

2002-09-08 Thread Yasuo Ohgaki
yohgaki Sun Sep 8 20:38:32 2002 EDT Modified files: (Branch: PHP_4_2_0) /php4 NEWS Log: Oops. Last commit was not intentinal. It seems 4.3.0-dev has all fixes needed already. Mention Content-Type fix. Index: php4/NEWS diff -u php4/NEWS:1.885.2.60 ph

Re: [PHP-CVS] cvs: php4 / CODING_STANDARDS

2002-09-08 Thread Yasuo Ohgaki
Jon Parise wrote: > On Sun, Sep 08, 2002 at 11:56:39PM +0100, James Cox wrote: > > >>yasuo, i really don't mean to sound nasty, or anything like this... but if >>you want to check in text like this, please send it via php-dev for >>review... this just doesn't make any sense. >> >>What you wanted

Re: [PHP-CVS] cvs: php4 / CODING_STANDARDS

2002-09-08 Thread Yasuo Ohgaki
[EMAIL PROTECTED] wrote: > On Sun, 8 Sep 2002, Yasuo Ohgaki wrote: > > >>yohgaki Sun Sep 8 18:38:57 2002 EDT >> >> Modified files: >>/php4 CODING_STANDARDS >> Log: >> It seems we're better to mention about missing functions. >> PHP_FUNCTION -> ZEND_FUNCT

Re: [PHP-CVS] cvs: php4 / CODING_STANDARDS

2002-09-08 Thread Thies C. Arntzen
On Mon, Sep 09, 2002 at 12:49:04AM +0200, [EMAIL PROTECTED] wrote: > On Sun, 8 Sep 2002, Yasuo Ohgaki wrote: > > > yohgaki Sun Sep 8 18:38:57 2002 EDT > > > > Modified files: > > /php4 CODING_STANDARDS > > Log: > > It seems we're better to mention about mi