Hi Ilia,
when testing conversion to gd2 you do not test for gd2 existance
(imagegd2() function)
instead you assume that the tests fail if one uses an external gd lib (what
makes the
function check needless of cause). But why is that so? And why not print
out an error
then? Maybe we direct the
helly Thu Dec 5 06:38:14 2002 EDT
Modified files: (Branch: PHP_4_3)
/php4 configure.in
Log:
MFH
Index: php4/configure.in
diff -u php4/configure.in:1.396.2.8 php4/configure.in:1.396.2.9
--- php4/configure.in:1.396.2.8 Mon Dec 2 02:03:37 2002
+++
helly Thu Dec 5 07:39:01 2002 EDT
Modified files:
/php4/ext/standard image.c
Log:
Return FALSE on error as mentioned by John Coggeshall.
See Bug #20822
Index: php4/ext/standard/image.c
diff -u php4/ext/standard/image.c:1.77
helly Thu Dec 5 07:44:21 2002 EDT
Modified files: (Branch: PHP_4_3)
/php4/ext/standard aggregation.c
Log:
Fix aggregation with ZE2 in PHP4.3\n#I will not MFB it since aggregation should move
to ZEndEngine
Index: php4/ext/standard/aggregation.c
diff -u
helly Thu Dec 5 07:47:22 2002 EDT
Modified files: (Branch: PHP_4_3)
/php4/ext/standard image.c
Log:
MFH: swc zlib\nMFH: return FALSE
Index: php4/ext/standard/image.c
diff -u php4/ext/standard/image.c:1.72.2.4 php4/ext/standard/image.c:1.72.2.5
---
On Thu, 5 Dec 2002, Marcus Boerger wrote:
helly Thu Dec 5 07:47:22 2002 EDT
Modified files: (Branch: PHP_4_3)
/php4/ext/standardimage.c
Log:
MFH: swc zlib\nMFH: return FALSE
\n doesn't work on the command line :-)
Derick
--
helly Thu Dec 5 07:55:02 2002 EDT
Modified files: (Branch: PHP_4_2_0)
/php4/ext/standard image.c
Log:
MFH: return FALSE
Index: php4/ext/standard/image.c
diff -u php4/ext/standard/image.c:1.44.2.3 php4/ext/standard/image.c:1.44.2.4
---
My tests have a if (!GD_BUNDLED) {}, which as I understand should cause the
test to be skipped in the event non-bundled GD is being used. The bundled gd
will always fail and that is NOT an assumption, the external gd has bugs that
were fixed in bundled gd these are known so it is pointless to
array_init() can no longer fail, because it means that ZE was unable to
allocate memory at which point ZE will cease the script execution. So, if
there are any existing checks for return value of array_init() or any other
e* memory allocation functions, those checks can be safely removed since
On December 5, 2002 10:26 am, Marcus Börger wrote:
At 16:23 05.12.2002, Ilia A. wrote:
array_init() can no longer fail, because it means that ZE was unable to
allocate memory at which point ZE will cease the script execution. So, if
there are any existing checks for return value of
sas Thu Dec 5 10:35:04 2002 EDT
Modified files:
/php4/ext/ircg ircg.c
Log:
let the write buffer notify us about terminated connections
Index: php4/ext/ircg/ircg.c
diff -u php4/ext/ircg/ircg.c:1.155 php4/ext/ircg/ircg.c:1.156
---
On December 5, 2002 10:37 am, Marcus Börger wrote:
At 16:20 05.12.2002, Ilia A. wrote:
My tests have a if (!GD_BUNDLED) {}, which as I understand should cause
the test to be skipped in the event non-bundled GD is being used. The
bundled gd
you meant non bundeled gd here
will always fail
sniper Thu Dec 5 10:46:42 2002 EDT
Modified files: (Branch: PHP_4_3)
/php4/ext/mysql/libmysqlacinclude.m4
Log:
MFH
Index: php4/ext/mysql/libmysql/acinclude.m4
diff -u php4/ext/mysql/libmysql/acinclude.m4:1.8
php4/ext/mysql/libmysql/acinclude.m4:1.8.4.1
helly Thu Dec 5 10:52:35 2002 EDT
Modified files: (Branch: PHP_4_3)
/php4/ext/standard image.c
Log:
MFH: Remove unnecessary code here
Index: php4/ext/standard/image.c
diff -u php4/ext/standard/image.c:1.72.2.5 php4/ext/standard/image.c:1.72.2.6
---
helly Thu Dec 5 15:02:22 2002 EDT
Modified files: (Branch: PHP_4_3)
/php4/ext/mysql php_mysql.c
Log:
MFH
Index: php4/ext/mysql/php_mysql.c
diff -u php4/ext/mysql/php_mysql.c:1.174.2.2 php4/ext/mysql/php_mysql.c:1.174.2.3
---
iliaa Thu Dec 5 15:05:20 2002 EDT
Added files: (Branch: PHP_4_3)
/php4/ext/standard/tests/file test.csv bug12556.phpt
Modified files:
/php4/ext/standard file.c
Log:
MFH
Index: php4/ext/standard/file.c
diff -u
helly Thu Dec 5 15:13:36 2002 EDT
Modified files:
/php4/ext/session mod_files.c mod_mm.c session.c
Log:
php_error - php_error_docref
Index: php4/ext/session/mod_files.c
diff -u php4/ext/session/mod_files.c:1.83 php4/ext/session/mod_files.c:1.84
---
On Thu, 5 Dec 2002, Marcus Boerger wrote:
helly Thu Dec 5 15:13:36 2002 EDT
Modified files:
/php4/ext/session mod_files.c mod_mm.c session.c
Log:
php_error - php_error_docref
You made a type in here, TSRMlS (instead of TSRMLS). And can you also
uppercase
helly Thu Dec 5 15:41:55 2002 EDT
Modified files:
/php4/ext/session session.c
Log:
correct code that is guarded by #if 0
Index: php4/ext/session/session.c
diff -u php4/ext/session/session.c:1.339 php4/ext/session/session.c:1.340
---
helly Thu Dec 5 15:42:06 2002 EDT
Modified files: (Branch: PHP_4_3)
/php4/ext/session mod_mm.c session.c
Log:
MFH
Index: php4/ext/session/mod_mm.c
diff -u php4/ext/session/mod_mm.c:1.39.4.1 php4/ext/session/mod_mm.c:1.39.4.2
---
helly Thu Dec 5 16:09:19 2002 EDT
Modified files: (Branch: PHP_4_3)
/php4/ext/standard dl.c exec.c http_fopen_wrapper.c
incomplete_class.c levenshtein.c link.c math.c
pack.c reg.c scanf.c uniqid.c url.c var.c
Log:
At 22:01 05.12.2002, Derick Rethans wrote:
On Thu, 5 Dec 2002, Marcus Boerger wrote:
helly Thu Dec 5 15:59:50 2002 EDT
Modified files:
/php4/ext/standardbase64.c dl.c exec.c http_fopen_wrapper.c
incomplete_class.c levenshtein.c link.c
pollita Thu Dec 5 16:20:47 2002 EDT
Modified files:
/php4/ext/standard basic_functions.c aggregation.c aggregation.h
Log:
Bug #20746. Renamed aggregation_info() to aggregate_info() per naming conventions
and created alias for BC.
Index:
helly Thu Dec 5 18:18:29 2002 EDT
Modified files:
/php4/sapi/apache php_apache.c
Log:
php_error - php_error_docref
Index: php4/sapi/apache/php_apache.c
diff -u php4/sapi/apache/php_apache.c:1.69 php4/sapi/apache/php_apache.c:1.70
---
helly Thu Dec 5 18:19:02 2002 EDT
Modified files: (Branch: PHP_4_3)
/php4/sapi/apache php_apache.c
Log:
MFH
Index: php4/sapi/apache/php_apache.c
diff -u php4/sapi/apache/php_apache.c:1.69 php4/sapi/apache/php_apache.c:1.69.2.1
---
iliaa Thu Dec 5 18:19:03 2002 EDT
Modified files: (Branch: PHP_4_3)
/php4/ext/calendar calendar.c
Log:
Fixed memory leaks inside heb_number_to_chars().
Index: php4/ext/calendar/calendar.c
diff -u php4/ext/calendar/calendar.c:1.30
ssb Thu Dec 5 18:23:43 2002 EDT
Modified files:
/CVSROOTavail
Log:
* arnaud += pearweb/weeklynews
Index: CVSROOT/avail
diff -u CVSROOT/avail:1.555 CVSROOT/avail:1.556
--- CVSROOT/avail:1.555 Wed Dec 4 19:39:30 2002
+++ CVSROOT/avail Thu Dec
pajoye Thu Dec 5 21:16:07 2002 EDT
Modified files:
/php4/ext/gdgd.c php_gd.h
Log:
Add imageistruecolor
Index: php4/ext/gd/gd.c
diff -u php4/ext/gd/gd.c:1.234 php4/ext/gd/gd.c:1.235
--- php4/ext/gd/gd.c:1.234 Wed Dec 4 18:21:30 2002
+++
iliaa Fri Dec 6 01:07:40 2002 EDT
Modified files:
/php4/ext/ftp php_ftp.c
Log:
Fixed bug #20812, ftp_get returned NULL on success instead of TRUE.
Index: php4/ext/ftp/php_ftp.c
diff -u php4/ext/ftp/php_ftp.c:1.74 php4/ext/ftp/php_ftp.c:1.75
---
sebastian Fri Dec 6 01:08:17 2002 EDT
Removed files:
/php4/sapi/fastcgi .cvsignore CREDITS Makefile.frag README.Apache
README.FastCGI config.m4 fastcgi.c fastcgi.dsp
php.sym php_fastcgi.h windows.txt
iliaa Fri Dec 6 01:08:21 2002 EDT
Modified files: (Branch: PHP_4_3)
/php4/ext/ftp php_ftp.c
Log:
MFH
Index: php4/ext/ftp/php_ftp.c
diff -u php4/ext/ftp/php_ftp.c:1.74 php4/ext/ftp/php_ftp.c:1.74.2.1
--- php4/ext/ftp/php_ftp.c:1.74 Thu Oct 3 07:33:05
sas Fri Dec 6 01:08:59 2002 EDT
Modified files:
/php4/ext/ircg ircg.c
Log:
added a hook-registration function similiar to irc_connect() for
the write buffer. we register a callback for closed-conn notification
and an async handler for write_buf_add
sas Fri Dec 6 01:27:01 2002 EDT
Modified files:
/php4/ext/ircg config.m4
Log:
enable shared build
Index: php4/ext/ircg/config.m4
diff -u php4/ext/ircg/config.m4:1.17 php4/ext/ircg/config.m4:1.18
--- php4/ext/ircg/config.m4:1.17Tue Dec 3
sebastian Fri Dec 6 01:44:28 2002 EDT
Modified files:
/php4/sapi/servlet README
Log:
A bit of an update for the sapi/servlet installation guide.
Index: php4/sapi/servlet/README
diff -u php4/sapi/servlet/README:1.13 php4/sapi/servlet/README:1.14
---
sas Fri Dec 6 01:52:47 2002 EDT
Modified files:
/php4/ext/ircg ircg.c
Log:
fix uninitialized pointer issue
Index: php4/ext/ircg/ircg.c
diff -u php4/ext/ircg/ircg.c:1.157 php4/ext/ircg/ircg.c:1.158
--- php4/ext/ircg/ircg.c:1.157 Fri Dec 6 01:08:59
35 matches
Mail list logo
