Re: [PHP-CVS] cvs: php-src /ext/standard http.c

2006-07-23 Thread Andrei Zmievski
This is not entirely correct. With IS_UNICODE you need to compare against a 16-bit 0, not a '\0' which is an 8-bit one. -Andrei P.S. Why am I writing this after getting back from a bar? On Jul 22, 2006, at 11:05 PM, Marcus Boerger wrote: + if ((key_type == HASH_KEY_IS_STRING || key_type ==

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /main rfc1867.c rfc1867.h

2006-07-23 Thread Stefan Esser
Antony, > So this is the reason you think you can break the upcoming release now? > Please revert it, as I don't want to see yet another broken release > just because you decided you can do what you want. Instead of bothering me with your opinion have a look at my code and tell me where it is broke

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /main rfc1867.c rfc1867.h

2006-07-23 Thread Antony Dovgal
On 23.07.2006 11:16, Stefan Esser wrote: Antony, So this is the reason you think you can break the upcoming release now? Please revert it, as I don't want to see yet another broken release just because you decided you can do what you want. Instead of bothering me with your opinion Please stop

[PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /main rfc1867.c rfc1867.h

2006-07-23 Thread Stefan Esser
Antony, grow up. Stefan -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src /ext/xmlreader php_xmlreader.c /ext/xmlreader/tests 012.phpt 013.phpt

2006-07-23 Thread Antony Dovgal
On 19.07.2006 21:32, Rob Richards wrote: @@ -607,11 +613,18 @@ zval *id; int name_len = 0, ns_uri_len = 0; xmlreader_object *intern; - char *name, *ns_uri, *retchar = NULL; + xmlChar *retchar = NULL; + char *name, *ns_uri; + UConverter *orig_runtime

Re: [PHP-CVS] cvs: php-src /ext/xmlreader php_xmlreader.c /ext/xmlreader/tests 012.phpt 013.phpt

2006-07-23 Thread Andrei Zmievski
Right, we need a different workaround. I am about to jump on a plane, but will revisit it as soon as possible. -Andrei On Jul 23, 2006, at 5:22 AM, Antony Dovgal wrote: On 19.07.2006 21:32, Rob Richards wrote: @@ -607,11 +613,18 @@ zval *id; int name_len = 0, ns_uri_len = 0

Re: [PHP-CVS] cvs: php-src /ext/xmlreader php_xmlreader.c /ext/xmlreader/tests 012.phpt 013.phpt

2006-07-23 Thread Antony Dovgal
On 23.07.2006 15:27, Andrei Zmievski wrote: Right, we need a different workaround. I am about to jump on a plane, but will revisit it as soon as possible. Great, thanks a lot. On Jul 23, 2006, at 5:22 AM, Antony Dovgal wrote: On 19.07.2006 21:32, Rob Richards wrote: @@ -607,11 +613,18 @@

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /main rfc1867.c rfc1867.h

2006-07-23 Thread Derick Rethans
On Sun, 23 Jul 2006, Stefan Esser wrote: > Antony, > > So this is the reason you think you can break the upcoming release now? > > Please revert it, as I don't want to see yet another broken release > > just because you decided you can do what you want. > Instead of bothering me with your opinion

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /main rfc1867.c rfc1867.h

2006-07-23 Thread Wez Furlong
Doing unicode from scratch in PDO when I'm ready to do it has always been my intention. Stop moaning about it. --Wez. On 7/22/06, Marcus Boerger <[EMAIL PROTECTED]> wrote: Hello Stefan, well the policy is you commit to HEAD first so that HEAD and base do not get out of synch. For PDO we alr

[PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /main rfc1867.c rfc1867.h

2006-07-23 Thread Wez Furlong
I agree; this upload patch should be reverted. --Wez. On 7/23/06, Derick Rethans <[EMAIL PROTECTED]> wrote: On Sun, 23 Jul 2006, Stefan Esser wrote: > Antony, > > So this is the reason you think you can break the upcoming release now? > > Please revert it, as I don't want to see yet another br

[PHP-CVS] cvs: php-src(PHP_5_2) / README.UPDATE_5_2

2006-07-23 Thread Marcus Boerger
helly Sun Jul 23 18:51:23 2006 UTC Modified files: (Branch: PHP_5_2) /php-srcREADME.UPDATE_5_2 Log: - This was reintroduced by Zeev # I could need help in writing this file. Actually i know why i didn't want # to start it in the first place. http://c

Re: [PHP-CVS] cvs: php-src(PHP_5_2) / README.UPDATE_5_2

2006-07-23 Thread Steph Fox
If someone pokes me before release I'll clean up the English. You just worry about the tech side ;) - Original Message - From: "Marcus Boerger" <[EMAIL PROTECTED]> To: Sent: Sunday, July 23, 2006 8:51 PM Subject: [PHP-CVS] cvs: php-src(PHP_5_2) / README.UPDATE_5_2 helly Sun Jul 23

[PHP-CVS] cvs: php-src /ext/gd/libgd gd.c /ext/gd/tests 38179.phpt

2006-07-23 Thread Pierre-Alain Joye
pajoye Sun Jul 23 21:48:18 2006 UTC Modified files: /php-src/ext/gd/tests 38179.phpt /php-src/ext/gd/libgd gd.c Log: - MFB: #38179, imagecopy, palette to truecolor must use alpha channel too http://cvs.php.net/viewvc.cgi/php-src/ext/gd/tests

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/gd/libgd gd.c /ext/gd/tests 38179.phpt

2006-07-23 Thread Pierre-Alain Joye
pajoye Sun Jul 23 21:41:12 2006 UTC Added files: (Branch: PHP_5_2) /php-src/ext/gd/tests 38179.phpt Modified files: /php-src/ext/gd/libgd gd.c Log: - #38179, imagecopy, palette to truecolor must use alpha channel too http:

[PHP-CVS] cvs: php-src /scripts phpize.in

2006-07-23 Thread Jani Taskinen
sniper Sun Jul 23 23:40:19 2006 UTC Modified files: /php-src/scriptsphpize.in Log: typofix http://cvs.php.net/viewvc.cgi/php-src/scripts/phpize.in?r1=1.32&r2=1.33&diff_format=u Index: php-src/scripts/phpize.in diff -u php-src/scripts/phpize.in:1.32 php-src/

[PHP-CVS] cvs: php-src /ext/sybase_ct php_sybase_ct.c

2006-07-23 Thread Jani Taskinen
sniper Sun Jul 23 23:50:24 2006 UTC Modified files: /php-src/ext/sybase_ct php_sybase_ct.c Log: fix compile failure and remove unnecessary TSRMLS_FETCH calls http://cvs.php.net/viewvc.cgi/php-src/ext/sybase_ct/php_sybase_ct.c?r1=1.112&r2=1.113&diff_format=

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/sybase_ct php_sybase_ct.c

2006-07-23 Thread Jani Taskinen
sniper Sun Jul 23 23:50:43 2006 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/sybase_ct php_sybase_ct.c Log: MFH: fix compile failure and remove unnecessary TSRMLS_FETCH calls http://cvs.php.net/viewvc.cgi/php-src/ext/sybase_ct/php_sybase_ct.c?r1=1.103

[PHP-CVS] cvs: php-src /ext/fdf fdf.c

2006-07-23 Thread Jani Taskinen
sniper Sun Jul 23 23:55:26 2006 UTC Modified files: /php-src/ext/fdffdf.c Log: fix another compile failure. (bjori: TEST before commit!) http://cvs.php.net/viewvc.cgi/php-src/ext/fdf/fdf.c?r1=1.96&r2=1.97&diff_format=u Index: php-src/ext/fdf/fdf.c diff -u p

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/fdf fdf.c

2006-07-23 Thread Jani Taskinen
sniper Sun Jul 23 23:55:46 2006 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/fdffdf.c Log: MFH: cleanup after lazy people http://cvs.php.net/viewvc.cgi/php-src/ext/fdf/fdf.c?r1=1.89.2.2.2.3&r2=1.89.2.2.2.4&diff_format=u Index: php-src/ext/fdf/fdf.c dif

[PHP-CVS] cvs: php-src /ext/pdo_dblib pdo_dblib.c

2006-07-23 Thread Jani Taskinen
sniper Mon Jul 24 00:00:35 2006 UTC Modified files: /php-src/ext/pdo_dblib pdo_dblib.c Log: fix build http://cvs.php.net/viewvc.cgi/php-src/ext/pdo_dblib/pdo_dblib.c?r1=1.13&r2=1.14&diff_format=u Index: php-src/ext/pdo_dblib/pdo_dblib.c diff -u php-src/ext

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/pdo_dblib pdo_dblib.c

2006-07-23 Thread Jani Taskinen
sniper Mon Jul 24 00:01:02 2006 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/pdo_dblib pdo_dblib.c Log: fix build and typo after another lazy ass who does not test before commit: Dmitry http://cvs.php.net/viewvc.cgi/php-src/ext/pdo_dblib/pdo_dblib.c?

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/filter filter.c

2006-07-23 Thread Ilia Alshanetsky
iliaa Mon Jul 24 03:58:41 2006 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/filter filter.c Log: Fixed compiler warning. http://cvs.php.net/viewvc.cgi/php-src/ext/filter/filter.c?r1=1.52.2.6&r2=1.52.2.7&diff_format=u Index: php-src/ext/filter/filter.c

[PHP-CVS] cvs: php-src /ext/filter filter.c

2006-07-23 Thread Ilia Alshanetsky
iliaa Mon Jul 24 03:59:04 2006 UTC Modified files: /php-src/ext/filter filter.c Log: MFB: Fixed compiler warning. http://cvs.php.net/viewvc.cgi/php-src/ext/filter/filter.c?r1=1.58&r2=1.59&diff_format=u Index: php-src/ext/filter/filter.c diff -u php-src/ext/