rasmus Wed, 25 May 2011 19:58:41 +
Revision: http://svn.php.net/viewvc?view=revision&revision=311421
Log:
This isn't in
Changed paths:
U php/php-src/branches/PHP_5_4/NEWS
Modified: php/php-src/branches/PHP_5_4/NEWS
There seem to be a lot of unrelated code cleanup here, and I am in
general a bit confused in this code.
Could you review http://php.net/streamwrapper and write up the changes to it?
-Hannes
On Wed, May 25, 2011 at 23:03, Stanislav Malyshev wrote:
> stas Wed, 2
Hi!
There seem to be a lot of unrelated code cleanup here, and I am in
> general a bit confused in this code.
> Could you review http://php.net/streamwrapper and write up the changes to
> it?
>
>
There shouldn't be any changes except for adding one stream handler (see
rfc: https://wiki.php.net/rfc
hi,
Besides that, did we even approve that change? Gustavo and I were two
that did not like the current implemenation/design.
Cheers,
On Wed, May 25, 2011 at 11:24 PM, Stas Malyshev wrote:
> Hi!
>
> There seem to be a lot of unrelated code cleanup here, and I am in
>> general a bit confused in
Hi!
Besides that, did we even approve that change? Gustavo and I were two
that did not like the current implemenation/design.
There were no objections and/or proposals for improving it since I
posted the patch, which as about 2 months ago, so I assumed it's ok. If
you have any specific ideas
felipe Wed, 25 May 2011 22:23:48 +
Revision: http://svn.php.net/viewvc?view=revision&revision=311423
Log:
- Fixed ZTS build and removed unused vars
Changed paths:
U php/php-src/branches/PHP_5_4/ext/standard/filestat.c
U php/php-src/trunk/ext/stan
On Thu, May 26, 2011 at 12:04 AM, Stas Malyshev wrote:
> Hi!
>
>> Besides that, did we even approve that change? Gustavo and I were two
>> that did not like the current implemenation/design.
>
> There were no objections and/or proposals for improving it since I posted
> the patch, which as about 2
Hi!
No time to actually proper design and propose alternatives yet. That
does mean we have to accept something "just because it is ready".
Sorry
No, I think if we have working solution for a real problem, even if it's
not perfect - it is the reason to use it and "I can vaguely imagine
someth
On Wed, May 25, 2011 at 23:24, Stas Malyshev wrote:
> Hi!
>
>> There seem to be a lot of unrelated code cleanup here, and I am in
>> general a bit confused in this code.
>> Could you review http://php.net/streamwrapper and write up the changes to
>> it?
>>
>
> There shouldn't be any changes except
