[PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ NEWS
rasmus Wed, 25 May 2011 19:58:41 + Revision: http://svn.php.net/viewvc?view=revisionrevision=311421 Log: This isn't in Changed paths: U php/php-src/branches/PHP_5_4/NEWS Modified: php/php-src/branches/PHP_5_4/NEWS === --- php/php-src/branches/PHP_5_4/NEWS 2011-05-25 15:10:03 UTC (rev 311420) +++ php/php-src/branches/PHP_5_4/NEWS 2011-05-25 19:58:41 UTC (rev 311421) @@ -38,7 +38,6 @@ with --enable-zend-multibyte. Now it can be enabled or disabled through zend.multibyte directive in php.ini (Dmitry) . Removed compile time dependency from ext/mbstring (Dmitry) - . Added scalar typehints to the parser and the reflection API. (Ilia, Derick) . Added support for Traits. (Stefan) . Added closure $this support back. (Stas) . Added array dereferencing support. (Felipe) -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/ext/standard/filestat.c branches/PHP_5_4/ext/standard/tests/file/userstreams_007.phpt branches/PHP_5_4/main/php_streams.h branch
There seem to be a lot of unrelated code cleanup here, and I am in general a bit confused in this code. Could you review http://php.net/streamwrapper and write up the changes to it? -Hannes On Wed, May 25, 2011 at 23:03, Stanislav Malyshev s...@php.net wrote: stas Wed, 25 May 2011 21:03:55 + Revision: http://svn.php.net/viewvc?view=revisionrevision=311422 Log: implement streams metadata API per RFC Changed paths: U php/php-src/branches/PHP_5_4/NEWS U php/php-src/branches/PHP_5_4/ext/standard/filestat.c A php/php-src/branches/PHP_5_4/ext/standard/tests/file/userstreams_007.phpt U php/php-src/branches/PHP_5_4/main/php_streams.h U php/php-src/branches/PHP_5_4/main/streams/plain_wrapper.c U php/php-src/branches/PHP_5_4/main/streams/userspace.c U php/php-src/trunk/ext/standard/filestat.c A php/php-src/trunk/ext/standard/tests/file/userstreams_007.phpt U php/php-src/trunk/main/php_streams.h U php/php-src/trunk/main/streams/plain_wrapper.c U php/php-src/trunk/main/streams/userspace.c -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/ext/standard/filestat.c branches/PHP_5_4/ext/standard/tests/file/userstreams_007.phpt branches/PHP_5_4/main/php_streams.h branch
Hi! There seem to be a lot of unrelated code cleanup here, and I am in general a bit confused in this code. Could you review http://php.net/streamwrapper and write up the changes to it? There shouldn't be any changes except for adding one stream handler (see rfc: https://wiki.php.net/rfc/streammetadata) and adding support for it. I'll add docs for it soon.
Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/ext/standard/filestat.c branches/PHP_5_4/ext/standard/tests/file/userstreams_007.phpt branches/PHP_5_4/main/php_streams.h branch
hi, Besides that, did we even approve that change? Gustavo and I were two that did not like the current implemenation/design. Cheers, On Wed, May 25, 2011 at 11:24 PM, Stas Malyshev smalys...@gmail.com wrote: Hi! There seem to be a lot of unrelated code cleanup here, and I am in general a bit confused in this code. Could you review http://php.net/streamwrapper and write up the changes to it? There shouldn't be any changes except for adding one stream handler (see rfc: https://wiki.php.net/rfc/streammetadata) and adding support for it. I'll add docs for it soon. -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/ext/standard/filestat.c branches/PHP_5_4/ext/standard/tests/file/userstreams_007.phpt branches/PHP_5_4/main/php_streams.h branch
Hi! Besides that, did we even approve that change? Gustavo and I were two that did not like the current implemenation/design. There were no objections and/or proposals for improving it since I posted the patch, which as about 2 months ago, so I assumed it's ok. If you have any specific ideas how to improve it, please tell. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227 -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/standard/filestat.c trunk/ext/standard/filestat.c
felipe Wed, 25 May 2011 22:23:48 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=311423
Log:
- Fixed ZTS build and removed unused vars
Changed paths:
U php/php-src/branches/PHP_5_4/ext/standard/filestat.c
U php/php-src/trunk/ext/standard/filestat.c
Modified: php/php-src/branches/PHP_5_4/ext/standard/filestat.c
===
--- php/php-src/branches/PHP_5_4/ext/standard/filestat.c2011-05-25
21:03:55 UTC (rev 311422)
+++ php/php-src/branches/PHP_5_4/ext/standard/filestat.c2011-05-25
22:23:48 UTC (rev 311423)
@@ -526,7 +526,7 @@
char *pwbuf;
if (pwbuflen 1) {
- RETURN_FALSE;
+ return FAILURE;
}
pwbuf = emalloc(pwbuflen);
@@ -666,8 +666,6 @@
wrapper = php_stream_locate_url_wrapper(filename, NULL, 0 TSRMLS_CC);
if(wrapper != php_plain_files_wrapper || strncasecmp(file://,
filename, 7) == 0) {
if(wrapper wrapper-wops-stream_metadata) {
- int option;
- void *value;
if(wrapper-wops-stream_metadata(wrapper, filename,
PHP_STREAM_META_ACCESS, mode, NULL TSRMLS_CC)) {
RETURN_TRUE;
} else {
Modified: php/php-src/trunk/ext/standard/filestat.c
===
--- php/php-src/trunk/ext/standard/filestat.c 2011-05-25 21:03:55 UTC (rev
311422)
+++ php/php-src/trunk/ext/standard/filestat.c 2011-05-25 22:23:48 UTC (rev
311423)
@@ -526,7 +526,7 @@
char *pwbuf;
if (pwbuflen 1) {
- RETURN_FALSE;
+ return FAILURE;
}
pwbuf = emalloc(pwbuflen);
@@ -666,8 +666,6 @@
wrapper = php_stream_locate_url_wrapper(filename, NULL, 0 TSRMLS_CC);
if(wrapper != php_plain_files_wrapper || strncasecmp(file://,
filename, 7) == 0) {
if(wrapper wrapper-wops-stream_metadata) {
- int option;
- void *value;
if(wrapper-wops-stream_metadata(wrapper, filename,
PHP_STREAM_META_ACCESS, mode, NULL TSRMLS_CC)) {
RETURN_TRUE;
} else {
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/ext/standard/filestat.c branches/PHP_5_4/ext/standard/tests/file/userstreams_007.phpt branches/PHP_5_4/main/php_streams.h branch
On Thu, May 26, 2011 at 12:04 AM, Stas Malyshev smalys...@sugarcrm.com wrote: Hi! Besides that, did we even approve that change? Gustavo and I were two that did not like the current implemenation/design. There were no objections and/or proposals for improving it since I posted the patch, which as about 2 months ago, so I assumed it's ok. If you have any specific ideas how to improve it, please tell. No time to actually proper design and propose alternatives yet. That does mean we have to accept something just because it is ready. Sorry -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/ext/standard/filestat.c branches/PHP_5_4/ext/standard/tests/file/userstreams_007.phpt branches/PHP_5_4/main/php_streams.h branch
Hi! No time to actually proper design and propose alternatives yet. That does mean we have to accept something just because it is ready. Sorry No, I think if we have working solution for a real problem, even if it's not perfect - it is the reason to use it and I can vaguely imagine something better but nobody would ever actually do it is not a valid reason to reject it. If there's some real problem - fine, but just because of imaginary better solution that would never happen - I don't think it makes any sense, sorry. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227 -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
