laruence Sun, 07 Aug 2011 11:13:27 +
Revision: http://svn.php.net/viewvc?view=revision&revision=314419
Log:
Initialize variable with fixed value for avoiding compile warnings
Changed paths:
U php/php-src/branches/PHP_5_3/ext/phar/phar.c
U php/php-s
felipe Sun, 07 Aug 2011 13:04:02 +
Revision: http://svn.php.net/viewvc?view=revision&revision=314420
Log:
- Revert r314387
(property_info.name has the mangled name)
Changed paths:
U php/php-src/branches/PHP_5_4/Zend/zend_API.c
U php/php-src/tru
laruence Sun, 07 Aug 2011 13:19:04 +
Revision: http://svn.php.net/viewvc?view=revision&revision=314422
Log:
Fixed bug that may dereferenced NULL pointer before checking
Changed paths:
U php/php-src/branches/PHP_5_3/ext/standard/basic_functions.c
U
On 08/07/2011 05:19 PM, Xinchen Hui wrote:
opts = (opt_struct *) erealloc(opts, sizeof(opt_struct) * (len
+ count + 1));
+ if (!opts) {
+ RETURN_FALSE;
+ }
+
erealloc() cannot return NULL whatever happens and if you look at the
We however have plenty of realloc calls without any checks.
Cheers,
On Sun, Aug 7, 2011 at 3:50 PM, Antony Dovgal wrote:
> On 08/07/2011 05:19 PM, Xinchen Hui wrote:
>>
>> opts = (opt_struct *) erealloc(opts, sizeof(opt_struct) *
>> (len + count + 1));
>> + if (!opts
On 08/07/2011 06:16 PM, Laruence wrote:
Hi:
oh, sorry for mis-understanding,
I will revert these changes.
You can leave it as it is now, I believe.
Just don't waste your time on such checks.
--
Wbr,
Antony Dovgal
---
http://pinba.org - realtime profiling for PHP
--
PHP CVS Mailing L
laruence Sun, 07 Aug 2011 14:25:30 +
Revision: http://svn.php.net/viewvc?view=revision&revision=314425
Log:
revert -r314422
No need to check erealloc's return
Changed paths:
U php/php-src/branches/PHP_5_3/ext/standard/basic_functions.c
U php/php-s
gwynne Sun, 07 Aug 2011 15:07:53 +
Revision: http://svn.php.net/viewvc?view=revision&revision=314431
Log:
Add missing php.h include
Changed paths:
U
php/php-src/branches/PHP_5_4/ext/intl/resourcebundle/resourcebundle_class.h
Modified:
php/php-src/br
gwynne Sun, 07 Aug 2011 15:09:42 +
Revision: http://svn.php.net/viewvc?view=revision&revision=314432
Log:
fix for bug #55019
Bug: https://bugs.php.net/55019 (Assigned) undefined symbol:
grapheme_extract_count_iter in Unknown on line 0
Changed paths:
gwynne Sun, 07 Aug 2011 15:12:34 +
Revision: http://svn.php.net/viewvc?view=revision&revision=314433
Log:
Fixes build issues with ext/intl. This appears to be related to bug #55019, but
since the functions in question are used elsewhere, the solution is to
True, but the problem here is that name may be free'ed at that point. On
line 3355 we have:
property_info.name = (char*)name;
and then on 3365:
if (ce->type == ZEND_USER_CLASS) {
efree(property_info.name);
} else {
free(property_info.name);
rasmus Sun, 07 Aug 2011 15:38:36 +
Revision: http://svn.php.net/viewvc?view=revision&revision=314434
Log:
Make static analyzers happy
Changed paths:
U php/php-src/branches/PHP_5_3/ext/standard/php_crypt_r.c
U php/php-src/branches/PHP_5_4/ext/stan
rasmus Sun, 07 Aug 2011 15:45:18 +
Revision: http://svn.php.net/viewvc?view=revision&revision=314435
Log:
Not an issue here, but a good habit to follow consistently. Never use
strcpy/strcat.
Changed paths:
U php/php-src/branches/PHP_5_3/ext/pdo/php_pd
rasmus Sun, 07 Aug 2011 15:52:46 +
Revision: http://svn.php.net/viewvc?view=revision&revision=314436
Log:
Signed 1-bit bitfields make no sense
Changed paths:
U php/php-src/branches/PHP_5_4/sapi/cli/php_cli_server.c
U php/php-src/trunk/sapi/cli/ph
rasmus Sun, 07 Aug 2011 15:57:35 +
Revision: http://svn.php.net/viewvc?view=revision&revision=314437
Log:
More signed 1-bit bitfields
Changed paths:
U php/php-src/trunk/ext/phar/phar_internal.h
U php/php-src/trunk/sapi/cli/php_cli_server.c
Modif
rasmus Sun, 07 Aug 2011 16:10:34 +
Revision: http://svn.php.net/viewvc?view=revision&revision=314438
Log:
Fix more signed 1-bit bitfield, and let's use strlcpy/strlcat instead for these
static string copies
Changed paths:
U php/php-src/branches/PHP_5_3
gwynne Sun, 07 Aug 2011 16:31:21 +
Revision: http://svn.php.net/viewvc?view=revision&revision=314439
Log:
For 5.4, fix C++-style comments. For trunk, forward-port build fix.
Changed paths:
U php/php-src/branches/PHP_5_4/Zend/zend_operators.h
U ph
gwynne Sun, 07 Aug 2011 17:14:14 +
Revision: http://svn.php.net/viewvc?view=revision&revision=314440
Log:
Back- and front-port fixes for #55019
Bug: https://bugs.php.net/55019 (Closed) undefined symbol:
grapheme_extract_count_iter in Unknown on line 0
gwynne Sun, 07 Aug 2011 17:15:40 +
Revision: http://svn.php.net/viewvc?view=revision&revision=314441
Log:
Front- and back-port rev 314431 (missing php.h include)
Changed paths:
U
php/php-src/branches/PHP_5_3/ext/intl/resourcebundle/resourcebundle_clas
derick Sun, 07 Aug 2011 17:36:31 +
Revision: http://svn.php.net/viewvc?view=revision&revision=314443
Log:
- Fixed bug #55378: binary number literal returns float number though its value
is enough small
Bug: https://bugs.php.net/55378 (Assigned) binary numb
gwynne Sun, 07 Aug 2011 18:12:52 +
Revision: http://svn.php.net/viewvc?view=revision&revision=314445
Log:
possible use without init fixed
Changed paths:
U php/php-src/branches/PHP_5_3/ext/date/php_date.c
U php/php-src/branches/PHP_5_4/ext/date/ph
Hi!
On 8/7/11 8:24 AM, Rasmus Lerdorf wrote:
True, but the problem here is that name may be free'ed at that point. On
line 3355 we have:
property_info.name = (char*)name;
and then on 3365:
if (ce->type == ZEND_USER_CLASS) {
efree(property_info.name);
} e
Hi!
On 8/7/11 7:25 AM, Xinchen Hui wrote:
laruence Sun, 07 Aug 2011 14:25:30 +
memset(opts, 0, count * sizeof(opt_struct));
+ if (!opts) {
+ RETURN_FALSE;
+ }
+
I'm not sure I understand this
On 08/07/2011 01:31 PM, Stas Malyshev wrote:
> Hi!
>
> On 8/7/11 8:24 AM, Rasmus Lerdorf wrote:
>> True, but the problem here is that name may be free'ed at that point. On
>> line 3355 we have:
>>
>> property_info.name = (char*)name;
>>
>> and then on 3365:
>>
>> if (ce->type == ZEND_
iliaaSun, 07 Aug 2011 23:46:00 +
Revision: http://svn.php.net/viewvc?view=revision&revision=314450
Log:
Fixes for variety of issues identified by coverity scan
Changed paths:
U php/php-src/branches/PHP_5_3/ext/pdo/pdo.c
U php/php-src/branches/P
iliaaMon, 08 Aug 2011 00:07:54 +
Revision: http://svn.php.net/viewvc?view=revision&revision=314451
Log:
Avoid strcpy() usage
Changed paths:
U php/php-src/branches/PHP_5_3/ext/pdo/pdo_sql_parser.re
U php/php-src/branches/PHP_5_3/ext/pdo_sqlite/s
laruence Mon, 08 Aug 2011 00:47:40 +
Revision: http://svn.php.net/viewvc?view=revision&revision=314452
Log:
Remove no sense statements
Changed paths:
U php/php-src/branches/PHP_5_3/ext/standard/basic_functions.c
U php/php-src/branches/PHP_5_4/ext/s
Hi:
This was what it was before I edit it. I also don't very sure about it.
and after tracking, I found this statements was introduced in -r243300
diff:
http://svn.php.net/viewvc/php/php-src/trunk/ext/standard/basic_functions.c?r1=243098&r2=243300
looks like it was wrong in the rewr
laruence Mon, 08 Aug 2011 02:33:03 +
Revision: http://svn.php.net/viewvc?view=revision&revision=314456
Log:
Wrong sizeof
Changed paths:
U php/php-src/branches/PHP_5_4/ext/spl/spl_observer.c
U php/php-src/trunk/ext/spl/spl_observer.c
Modified: php/
pierrick Mon, 08 Aug 2011 03:08:59 +
Revision: http://svn.php.net/viewvc?view=revision&revision=314457
Log:
Use snprintf and strncat to make the static analyzers happy
Changed paths:
U php/php-src/branches/PHP_5_3/Zend/zend.c
U php/php-src/branches
laruence Mon, 08 Aug 2011 06:49:17 +
Revision: http://svn.php.net/viewvc?view=revision&revision=314467
Log:
Make codes more clearly, and make the static analyzer silent..
Changed paths:
U php/php-src/branches/PHP_5_4/ext/standard/info.c
U php/php-s
Hi,
might be good to document in Zend/README.ZEND_MM or some similar place?
johannes
On Thu, 2011-07-14 at 12:21 +, Derick Rethans wrote:
> derick Thu, 14 Jul 2011 12:21:15 +
>
> Revision: http://svn.php.net/viewvc?view=revision&revision=313243
>
> Log
32 matches
Mail list logo
