[PHP-CVS] cvs: php4 /ext/standard basic_functions.c basic_functions.h

2002-11-04 Thread Stig Bakken
ssb Tue Nov 5 01:05:49 2002 EDT Modified files: /php4/ext/standard basic_functions.c basic_functions.h Log: Added separate functions for setting include_path, for environments where ini_set has been disabled. New functions: get_include_path(), set_includ

Re: [PHP-CVS] cvs: TSRM / tsrm_virtual_cwd.c

2002-11-04 Thread Andi Gutmans
Looks good except for: if (realpath(path, resolved_path) && use_realpath) { which I think should be: if (use_realpath && realpath(path, resolved_path)) Thanks, Andi At 06:49 PM 11/4/2002 -0500, Ilia A. wrote: I've taken you suggestion about adding an additional parameter to file_ex() to addres

Re: [PHP-CVS] cvs: TSRM / tsrm_virtual_cwd.c

2002-11-04 Thread Ilia A.
I've taken you suggestion about adding an additional parameter to file_ex() to address the symlink situation. Attached is a patch that I believe should resolve the problem. Ilia On November 4, 2002 02:53 pm, Ilia A. wrote: > On November 4, 2002 03:43 am, Andi Gutmans wrote: > > At 02:41 PM 11/4

[PHP-CVS] cvs: php4 /ext/standard link.c TSRM tsrm_virtual_cwd.c tsrm_virtual_cwd.h

2002-11-04 Thread Ilia Alshanetsky
iliaa Mon Nov 4 18:24:15 2002 EDT Modified files: /TSRM tsrm_virtual_cwd.c tsrm_virtual_cwd.h /php4/ext/standard link.c Log: Revert virtual_link() patch. Index: TSRM/tsrm_virtual_cwd.c diff -u TSRM/tsrm_virtual_cwd.c:1.38 TSRM/tsrm_virtual_cwd.

Re: [PHP-CVS] cvs: TSRM / tsrm_virtual_cwd.c

2002-11-04 Thread Ilia A.
Okie, I'll revert the virtual_link completely then right now. Ilia On November 4, 2002 04:36 am, Andi Gutmans wrote: > At 02:53 PM 11/4/2002 -0500, Ilia A. wrote: > >On November 4, 2002 03:43 am, Andi Gutmans wrote: > > > At 02:41 PM 11/4/2002 -0500, Ilia A. wrote: > > > >On November 4, 2002 03:3

[PHP-CVS] cvs: CVSROOT / avail

2002-11-04 Thread Rasmus Lerdorf
rasmus Mon Nov 4 16:32:54 2002 EDT Modified files: /CVSROOTavail Log: pres karma for Alexander Wirtz Index: CVSROOT/avail diff -u CVSROOT/avail:1.529 CVSROOT/avail:1.530 --- CVSROOT/avail:1.529 Mon Nov 4 13:35:12 2002 +++ CVSROOT/avail Mon Nov 4

[PHP-CVS] cvs: php4 /main php_reentrancy.h reentrancy.c

2002-11-04 Thread David Reid
dreid Mon Nov 4 16:20:53 2002 EDT Modified files: /php4/main php_reentrancy.h reentrancy.c Log: Work around a daft mistake in the beos headers... Index: php4/main/php_reentrancy.h diff -u php4/main/php_reentrancy.h:1.16 php4/main/php_reentrancy.h:1.17 ---

[PHP-CVS] cvs: TSRM / tsrm_virtual_cwd.c tsrm_virtual_cwd.h

2002-11-04 Thread Andi Gutmans
andiMon Nov 4 15:45:29 2002 EDT Modified files: /TSRM tsrm_virtual_cwd.c tsrm_virtual_cwd.h Log: - Clean up mess made by netware guys. There's no reason not to abstract - the macro a tiny bit more allowing the code to look cleaner. The more - #ifdef'

Re: [PHP-CVS] cvs: TSRM / tsrm_virtual_cwd.c

2002-11-04 Thread Andi Gutmans
At 02:53 PM 11/4/2002 -0500, Ilia A. wrote: On November 4, 2002 03:43 am, Andi Gutmans wrote: > At 02:41 PM 11/4/2002 -0500, Ilia A. wrote: > >On November 4, 2002 03:36 am, you wrote: > > > I'll check it out tomorrow. Your code is problematic in any case as > > > you're returning a pointer to the

[PHP-CVS] cvs: php4 / configure.in /ext/standard ftok.c

2002-11-04 Thread David Reid
dreid Mon Nov 4 15:08:09 2002 EDT Modified files: /php4 configure.in /php4/ext/standard ftok.c Log: Not all systems have sys/ipc.h so let's check and only include it if we have it. Index: php4/configure.in diff -u php4/configure.in:1.394 php4

Re: [PHP-CVS] cvs: TSRM / tsrm_virtual_cwd.c

2002-11-04 Thread Ilia A.
On November 4, 2002 03:43 am, Andi Gutmans wrote: > At 02:41 PM 11/4/2002 -0500, Ilia A. wrote: > >On November 4, 2002 03:36 am, you wrote: > > > I'll check it out tomorrow. Your code is problematic in any case as > > > you're returning a pointer to the stack which is a no-no in C. > > > I'll see i

Re: [PHP-CVS] cvs: TSRM / tsrm_virtual_cwd.c

2002-11-04 Thread Andi Gutmans
At 02:41 PM 11/4/2002 -0500, Ilia A. wrote: On November 4, 2002 03:36 am, you wrote: > I'll check it out tomorrow. Your code is problematic in any case as you're > returning a pointer to the stack which is a no-no in C. > I'll see if there's a way to do what you need without adding this > virtual_

Re: [PHP-CVS] cvs: TSRM / tsrm_virtual_cwd.c

2002-11-04 Thread Ilia A.
On November 4, 2002 03:36 am, you wrote: > I'll check it out tomorrow. Your code is problematic in any case as you're > returning a pointer to the stack which is a no-no in C. > I'll see if there's a way to do what you need without adding this > virtual_link function. Can you revert it in the meant

Re: [PHP-CVS] cvs: TSRM / tsrm_virtual_cwd.c

2002-11-04 Thread Andi Gutmans
I'll check it out tomorrow. Your code is problematic in any case as you're returning a pointer to the stack which is a no-no in C. I'll see if there's a way to do what you need without adding this virtual_link function. Can you revert it in the meantime? Andi At 02:31 PM 11/4/2002 -0500, Ilia A

Re: [PHP-CVS] cvs: TSRM / tsrm_virtual_cwd.c

2002-11-04 Thread Ilia A.
Certainly. The problem with the old code was quite simple. Suppose we have a file 'original_file' and we make a symlink to it and call it 'my_symlink'. If inside my PHP code I were to do: unlink('my_symlink');, instead of deleting the symlink, the unlink function would remove the original file,

Re: [PHP-CVS] cvs: php4 /tests/lang bug20175.phpt

2002-11-04 Thread Moriyoshi Koizumi
I might be wrong, but I haven't ever heard statics can't be used in regular functions, nor they can only be used in class methods. Although such behaviour is not clarified in the documents, references are explained enough for me to expect that functionality. However I agree the name of the test

Re: [PHP-CVS] cvs: TSRM / tsrm_virtual_cwd.c

2002-11-04 Thread Andi Gutmans
I don't understand what you're doing here. Can you please next time post this kind of stuff before you submit a fix? What is virtual_link()? Do you realize it returns a pointer to the stack when the stack is gone already? Can you please explain what was wrong with the code before you added it? A

[PHP-CVS] cvs: CVSROOT / avail

2002-11-04 Thread Sascha Schumann
sas Mon Nov 4 13:35:12 2002 EDT Modified files: /CVSROOTavail Log: give moh pear karma Index: CVSROOT/avail diff -u CVSROOT/avail:1.528 CVSROOT/avail:1.529 --- CVSROOT/avail:1.528 Mon Nov 4 13:24:45 2002 +++ CVSROOT/avail Mon Nov 4 13:35:12 2

Re: [PHP-CVS] cvs: php4 /tests/lang bug20175.phpt

2002-11-04 Thread Ilia A.
On November 4, 2002 01:22 pm, Marcus Boerger wrote: > What about: http://www.php.net/manual/en/language.references.return.php I see no mention of static here, do you? The documentaion also talks about returning an object, not a regular variable as your example does. The bug #20175 says and I qu

[PHP-CVS] cvs: CVSROOT / avail

2002-11-04 Thread Rasmus Lerdorf
rasmus Mon Nov 4 13:24:45 2002 EDT Modified files: /CVSROOTavail Log: Karma for Harrie and Yuval Index: CVSROOT/avail diff -u CVSROOT/avail:1.527 CVSROOT/avail:1.528 --- CVSROOT/avail:1.527 Sat Nov 2 18:59:32 2002 +++ CVSROOT/avail Mon Nov 4 13

Re: [PHP-CVS] cvs: php4 /tests/lang bug20175.phpt

2002-11-04 Thread Marcus Boerger
What about: http://www.php.net/manual/en/language.references.return.php At 19:19 04.11.2002, Ilia A. wrote: Actually I think bug20175.phpt is a bad test at least the last part. The functionality you are trying to test simply does not exist and has ever existed. I've tested ZE1 and ZE2 and both re

Re: [PHP-CVS] cvs: php4 /tests/lang bug20175.phpt

2002-11-04 Thread Ilia A.
Actually I think bug20175.phpt is a bad test at least the last part. The functionality you are trying to test simply does not exist and has ever existed. I've tested ZE1 and ZE2 and both return wow:2, I've asked people using older PHPs to test this and it did not work on PHP 4.0.6 nor 4.0.4pl1.

[PHP-CVS] cvs: php4 / NEWS

2002-11-04 Thread Marcus Börger
helly Mon Nov 4 13:11:43 2002 EDT Modified files: /php4 NEWS Log: collect and append dba changes Index: php4/NEWS diff -u php4/NEWS:1.1238 php4/NEWS:1.1239 --- php4/NEWS:1.1238Sun Nov 3 12:37:58 2002 +++ php4/NEWS Mon Nov 4 13:11:43 2002 @@ -

[PHP-CVS] cvs: php4 /ext/dba CREDITS config.m4 dba.c dba_cdb.c install_cdb.sh /ext/dba/libcdb .cvsignore cdb.c cdb.h cdb_make.c cdb_make.h uint32.c uint32.h /ext/dba/tests dba_cdb.phpt dba_cdb_make.phpt dba_cdb_read.phpt

2002-11-04 Thread Marcus Börger
helly Mon Nov 4 12:53:05 2002 EDT Added files: /php4/ext/dba/libcdb.cvsignore cdb.c cdb.h cdb_make.c cdb_make.h uint32.c uint32.h /php4/ext/dba/tests dba_cdb_make.phpt Modified files: /php4/ext/db

Re: [PHP-CVS] cvs: php4 /tests/lang bug20175.phpt

2002-11-04 Thread Marcus Boerger
The static variable $wow_value stores a reference to a global variable. Therefor the must not be a second call to wow_static() and hence the value must not change. marcus At 18:25 04.11.2002, Ilia A. wrote: The 2nd wow should be '-wow:2' not 'wow:1'. For me it works in both ZE1 and ZE2 for value

[PHP-CVS] cvs: php4 /ext/standard exec.c

2002-11-04 Thread Ilia Alshanetsky
iliaa Mon Nov 4 12:38:30 2002 EDT Modified files: /php4/ext/standard exec.c Log: Silence compiler warning. Index: php4/ext/standard/exec.c diff -u php4/ext/standard/exec.c:1.83 php4/ext/standard/exec.c:1.84 --- php4/ext/standard/exec.c:1.83 Thu Oct

Re: [PHP-CVS] cvs: php4 /tests/lang bug20175.phpt

2002-11-04 Thread Ilia A.
The 2nd wow should be '-wow:2' not 'wow:1'. For me it works in both ZE1 and ZE2 for value of 2. The value of 2 is correct because the test increments the $wow_global variable twice. Please revert your change. Ilia On November 4, 2002 12:12 pm, Marcus Börger wrote: > helly Mon Nov 4 12

Re: [PHP-CVS] cvs: php4 /tests/lang bug20175.phpt

2002-11-04 Thread Marcus Boerger
Removing \r was good but changing the result was not good.. After correcting the expected result again his fails for ZE2 and passes with ZE1. marcus At 17:46 04.11.2002, Ilia Alshanetsky wrote: iliaa Mon Nov 4 11:46:29 2002 EDT Modified files: /php4/tests/langbug20175.phpt

[PHP-CVS] cvs: php4 /tests/lang bug20175.phpt

2002-11-04 Thread Marcus Börger
helly Mon Nov 4 12:12:22 2002 EDT Modified files: /php4/tests/langbug20175.phpt Log: 2nd wow returns different results with ZE1/ZE2 Index: php4/tests/lang/bug20175.phpt diff -u php4/tests/lang/bug20175.phpt:1.2 php4/tests/lang/bug20175.phpt:1.3 --- php

[PHP-CVS] cvs: php4 /tests/lang bug20175.phpt

2002-11-04 Thread Ilia Alshanetsky
iliaa Mon Nov 4 11:46:29 2002 EDT Modified files: /php4/tests/langbug20175.phpt Log: Removed \r, which caused the test to fail. Index: php4/tests/lang/bug20175.phpt diff -u php4/tests/lang/bug20175.phpt:1.1 php4/tests/lang/bug20175.phpt:1.2 --- php4/te

[PHP-CVS] Fwd: sorry for cluttering

2002-11-04 Thread Melvyn Sopacua
Sometimes the obvious, is actually obvious :-) Delivered-To: [EMAIL PROTECTED] X-Originating-IP: [212.39.78.67] From: "Kostadin Atanasov" <[EMAIL PROTECTED]> To: [EMAIL PROTECTED] Subject: sorry for cluttering Date: Mon, 04 Nov 2002 12:56:28 + X-OriginalArrivalTime: 04 Nov 2002 12:56:28.0652

[PHP-CVS] cvs: php4 /ext/dba dba_db2.c dba_db3.c dba_dbm.c dba_gdbm.c

2002-11-04 Thread Marcus Börger
helly Mon Nov 4 08:39:18 2002 EDT Modified files: /php4/ext/dba dba_db2.c dba_db3.c dba_dbm.c dba_gdbm.c Log: use ecmalloc/efree functions instead of (c|m)alloc/free Index: php4/ext/dba/dba_db2.c diff -u php4/ext/dba/dba_db2.c:1.27 php4/ext/dba/dba_d

[PHP-CVS] cvs: php4 /sapi/apache2filter README

2002-11-04 Thread Sascha Schumann
sas Mon Nov 4 08:22:23 2002 EDT Modified files: /php4/sapi/apache2filterREADME Log: Fix debugging description Index: php4/sapi/apache2filter/README diff -u php4/sapi/apache2filter/README:1.14 php4/sapi/apache2filter/README:1.15 --- php4/sapi/apache2f

Re: [PHP-CVS] cvs: php4 /ext/standard dl.c

2002-11-04 Thread Moriyoshi Koizumi
It's too late to notice this patch doesn't have much meaning... Win32 seems smart enough to handle slashes... Should I revert? Moriyoshi "Moriyoshi Koizumi" <[EMAIL PROTECTED]> wrote: > moriyoshi Mon Nov 4 07:53:24 2002 EDT > > Modified files: > /php4/ext/stand

[PHP-CVS] cvs: php4 /ext/standard dl.c

2002-11-04 Thread Moriyoshi Koizumi
moriyoshi Mon Nov 4 07:53:24 2002 EDT Modified files: /php4/ext/standard dl.c Log: Fixed bug #20243 Index: php4/ext/standard/dl.c diff -u php4/ext/standard/dl.c:1.78 php4/ext/standard/dl.c:1.79 --- php4/ext/standard/dl.c:1.78 Thu Oct 24 10:12:06 2002

[PHP-CVS] cvs: php4 /ext/dba dba.c dba_db2.c dba_db3.c php_dba.h

2002-11-04 Thread Marcus Börger
helly Mon Nov 4 07:27:13 2002 EDT Modified files: /php4/ext/dba dba.c dba_db2.c dba_db3.c php_dba.h Log: passing around TSRM #going to add CDB_MAKE support Index: php4/ext/dba/dba.c diff -u php4/ext/dba/dba.c:1.48 php4/ext/dba/dba.c:1.49 --- php4/e

[PHP-CVS] cvs: php4 /tests/lang bug20175.phpt

2002-11-04 Thread Marcus Börger
helly Mon Nov 4 05:51:08 2002 EDT Added files: /php4/tests/langbug20175.phpt Log: See http://bugs.php.net/20175 Index: php4/tests/lang/bug20175.phpt +++ php4/tests/lang/bug20175.phpt --TEST-- Bug #20175 (Static vars can't store ref to new instance)

[PHP-CVS] cvs: php4 / run-tests.php

2002-11-04 Thread Marcus Börger
helly Mon Nov 4 05:45:41 2002 EDT Modified files: /php4 run-tests.php Log: move the run-test tests to the top #if one of these fails there is no need for further testing Index: php4/run-tests.php diff -u php4/run-tests.php:1.116 php4/run-tests.php:

[PHP-CVS] cvs: php4 /tests dirname.phpt /tests/run-test test001.phpt test002.phpt test003.phpt test004.phpt test005.phpt test006.phpt test007.phpt

2002-11-04 Thread Marcus Börger
helly Mon Nov 4 05:43:22 2002 EDT Added files: /php4/tests/run-testtest001.phpt test002.phpt test003.phpt test004.phpt test005.phpt test006.phpt test007.phpt Removed files:

[PHP-CVS] cvs: php4 / run-tests.php

2002-11-04 Thread Marcus Börger
helly Mon Nov 4 05:09:42 2002 EDT Modified files: /php4 run-tests.php Log: sort them Index: php4/run-tests.php diff -u php4/run-tests.php:1.115 php4/run-tests.php:1.116 --- php4/run-tests.php:1.115Sun Nov 3 15:28:35 2002 +++ php4/run-tests.php