[PHP-CVS] cvs: php4(PHP_4_3) / run-tests.php

2003-04-02 Thread Marcus Boerger
helly Wed Apr 2 03:34:57 2003 EDT Modified files: (Branch: PHP_4_3) /php4 run-tests.php Log: MFH 'auto' Index: php4/run-tests.php diff -u php4/run-tests.php:1.119.2.20 php4/run-tests.php:1.119.2.21 --- php4/run-tests.php:1.119.2.20 Fri Mar 28

[PHP-CVS] cvs: php4(PHP_4_3) /ext/domxml php_domxml.c

2003-04-02 Thread Christian Stocker
chregu Wed Apr 2 05:30:06 2003 EDT Modified files: (Branch: PHP_4_3) /php4/ext/domxmlphp_domxml.c Log: Patch for Bug #22774 by Rob Richards Index: php4/ext/domxml/php_domxml.c diff -u php4/ext/domxml/php_domxml.c:1.218.2.12

[PHP-CVS] cvs: php4 /ext/domxml php_domxml.c

2003-04-02 Thread Christian Stocker
chregu Wed Apr 2 05:31:33 2003 EDT Modified files: /php4/ext/domxmlphp_domxml.c Log: Patch for Bug #22774 by Rob Richards Index: php4/ext/domxml/php_domxml.c diff -u php4/ext/domxml/php_domxml.c:1.241 php4/ext/domxml/php_domxml.c:1.242 ---

[PHP-CVS] cvs: php4(PHP_4_3) /ext/curl curl.c

2003-04-02 Thread Jani Taskinen
sniper Wed Apr 2 06:42:16 2003 EDT Modified files: (Branch: PHP_4_3) /php4/ext/curl curl.c Log: MFH. (See bug #21995) Index: php4/ext/curl/curl.c diff -u php4/ext/curl/curl.c:1.124.2.6 php4/ext/curl/curl.c:1.124.2.7 --- php4/ext/curl/curl.c:1.124.2.6

[PHP-CVS] cvs: php4 /ext/ldap ldap.dsp

2003-04-02 Thread Edin Kadribasic
edink Wed Apr 2 07:36:03 2003 EDT Modified files: /php4/ext/ldap ldap.dsp Log: Fixed bug #23008 Index: php4/ext/ldap/ldap.dsp diff -u php4/ext/ldap/ldap.dsp:1.11 php4/ext/ldap/ldap.dsp:1.12 --- php4/ext/ldap/ldap.dsp:1.11 Tue Nov 5 09:19:22 2002 +++

[PHP-CVS] cvs: php4(PHP_4_3) /ext/ldap ldap.dsp

2003-04-02 Thread Edin Kadribasic
edink Wed Apr 2 07:36:36 2003 EDT Modified files: (Branch: PHP_4_3) /php4/ext/ldap ldap.dsp Log: MFH Index: php4/ext/ldap/ldap.dsp diff -u php4/ext/ldap/ldap.dsp:1.11 php4/ext/ldap/ldap.dsp:1.11.2.1 --- php4/ext/ldap/ldap.dsp:1.11 Tue Nov 5 09:19:22 2002

[PHP-CVS] cvs: php4 /main logos.h

2003-04-02 Thread Colin Viebrock
cmv Wed Apr 2 10:36:34 2003 EDT Modified files: /php4/main logos.h Log: fix logo (outline around letters) Index: php4/main/logos.h diff -u php4/main/logos.h:1.7 php4/main/logos.h:1.8 --- php4/main/logos.h:1.7 Wed Feb 19 03:40:18 2003 +++

[PHP-CVS] cvs: php4 /ext/standard basic_functions.c info.c info.h

2003-04-02 Thread Colin Viebrock
cmv Wed Apr 2 11:51:40 2003 EDT Modified files: /php4/ext/standard basic_functions.c info.h info.c Log: fixes for logo guid functions Index: php4/ext/standard/basic_functions.c diff -u php4/ext/standard/basic_functions.c:1.600

[PHP-CVS] cvs: php4 /ext/curl multi.c ZendEngine2 zend_list.c zend_list.h

2003-04-02 Thread Sterling Hughes
sterlingWed Apr 2 11:58:52 2003 EDT Modified files: /ZendEngine2zend_list.c zend_list.h /php4/ext/curl multi.c Log: add the ability for curl_multi_info to introspect the handles. # Zend commit doesn't break anything, so I'm

Re: [PHP-CVS] cvs: php4 /ext/curl multi.c ZendEngine2 zend_list.czend_list.h

2003-04-02 Thread Derick Rethans
On Wed, 2 Apr 2003, Sterling Hughes wrote: sterling Wed Apr 2 11:58:52 2003 EDT Modified files: /ZendEngine2 zend_list.c zend_list.h /php4/ext/curlmulti.c Log: add the ability for curl_multi_info to introspect the handles. # Zend

[PHP-CVS] cvs: php4(PHP_4_3) / NEWS

2003-04-02 Thread Jani Taskinen
sniper Wed Apr 2 12:35:23 2003 EDT Modified files: (Branch: PHP_4_3) /php4 NEWS Log: BFN Index: php4/NEWS diff -u php4/NEWS:1.1247.2.158 php4/NEWS:1.1247.2.159 --- php4/NEWS:1.1247.2.158 Wed Apr 2 07:38:43 2003 +++ php4/NEWS Wed Apr 2 12:35:23

Re: [PHP-CVS] cvs: php4 /ext/curl multi.c ZendEngine2 zend_list.c zend_list.h

2003-04-02 Thread Andi Gutmans
I didn't quite understand what you did here. Can you please explain? Is it absolutely necessary to add this hack just for curl? Andi At 04:58 PM 4/2/2003 +, Sterling Hughes wrote: sterlingWed Apr 2 11:58:52 2003 EDT Modified files: /ZendEngine2zend_list.c

Re: [PHP-CVS] cvs: php4 /ext/curl multi.c ZendEngine2 zend_list.c zend_list.h

2003-04-02 Thread Sterling Hughes
I didn't quite understand what you did here. Can you please explain? Is it absolutely necessary to add this hack just for curl? I added the ability to find a resource identifier from a resource. Something I think is generally pretty useful. :) Adding an ID field to the list_entry isn't

[PHP-CVS] cvs: php4 /sapi/apache .cvsignore

2003-04-02 Thread Derick Rethans
derick Wed Apr 2 13:39:11 2003 EDT Modified files: /php4/sapi/apache .cvsignore Log: - Update for new name Index: php4/sapi/apache/.cvsignore diff -u php4/sapi/apache/.cvsignore:1.8 php4/sapi/apache/.cvsignore:1.9 --- php4/sapi/apache/.cvsignore:1.8 Sat

Re: [PHP-CVS] cvs: php4 /ext/curl multi.c ZendEngine2 zend_list.c zend_list.h

2003-04-02 Thread Andi Gutmans
At 01:21 PM 4/2/2003 -0500, Sterling Hughes wrote: I didn't quite understand what you did here. Can you please explain? Is it absolutely necessary to add this hack just for curl? I added the ability to find a resource identifier from a resource. Something I think is generally pretty useful. :)

[PHP-CVS] cvs: CVSROOT / avail

2003-04-02 Thread Stig Bakken
ssb Wed Apr 2 15:35:22 2003 EDT Modified files: /CVSROOTavail Log: * pajoye += php4/pear Index: CVSROOT/avail diff -u CVSROOT/avail:1.628 CVSROOT/avail:1.629 --- CVSROOT/avail:1.628 Mon Mar 31 12:38:30 2003 +++ CVSROOT/avail Wed Apr 2

[PHP-CVS] cvs: php4 / configure.in

2003-04-02 Thread Marcus Boerger
helly Wed Apr 2 16:17:16 2003 EDT Modified files: /php4 configure.in Log: For now only bison 1.28, 1.35 and 1.75 are working properly Index: php4/configure.in diff -u php4/configure.in:1.437 php4/configure.in:1.438 --- php4/configure.in:1.437 Tue

[PHP-CVS] cvs: php4(PHP_4_3) / TODO_SEGFAULTS /ext/standard string.c

2003-04-02 Thread Rasmus Lerdorf
rasmus Wed Apr 2 16:31:52 2003 EDT Modified files: (Branch: PHP_4_3) /php4 TODO_SEGFAULTS /php4/ext/standard string.c Log: Fix the setlocale() segfault Index: php4/TODO_SEGFAULTS diff -u php4/TODO_SEGFAULTS:1.1.2.8 php4/TODO_SEGFAULTS:1.1.2.9

[PHP-CVS] cvs: php4 /ext/standard string.c

2003-04-02 Thread Rasmus Lerdorf
rasmus Wed Apr 2 16:33:03 2003 EDT Modified files: /php4/ext/standard string.c Log: MFB: Fix the setlocale() segfault Index: php4/ext/standard/string.c diff -u php4/ext/standard/string.c:1.368 php4/ext/standard/string.c:1.369 ---

[PHP-CVS] cvs: php4(PHP_4_3) /ext/exif exif.c

2003-04-02 Thread Rasmus Lerdorf
rasmus Wed Apr 2 17:06:47 2003 EDT Modified files: (Branch: PHP_4_3) /php4/ext/exif exif.c Log: Get rid of bogus dtors Index: php4/ext/exif/exif.c diff -u php4/ext/exif/exif.c:1.118.2.14 php4/ext/exif/exif.c:1.118.2.15 ---

[PHP-CVS] cvs: php4 /ext/exif exif.c

2003-04-02 Thread Rasmus Lerdorf
rasmus Wed Apr 2 17:07:22 2003 EDT Modified files: /php4/ext/exif exif.c Log: MFB: Get rid of bogus dtors Index: php4/ext/exif/exif.c diff -u php4/ext/exif/exif.c:1.141 php4/ext/exif/exif.c:1.142 --- php4/ext/exif/exif.c:1.141 Tue Apr 1 13:50:31

[PHP-CVS] cvs: php4 /ext/mysqli/tests 028.phpt 042.phpt

2003-04-02 Thread Georg Richter
georg Wed Apr 2 17:07:28 2003 EDT Modified files: /php4/ext/mysqli/tests 028.phpt 042.phpt Log: fixed expected output Index: php4/ext/mysqli/tests/028.phpt diff -u php4/ext/mysqli/tests/028.phpt:1.1 php4/ext/mysqli/tests/028.phpt:1.2 ---

[PHP-CVS] cvs: php4(PHP_4_3) / TODO_SEGFAULTS /ext/standard basic_functions.c

2003-04-02 Thread Rasmus Lerdorf
rasmus Wed Apr 2 18:09:39 2003 EDT Modified files: (Branch: PHP_4_3) /php4 TODO_SEGFAULTS /php4/ext/standard basic_functions.c Log: Fix unregister_tick_function crash Index: php4/TODO_SEGFAULTS diff -u php4/TODO_SEGFAULTS:1.1.2.9

[PHP-CVS] cvs: php4 /ext/standard basic_functions.c

2003-04-02 Thread Rasmus Lerdorf
rasmus Wed Apr 2 18:11:31 2003 EDT Modified files: /php4/ext/standard basic_functions.c Log: MFB: Fix unregister_tick_function crash Index: php4/ext/standard/basic_functions.c diff -u php4/ext/standard/basic_functions.c:1.601

[PHP-CVS] cvs: php4(PHP_4_3) / TODO_SEGFAULTS /ext/bcmath bcmath.c

2003-04-02 Thread Rasmus Lerdorf
rasmus Wed Apr 2 18:50:41 2003 EDT Modified files: (Branch: PHP_4_3) /php4 TODO_SEGFAULTS /php4/ext/bcmathbcmath.c Log: Negative precision makes no sense, so check for that, but let the memory manager error out on huge non-negative precision args

[PHP-CVS] cvs: php4 /ext/bcmath bcmath.c

2003-04-02 Thread Rasmus Lerdorf
rasmus Wed Apr 2 18:51:52 2003 EDT Modified files: /php4/ext/bcmathbcmath.c Log: MFB: Check for negative precision Index: php4/ext/bcmath/bcmath.c diff -u php4/ext/bcmath/bcmath.c:1.52 php4/ext/bcmath/bcmath.c:1.53 --- php4/ext/bcmath/bcmath.c:1.52

[PHP-CVS] cvs: php4 /ext/mbstring php_mbregex.c

2003-04-02 Thread Moriyoshi Koizumi
moriyoshi Wed Apr 2 19:01:44 2003 EDT Modified files: /php4/ext/mbstring php_mbregex.c Log: Fixed lots of crashes in mbregex. # most of them were caused by stupid mistakes Index: php4/ext/mbstring/php_mbregex.c diff -u

[PHP-CVS] cvs: php4(PHP_4_3) /ext/mbstring php_mbregex.c

2003-04-02 Thread Moriyoshi Koizumi
moriyoshi Wed Apr 2 19:05:01 2003 EDT Modified files: (Branch: PHP_4_3) /php4/ext/mbstring php_mbregex.c Log: MFH(r-1.37): fixed lots of crashes in mbregex Index: php4/ext/mbstring/php_mbregex.c diff -u php4/ext/mbstring/php_mbregex.c:1.18.2.5

[PHP-CVS] cvs: php4 /ext/mbstring php_mbregex.c

2003-04-02 Thread Moriyoshi Koizumi
moriyoshi Wed Apr 2 19:15:13 2003 EDT Modified files: /php4/ext/mbstring php_mbregex.c Log: Fixed segfault in mb_ereg_match() Index: php4/ext/mbstring/php_mbregex.c diff -u php4/ext/mbstring/php_mbregex.c:1.37 php4/ext/mbstring/php_mbregex.c:1.38 ---

[PHP-CVS] cvs: php4(PHP_4_3) /ext/mbstring php_mbregex.c

2003-04-02 Thread Moriyoshi Koizumi
moriyoshi Wed Apr 2 19:15:58 2003 EDT Modified files: (Branch: PHP_4_3) /php4/ext/mbstring php_mbregex.c Log: MFH(r-1.38): fixed segfault in mb_ereg_match() Index: php4/ext/mbstring/php_mbregex.c diff -u php4/ext/mbstring/php_mbregex.c:1.18.2.6

[PHP-CVS] cvs: php4(PHP_4_3) / TODO_SEGFAULTS

2003-04-02 Thread Rasmus Lerdorf
rasmus Wed Apr 2 19:16:51 2003 EDT Modified files: (Branch: PHP_4_3) /php4 TODO_SEGFAULTS Log: Update Index: php4/TODO_SEGFAULTS diff -u php4/TODO_SEGFAULTS:1.1.2.11 php4/TODO_SEGFAULTS:1.1.2.12 --- php4/TODO_SEGFAULTS:1.1.2.11Wed Apr 2

[PHP-CVS] cvs: php4(PHP_4_3) / TODO_SEGFAULTS

2003-04-02 Thread Moriyoshi Koizumi
moriyoshi Wed Apr 2 19:20:15 2003 EDT Modified files: (Branch: PHP_4_3) /php4 TODO_SEGFAULTS Log: Removed i18n_convert() from the entries because that is an alias for mb_convert_encoding() Index: php4/TODO_SEGFAULTS diff -u

[PHP-CVS] cvs: php4 /main output.c

2003-04-02 Thread Moriyoshi Koizumi
moriyoshi Wed Apr 2 19:50:17 2003 EDT Modified files: /php4/main output.c Log: Fixed memleak in output buffering facility Index: php4/main/output.c diff -u php4/main/output.c:1.151 php4/main/output.c:1.152 --- php4/main/output.c:1.151Tue Apr 1

[PHP-CVS] cvs: php4(PHP_4_3) /main output.c

2003-04-02 Thread Moriyoshi Koizumi
moriyoshi Wed Apr 2 19:51:14 2003 EDT Modified files: (Branch: PHP_4_3) /php4/main output.c Log: MFH(r-1.152): fixed memleak in output buffering facility Index: php4/main/output.c diff -u php4/main/output.c:1.142.2.7 php4/main/output.c:1.142.2.8 ---

[PHP-CVS] cvs: php4(PHP_4_3) /ext/ftp php_ftp.c

2003-04-02 Thread Ilia Alshanetsky
iliaa Wed Apr 2 19:55:45 2003 EDT Modified files: (Branch: PHP_4_3) /php4/ext/ftp php_ftp.c Log: Fixed bug #23004 (When ftp_close() is called, sent QUIT to the ftp server) Index: php4/ext/ftp/php_ftp.c diff -u php4/ext/ftp/php_ftp.c:1.74.2.6

[PHP-CVS] cvs: php4 /ext/ftp php_ftp.c

2003-04-02 Thread Ilia Alshanetsky
iliaa Wed Apr 2 19:55:56 2003 EDT Modified files: /php4/ext/ftp php_ftp.c Log: MFH Index: php4/ext/ftp/php_ftp.c diff -u php4/ext/ftp/php_ftp.c:1.86 php4/ext/ftp/php_ftp.c:1.87 --- php4/ext/ftp/php_ftp.c:1.86 Mon Mar 10 10:52:10 2003 +++

[PHP-CVS] cvs: php4 /ext/xml xml.c

2003-04-02 Thread Moriyoshi Koizumi
moriyoshi Wed Apr 2 20:00:46 2003 EDT Modified files: /php4/ext/xml xml.c Log: Fixed segfault in xml_parser_create() # due to too many %s in printf spec Index: php4/ext/xml/xml.c diff -u php4/ext/xml/xml.c:1.116 php4/ext/xml/xml.c:1.117 ---

[PHP-CVS] cvs: php4(PHP_4_3) /ext/xml xml.c

2003-04-02 Thread Moriyoshi Koizumi
moriyoshi Wed Apr 2 20:01:09 2003 EDT Modified files: (Branch: PHP_4_3) /php4/ext/xml xml.c Log: MFH(r-1.117): fixed segfault in xml_parser_create() Index: php4/ext/xml/xml.c diff -u php4/ext/xml/xml.c:1.110.2.2 php4/ext/xml/xml.c:1.110.2.3 ---

[PHP-CVS] cvs: php4(PHP_4_3) / TODO_SEGFAULTS

2003-04-02 Thread Moriyoshi Koizumi
moriyoshi Wed Apr 2 20:01:35 2003 EDT Modified files: (Branch: PHP_4_3) /php4 TODO_SEGFAULTS Log: segfault busting news Index: php4/TODO_SEGFAULTS diff -u php4/TODO_SEGFAULTS:1.1.2.13 php4/TODO_SEGFAULTS:1.1.2.14 --- php4/TODO_SEGFAULTS:1.1.2.13

[PHP-CVS] cvs: php4(PHP_4_3) / TODO_SEGFAULTS

2003-04-02 Thread Moriyoshi Koizumi
moriyoshi Wed Apr 2 20:04:13 2003 EDT Modified files: (Branch: PHP_4_3) /php4 TODO_SEGFAULTS Log: Unable to reproduce.. Index: php4/TODO_SEGFAULTS diff -u php4/TODO_SEGFAULTS:1.1.2.14 php4/TODO_SEGFAULTS:1.1.2.15 --- php4/TODO_SEGFAULTS:1.1.2.14

[PHP-CVS] cvs: php4 /ext/standard basic_functions.c

2003-04-02 Thread Jani Taskinen
sniper Wed Apr 2 20:12:47 2003 EDT Modified files: /php4/ext/standard basic_functions.c Log: CS fix Index: php4/ext/standard/basic_functions.c diff -u php4/ext/standard/basic_functions.c:1.602 php4/ext/standard/basic_functions.c:1.603 ---

[PHP-CVS] cvs: php4 /ext/bcmath bcmath.c

2003-04-02 Thread Jani Taskinen
sniper Wed Apr 2 20:16:34 2003 EDT Modified files: /php4/ext/bcmathbcmath.c Log: Another CS fix. # Rasmus, at least try keep the style consistent.. Index: php4/ext/bcmath/bcmath.c diff -u php4/ext/bcmath/bcmath.c:1.53 php4/ext/bcmath/bcmath.c:1.54

Re: [PHP-CVS] cvs: php4 /ext/bcmath bcmath.c

2003-04-02 Thread Rasmus Lerdorf
Oh, give me a break Jani. A space here or there makes absolutely no difference to the readability of the code, but all these whitespace commits get in the way of any real work when trying to track down problems via cvs diffs. On Thu, 3 Apr 2003, Jani Taskinen wrote: sniperWed

Re: [PHP-CVS] cvs: php4 /ext/exif exif.c

2003-04-02 Thread Andi Gutmans
I don't have time to look through this in a thorough way but I think it could leak now. Maybe it's best if you move this function to getParameters() and convert_to_string() w/o _ex. Andi At 10:07 PM 4/2/2003 +, Rasmus Lerdorf wrote: rasmus Wed Apr 2 17:07:22 2003 EDT Modified

Re: [PHP-CVS] cvs: php4 /ext/bcmath bcmath.c

2003-04-02 Thread Andi Gutmans
I agree with him. We have standards and people have worked hard to indent the source code in a consistent manner (especially people like Jani). It doesn't take more time to indent nicely. Andi At 06:54 PM 4/2/2003 -0800, Rasmus Lerdorf wrote: Oh, give me a break Jani. A space here or there

[PHP-CVS] cvs: php4(PHP_4_3) /ext/standard string.c

2003-04-02 Thread Derick Rethans
derick Thu Apr 3 01:21:21 2003 EDT Modified files: (Branch: PHP_4_3) /php4/ext/standard string.c Log: - CS Index: php4/ext/standard/string.c diff -u php4/ext/standard/string.c:1.333.2.20 php4/ext/standard/string.c:1.333.2.21 ---

[PHP-CVS] cvs: php4 /ext/standard string.c

2003-04-02 Thread Derick Rethans
derick Thu Apr 3 01:21:59 2003 EDT Modified files: /php4/ext/standard string.c Log: - CS Index: php4/ext/standard/string.c diff -u php4/ext/standard/string.c:1.369 php4/ext/standard/string.c:1.370 --- php4/ext/standard/string.c:1.369Wed Apr 2 16:33:02

Re: [PHP-CVS] cvs: php4 /ext/bcmath bcmath.c

2003-04-02 Thread Rasmus Lerdorf
There was nothing wrong with the indentation. He changed ab to a b and minor things like that. That's just cvs noise. On Thu, 3 Apr 2003, Andi Gutmans wrote: I agree with him. We have standards and people have worked hard to indent the source code in a consistent manner (especially people

Re: [PHP-CVS] cvs: php4 /ext/bcmath bcmath.c

2003-04-02 Thread Derick Rethans
On Wed, 2 Apr 2003, Rasmus Lerdorf wrote: There was nothing wrong with the indentation. He changed ab to a b and minor things like that. That's just cvs noise. But it's still coding style :) Also, this is not noise IMO: - if(bc_precision0) bc_precision=0; + + if

Re: [PHP-CVS] cvs: php4 /ext/bcmath bcmath.c

2003-04-02 Thread Rasmus Lerdorf
On Thu, 3 Apr 2003, Derick Rethans wrote: On Wed, 2 Apr 2003, Rasmus Lerdorf wrote: There was nothing wrong with the indentation. He changed ab to a b and minor things like that. That's just cvs noise. But it's still coding style :) Do a grep through the code. There are literally

Re: [PHP-CVS] cvs: php4 /ext/bcmath bcmath.c

2003-04-02 Thread Jon Parise
On Wed, Apr 02, 2003 at 11:48:55PM -0800, Rasmus Lerdorf wrote: Also, this is not noise IMO: - if(bc_precision0) bc_precision=0; + + if (bc_precision 0) { + bc_precision = 0; + } Well, perhaps. I certainly agree that: