Re: [PHP-CVS] Re: cvs: php-src /ext/pdo pdo_sql_parser.c pdo_sql_parser.re /ext/pdo/tests bug_43130.phpt
On 16.11.2007, at 14:21, Ilia Alshanetsky wrote: I don't see why PDO should follow oracle's rules for generic functionality. I think current implementation is good as is. 1) its a BC break that can affect any user 2) this can break queries for Oracle users porting to PDO in a very non obvious way 3) the benefit of change are close to zero Given that PDO wants to be this thin layer that unifies the client API and only wants to provide some basic emulation, you are diverging quite far from this mantra for a simple convinience feature that does considerable harm. regards, Lukas -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] cvs: php-src / README.CVS-RULES
lsmith Sat Nov 24 13:52:19 2007 UTC Modified files: /php-srcREADME.CVS-RULES Log: - 5.2 is only for bug fixes - emphasis should be made with enclosing with ** and not with _ http://cvs.php.net/viewvc.cgi/php-src/README.CVS-RULES?r1=1.22r2=1.23diff_format=u Index: php-src/README.CVS-RULES diff -u php-src/README.CVS-RULES:1.22 php-src/README.CVS-RULES:1.23 --- php-src/README.CVS-RULES:1.22 Thu Nov 22 18:12:07 2007 +++ php-src/README.CVS-RULESSat Nov 24 13:52:19 2007 @@ -48,9 +48,8 @@ PHP_5_3 Is used to release the PHP 5.3.x series. It still allows for larger enhancements. - PHP_5_2 Is used to release the PHP 5.2.x series. Only minor feature - enhancements may go in here, but please keep that as infrequent as - possible. + PHP_5_2 Is used to release the PHP 5.2.x series. Only bugfixes are permitted + on this branch (Consult the releasemaster prior to commit). PHP_5_1 This branch is closed. @@ -95,7 +94,7 @@ in the ChangeLog. Everything else goes into the ChangeLog. It is important to note that if your comment or news logline spans multiple -lines, you have to put # at the beginning of _every_ such line. +lines, you have to put # at the beginning of **every** such line. Example. Say you modified two files, datetime.c and string.c. In datetime.c you added a new format option for the date() function, and in string.c you fixed a -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] cvs: php-src(PHP_5_3) / README.CVS-RULES
lsmith Sat Nov 24 13:52:29 2007 UTC Modified files: (Branch: PHP_5_3) /php-srcREADME.CVS-RULES Log: - MFH http://cvs.php.net/viewvc.cgi/php-src/README.CVS-RULES?r1=1.18.2.1.2.2.2.1r2=1.18.2.1.2.2.2.2diff_format=u Index: php-src/README.CVS-RULES diff -u php-src/README.CVS-RULES:1.18.2.1.2.2.2.1 php-src/README.CVS-RULES:1.18.2.1.2.2.2.2 --- php-src/README.CVS-RULES:1.18.2.1.2.2.2.1 Thu Nov 22 18:13:05 2007 +++ php-src/README.CVS-RULESSat Nov 24 13:52:29 2007 @@ -48,9 +48,8 @@ PHP_5_3 Is used to release the PHP 5.3.x series. It still allows for larger enhancements. - PHP_5_2 Is used to release the PHP 5.2.x series. Only minor feature - enhancements may go in here, but please keep that as infrequent as - possible. + PHP_5_2 Is used to release the PHP 5.2.x series. Only bugfixes are permitted + on this branch (Consult the releasemaster prior to commit). PHP_5_1 This branch is closed. @@ -95,7 +94,7 @@ in the ChangeLog. Everything else goes into the ChangeLog. It is important to note that if your comment or news logline spans multiple -lines, you have to put # at the beginning of _every_ such line. +lines, you have to put # at the beginning of **every** such line. Example. Say you modified two files, datetime.c and string.c. In datetime.c you added a new format option for the date() function, and in string.c you fixed a -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] cvs: php-src(PHP_5_3) / CODING_STANDARDS
lsmith Sat Nov 24 13:55:27 2007 UTC Modified files: (Branch: PHP_5_3) /php-srcCODING_STANDARDS Log: - MFH http://cvs.php.net/viewvc.cgi/php-src/CODING_STANDARDS?r1=1.32.4.3.2.1.2.2r2=1.32.4.3.2.1.2.3diff_format=u Index: php-src/CODING_STANDARDS diff -u php-src/CODING_STANDARDS:1.32.4.3.2.1.2.2 php-src/CODING_STANDARDS:1.32.4.3.2.1.2.3 --- php-src/CODING_STANDARDS:1.32.4.3.2.1.2.2 Sun Nov 11 22:12:06 2007 +++ php-src/CODING_STANDARDSSat Nov 24 13:55:27 2007 @@ -16,7 +16,7 @@ 1. Functions that are given pointers to resources should not free them -For instance, function int mail(char *to, char *from) should NOT free +For instance, ``function int mail(char *to, char *from)`` should NOT free to and/or from. Exceptions: -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
