[PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-02-01 Thread Boris Lytochkin
lytboris Tue, 01 Feb 2011 08:20:13 + Revision: http://svn.php.net/viewvc?view=revisionrevision=307898 Log: preprocessed changes made in rev.307894: keeping ext/snmp backwards compatible Changed paths: U php/php-src/trunk/ext/snmp/snmp.c Modified:

Re: [PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-02-01 Thread Pierre Joye
hi, I wonder why you need that as we don't release snmp outside php. I would suggest to either drop these backward compatible checks (cleaner code) or consider to do release through pecl as well and then these checks make sense. Cheers, On Tue, Feb 1, 2011 at 9:20 AM, Boris Lytochkin

Re: [PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-02-01 Thread Lytochkin Boris
Hi. I use this module in my production Cacti environment, which uses 5.2 branch. As I use FreeBSD, I'm able to build snmp extension separately from base php as .so module and I use this possibility :) As long as Cacti would need 5.2 to run I will mantain those ugly checks (I believe this legacy

Re: [PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-02-01 Thread Pierre Joye
yes, but this branch is trunk and is not supposed to be 5.2 compatible. If you want to get it out with previous versions support, then go through pecl as well. But without such external releases it will just clutter the codes. Cheers, On Tue, Feb 1, 2011 at 9:51 AM, Lytochkin Boris

Re: [PHP-CVS] svn: /php/php-src/trunk/ext/mysqlnd/ mysqlnd_auth.c

2011-02-01 Thread Pierre Joye
On Mon, Jan 31, 2011 at 3:55 PM, Andrey Hristov p...@hristov.com wrote: this will return emalloc-ed memory, right? Later this memory will be freed with free() and guess what happens :) Is it used outside php? if not then it is a documentation matter no? returned value has to be freed using

Re: [PHP-CVS] svn: /php/php-src/trunk/ext/mysqlnd/ mysqlnd_auth.c

2011-02-01 Thread Kalle Sommer Nielsen
Hi Andrey 2011/1/31, Andrey Hristov p...@hristov.com: On 01/31/2011 01:32 PM, Kalle Sommer Nielsen wrote: this will return emalloc-ed memory, right? Later this memory will be freed with free() and guess what happens :) No, the e functions will return emalloc()'d memory, the zend_str

Re: [PHP-CVS] svn: /php/php-src/trunk/ext/mysqlnd/ mysqlnd_auth.c

2011-02-01 Thread Andrey Hristov
On 02/01/2011 11:36 AM, Kalle Sommer Nielsen wrote: Hi Andrey 2011/1/31, Andrey Hristov p...@hristov.com: On 01/31/2011 01:32 PM, Kalle Sommer Nielsen wrote: this will return emalloc-ed memory, right? Later this memory will be freed with free() and guess what happens :) No, the e

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/zip/php_zip.c trunk/ext/zip/php_zip.c

2011-02-01 Thread Pierre Joye
pajoye Tue, 01 Feb 2011 10:57:51 + Revision: http://svn.php.net/viewvc?view=revisionrevision=307905 Log: - WS Changed paths: U php/php-src/branches/PHP_5_3/ext/zip/php_zip.c U php/php-src/trunk/ext/zip/php_zip.c Modified:

[PHP-CVS] svn: /php/php-src/trunk/ext/snmp/ snmp.c

2011-02-01 Thread Pierre Joye
pajoye Tue, 01 Feb 2011 13:57:06 + Revision: http://svn.php.net/viewvc?view=revisionrevision=307914 Log: - fix build, wrong version id Changed paths: U php/php-src/trunk/ext/snmp/snmp.c Modified: php/php-src/trunk/ext/snmp/snmp.c

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/phar/phar.c branches/PHP_5_3/ext/phar/tests/bug46032.phpt branches/PHP_5_3/ext/phar/tests/phar_construct_invalidurl.phpt branches/PHP_5_3/ext/phar/tes

2011-02-01 Thread Ilia Alshanetsky
iliaaTue, 01 Feb 2011 14:01:00 + Revision: http://svn.php.net/viewvc?view=revisionrevision=307915 Log: Fixed bug #53898 (PHAR reports invalid error message, when the directory does not exist). Bug: http://bugs.php.net/53898 (Open) PHAR reports invalid

[PHP-CVS] svn: /php/php-src/trunk/ext/zip/ zip_stream.c

2011-02-01 Thread Gustavo André dos Santos Lopes
cataphract Tue, 01 Feb 2011 14:43:52 + Revision: http://svn.php.net/viewvc?view=revisionrevision=307916 Log: - Fixed bug #49072 (feof never returns true for damaged file in zip). Bug: http://bugs.php.net/49072 (Re-Opened) feof never returns true for damaged

[PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ NEWS ext/zip/zip_stream.c

2011-02-01 Thread Gustavo André dos Santos Lopes
cataphract Tue, 01 Feb 2011 14:44:29 + Revision: http://svn.php.net/viewvc?view=revisionrevision=307917 Log: - Fixed bug #49072 (feof never returns true for damaged file in zip). Bug: http://bugs.php.net/49072 (Re-Opened) feof never returns true for damaged

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/mysqlnd/mysqlnd_ps.c trunk/ext/mysqlnd/mysqlnd_ps.c

2011-02-01 Thread Andrey Hristov
andrey Tue, 01 Feb 2011 16:55:20 + Revision: http://svn.php.net/viewvc?view=revisionrevision=307921 Log: fix warnings. These checks are not needed because param_no is unsigned, it wasn't in the beginning. Changed paths: U

[PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ ext/standard/streamsfuncs.c main/network.c main/streams/filter.c main/streams/streams.c

2011-02-01 Thread Gustavo André dos Santos Lopes
cataphract Tue, 01 Feb 2011 18:10:35 + Revision: http://svn.php.net/viewvc?view=revisionrevision=307922 Log: - Fixed several comparisons that always result in true of false due to signedness of one of the operands, either by removing dead code or fixing it.

[PHP-CVS] svn: /php/php-src/trunk/ ext/standard/streamsfuncs.c main/network.c main/streams/filter.c main/streams/streams.c

2011-02-01 Thread Gustavo André dos Santos Lopes
cataphract Tue, 01 Feb 2011 18:11:16 + Revision: http://svn.php.net/viewvc?view=revisionrevision=307923 Log: - Fixed several comparisons that always result in true of false due to signedness of one of the operands, either by removing dead code or fixing it.

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/mysqlnd/mysqlnd_loaddata.c trunk/ext/mysqlnd/mysqlnd_loaddata.c

2011-02-01 Thread Andrey Hristov
andrey Tue, 01 Feb 2011 19:30:22 + Revision: http://svn.php.net/viewvc?view=revisionrevision=307931 Log: Fix more warnings about size_t Changed paths: U php/php-src/branches/PHP_5_3/ext/mysqlnd/mysqlnd_loaddata.c U

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/standard/tests/streams/bug53903.phpt branches/PHP_5_3/main/streams/userspace.c trunk/ext/standard/tests/streams/bug53903.phpt tr

2011-02-01 Thread Gustavo André dos Santos Lopes
cataphract Tue, 01 Feb 2011 22:55:17 + Revision: http://svn.php.net/viewvc?view=revisionrevision=307934 Log: - Fixed bug #53903 (userspace stream stat callback does not separate the elements of the returned array before converting them). Bug: