[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/standard/tests/url/parse_url_basic_001.phpt branches/PHP_5_3/ext/standard/tests/url/parse_url_basic_002.phpt branches/PHP_5_3/ext/standard/tests/url/p

[Ilia Alshanetsky]

iliaaSun, 06 Feb 2011 17:23:57 +

Revision: http://svn.php.net/viewvc?view=revision&revision=308064

Log:
Fixed parse_url() tests to account for port validation

Changed paths:
U   
php/php-src/branches/PHP_5_3/ext/standard/tests/url/parse_url_basic_001.phpt
U   
php/php-src/branches/PHP_5_3/ext/standard/tests/url/parse_url_basic_002.phpt
U   
php/php-src/branches/PHP_5_3/ext/standard/tests/url/parse_url_basic_003.phpt
U   
php/php-src/branches/PHP_5_3/ext/standard/tests/url/parse_url_basic_004.phpt
U   
php/php-src/branches/PHP_5_3/ext/standard/tests/url/parse_url_basic_005.phpt
U   
php/php-src/branches/PHP_5_3/ext/standard/tests/url/parse_url_basic_006.phpt
U   
php/php-src/branches/PHP_5_3/ext/standard/tests/url/parse_url_basic_007.phpt
U   
php/php-src/branches/PHP_5_3/ext/standard/tests/url/parse_url_basic_008.phpt
U   
php/php-src/branches/PHP_5_3/ext/standard/tests/url/parse_url_basic_009.phpt
U   php/php-src/trunk/ext/standard/tests/url/parse_url_basic_001.phpt
U   php/php-src/trunk/ext/standard/tests/url/parse_url_basic_002.phpt
U   php/php-src/trunk/ext/standard/tests/url/parse_url_basic_003.phpt
U   php/php-src/trunk/ext/standard/tests/url/parse_url_basic_004.phpt
U   php/php-src/trunk/ext/standard/tests/url/parse_url_basic_005.phpt
U   php/php-src/trunk/ext/standard/tests/url/parse_url_basic_006.phpt
U   php/php-src/trunk/ext/standard/tests/url/parse_url_basic_007.phpt
U   php/php-src/trunk/ext/standard/tests/url/parse_url_basic_008.phpt
U   php/php-src/trunk/ext/standard/tests/url/parse_url_basic_009.phpt

Modified: php/php-src/branches/PHP_5_3/ext/standard/tests/url/parse_url_basic_001.phpt
===
--- php/php-src/branches/PHP_5_3/ext/standard/tests/url/parse_url_basic_001.phpt	2011-02-06 17:22:05 UTC (rev 308063)
+++ php/php-src/branches/PHP_5_3/ext/standard/tests/url/parse_url_basic_001.phpt	2011-02-06 17:23:57 UTC (rev 308064)
@@ -734,14 +734,7 @@
   string(9) "/blah.com"
 }

---> x://::abc/?: array(3) {
-  ["scheme"]=>
-  string(1) "x"
-  ["host"]=>
-  string(1) ":"
-  ["path"]=>
-  string(1) "/"
-}
+--> x://::abc/?: bool(false)

 --> http://::?: array(2) {
   ["scheme"]=>

Modified: php/php-src/branches/PHP_5_3/ext/standard/tests/url/parse_url_basic_002.phpt
===
--- php/php-src/branches/PHP_5_3/ext/standard/tests/url/parse_url_basic_002.phpt	2011-02-06 17:22:05 UTC (rev 308063)
+++ php/php-src/branches/PHP_5_3/ext/standard/tests/url/parse_url_basic_002.phpt	2011-02-06 17:23:57 UTC (rev 308064)
@@ -94,7 +94,7 @@
 --> http://x:?   : string(4) "http"
 --> x:blah.com   : string(1) "x"
 --> x:/blah.com   : string(1) "x"
---> x://::abc/?   : string(1) "x"
+--> x://::abc/?   : bool(false)
 --> http://::?   : string(4) "http"
 --> x://::6.5   : string(1) "x"
 --> http://?:/   : string(4) "http"

Modified: php/php-src/branches/PHP_5_3/ext/standard/tests/url/parse_url_basic_003.phpt
===
--- php/php-src/branches/PHP_5_3/ext/standard/tests/url/parse_url_basic_003.phpt	2011-02-06 17:22:05 UTC (rev 308063)
+++ php/php-src/branches/PHP_5_3/ext/standard/tests/url/parse_url_basic_003.phpt	2011-02-06 17:23:57 UTC (rev 308064)
@@ -93,7 +93,7 @@
 --> http://x:?   : string(1) "x"
 --> x:blah.com   : NULL
 --> x:/blah.com   : NULL
---> x://::abc/?   : string(1) ":"
+--> x://::abc/?   : bool(false)
 --> http://::?   : string(1) ":"
 --> x://::6.5   : string(1) ":"
 --> http://?:/   : string(1) "?"

Modified: php/php-src/branches/PHP_5_3/ext/standard/tests/url/parse_url_basic_004.phpt
===
--- php/php-src/branches/PHP_5_3/ext/standard/tests/url/parse_url_basic_004.phpt	2011-02-06 17:22:05 UTC (rev 308063)
+++ php/php-src/branches/PHP_5_3/ext/standard/tests/url/parse_url_basic_004.phpt	2011-02-06 17:23:57 UTC (rev 308064)
@@ -93,7 +93,7 @@
 --> http://x:?   : NULL
 --> x:blah.com   : NULL
 --> x:/blah.com   : NULL
---> x://::abc/?   : NULL
+--> x://::abc/?   : bool(false)
 --> http://::?   : NULL
 --> x://::6.5   : int(6)
 --> http://?:/   : NULL

Modified: php/php-src/branches/PHP_5_3/ext/standard/tests/url/parse_url_basic_005.phpt
===
--- php/php-src/branches/PHP_5_3/ext/standard/tests/url/parse_url_basic_005.phpt	2011-02-06 17:22:05 UTC (rev 308063)
+++ php/php-src/branches/PHP_5_3/ext/standard/tests/url/parse_url_basic_005.phpt	2011-02-06 17:23:57 UTC (rev 308064)
@@ -93,7 +93,7 @@
 --> http://x:?   : NULL
 --> x:blah.com   : NULL
 --> x:/blah.com   : NULL
---> x://::abc/?   : NULL
+--> x://::abc/?   : bool(false)
 --> http://::?   : NULL
 --> x://::6.5   : NULL
 --> http://?:/   : NULL

Modified: php/php-src/branches/PHP_5_3/ext/standard/tests/url/parse_url_basic_006.phpt
===

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/filter/tests/015.phpt branches/PHP_5_3/ext/standard/url.c trunk/ext/filter/tests/015.phpt trunk/ext/standard/url.c

[Ilia Alshanetsky]

Missing news entry from a previous bug fix.

On Fri, Feb 4, 2011 at 10:37 PM, Adam Harvey  wrote:
> On 5 February 2011 05:41, Ilia Alshanetsky  wrote:
>> Log:
>> Fixed bug #53924 (FILTER_VALIDATE_URL doesn't validate port number).
>>
>> Modified: php/php-src/branches/PHP_5_3/NEWS
>> ===
>> --- php/php-src/branches/PHP_5_3/NEWS   2011-02-04 19:22:43 UTC (rev 308034)
>> +++ php/php-src/branches/PHP_5_3/NEWS   2011-02-04 21:41:15 UTC (rev 308035)
>> @@ -109,6 +111,8 @@
>>  - Phar extension:
>>   . Fixed bug #53541 (format string bug in ext/phar).
>>     (crrodriguez at opensuse dot org, Ilia)
>> +  . Fixed bug #53898 (PHAR reports invalid error message, when the directory
>> +    does not exist). (Ilia)
>
> I suspect that NEWS item was meant to be for another commit. :)
>
> Adam
>

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php