Hi Felipe:
On 18 Nov 2011, at 14:56, Felipe Pena wrote:
felipe Fri, 18 Nov 2011 13:56:41 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=319487
- else if (!strncmp(mname, ZEND_DESTRUCTOR_FUNC_NAME, mname_len)) {
ce-destructor
On Fri, Nov 18, 2011 at 3:07 PM, Stefan Marr p...@stefan-marr.de wrote:
Would it be a problem to revert that change, or at least 'table' it again?
http://svn.php.net/viewvc/php/php-src/trunk/CODING_STANDARDS?revision=296679view=markup
Nothing to discuss, love, hate, etc., just apply them :-)
Hi,
2011/11/18 Stefan Marr p...@stefan-marr.de:
Hi Felipe:
On 18 Nov 2011, at 14:56, Felipe Pena wrote:
felipe Fri, 18 Nov 2011 13:56:41 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=319487
- else if (!strncmp(mname,
Hi:
On 18 Nov 2011, at 15:16, Felipe Pena wrote:
Hi,
2011/11/18 Stefan Marr p...@stefan-marr.de:
Hi Felipe:
On 18 Nov 2011, at 14:56, Felipe Pena wrote:
felipe Fri, 18 Nov 2011 13:56:41 +
Revision:
Then at least follow what 3. states as the first (and deducted from that)
most important statement:
Be generous with whitespace
Please, make it look like a table.
That is not against the coding standards. (Which IMHO should leave room for
exceptions when it comes to readability)
Be
On 18 Nov 2011, at 15:36, Felipe Pena wrote:
'Be generous with whitespace' is the opposite of what you want to do.
I.e. generous != stingy. :P
I was obviously to imprecise in my request:
Index: Zend/zend_compile.c
===
---
On Fri, Nov 18, 2011 at 4:03 PM, Stefan Marr p...@stefan-marr.de wrote:
On 18 Nov 2011, at 15:36, Felipe Pena wrote:
'Be generous with whitespace' is the opposite of what you want to do.
I.e. generous != stingy. :P
I was obviously to imprecise in my request:
I do not want to sound harsh but
Hi Antony:
On 02 Nov 2011, at 22:05, Antony Dovgal wrote:
tony2001 Wed, 02 Nov 2011 21:05:36 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=318705
Log:
initialize variable and fix segfaulting tests
Thanks for catching this one and the one
On 11/03/2011 01:21 PM, Stefan Marr wrote:
Hi Antony:
On 02 Nov 2011, at 22:05, Antony Dovgal wrote:
tony2001 Wed, 02 Nov 2011 21:05:36 +
Revision: http://svn.php.net/viewvc?view=revisionrevision=318705
Log:
initialize variable and fix segfaulting
On Tue, 2011-08-16 at 12:37 -0700, Stas Malyshev wrote:
Hi!
On 8/16/11 6:19 AM, Johannes Schlüter wrote:
It saves one character of typing.
For me, it's the reason enough to prohibit it altogether :) Writing
weird code to save one character of typing is the worst habit we could
Hi Hannes:
On 16 Aug 2011, at 12:46, Hannes Magnusson wrote:
+ if (!strcmp(Z_STRVAL_P(name), strict)) {
+ zend_error(E_COMPILE_ERROR, You seem to be trying to
use a different language...);
+ }
Could we change that error to be a bit more explicit
On Tue, Aug 16, 2011 at 13:05, Stefan Marr p...@stefan-marr.de wrote:
Hi Hannes:
On 16 Aug 2011, at 12:46, Hannes Magnusson wrote:
+ if (!strcmp(Z_STRVAL_P(name), strict)) {
+ zend_error(E_COMPILE_ERROR, You seem to be trying to
use a different language...);
On 16 Aug 2011, at 13:23, Hannes Magnusson wrote:
On Tue, Aug 16, 2011 at 13:05, Stefan Marr p...@stefan-marr.de wrote:
Hi Hannes:
On 16 Aug 2011, at 12:46, Hannes Magnusson wrote:
+ if (!strcmp(Z_STRVAL_P(name), strict)) {
+ zend_error(E_COMPILE_ERROR,
On Tue, Aug 16, 2011 at 13:39, Stefan Marr p...@stefan-marr.de wrote:
On 16 Aug 2011, at 13:23, Hannes Magnusson wrote:
On Tue, Aug 16, 2011 at 13:05, Stefan Marr p...@stefan-marr.de wrote:
Hi Hannes:
On 16 Aug 2011, at 12:46, Hannes Magnusson wrote:
+ if
On Tue, 2011-08-16 at 13:44 +0200, Hannes Magnusson wrote:
use foobar; has no effect, at all, and you will get an warning
message telling you that.
It has an effect. In
namespace strict { class C {} }
namespace foo { use strict; new strict\C; }
It saves one character of typing. Without the
2011/8/16 Johannes Schlüter johan...@schlueters.de:
On Tue, 2011-08-16 at 13:44 +0200, Hannes Magnusson wrote:
use foobar; has no effect, at all, and you will get an warning
message telling you that.
It has an effect. In
namespace strict { class C {} }
namespace foo { use strict; new
Hi!
On 8/16/11 6:19 AM, Johannes Schlüter wrote:
It saves one character of typing.
For me, it's the reason enough to prohibit it altogether :) Writing
weird code to save one character of typing is the worst habit we could
promote. But I digress since the idea of this patch was obviously not
17 matches
Mail list logo
