Re: [PHP-CVS] Re: cvs: php-src /ext/pdo pdo_sql_parser.c pdo_sql_parser.re /ext/pdo/tests bug_43130.phpt

2007-11-24 Thread Lukas Kahwe Smith
On 16.11.2007, at 14:21, Ilia Alshanetsky wrote: I don't see why PDO should follow oracle's rules for generic functionality. I think current implementation is good as is. 1) its a BC break that can affect any user 2) this can break queries for Oracle users porting to PDO in a very non

Re: [PHP-CVS] Re: cvs: php-src /ext/pdo pdo_sql_parser.c pdo_sql_parser.re /ext/pdo/tests bug_43130.phpt

2007-11-16 Thread Johannes Schlüter
Lukas, On Wed, 2007-11-14 at 16:49 +0100, Lukas Kahwe Smith wrote: On 01.11.2007, at 00:56, Lorenzo Alberton wrote: Lukas Kahwe Smith wrote: I talked to Christopher Jones (of Oracle fame) and Lorenzo (MDB2 maintainer). Its clear that the only named parameter supporting database I

Re: [PHP-CVS] Re: cvs: php-src /ext/pdo pdo_sql_parser.c pdo_sql_parser.re /ext/pdo/tests bug_43130.phpt

2007-11-16 Thread Ilia Alshanetsky
I don't see why PDO should follow oracle's rules for generic functionality. I think current implementation is good as is. On 14-Nov-07, at 10:49 AM, Lukas Kahwe Smith wrote: On 01.11.2007, at 00:56, Lorenzo Alberton wrote: Lukas Kahwe Smith wrote: I talked to Christopher Jones (of Oracle

Re: [PHP-CVS] Re: cvs: php-src /ext/pdo pdo_sql_parser.c pdo_sql_parser.re /ext/pdo/tests bug_43130.phpt

2007-11-14 Thread Lukas Kahwe Smith
On 01.11.2007, at 00:56, Lorenzo Alberton wrote: Lukas Kahwe Smith wrote: I talked to Christopher Jones (of Oracle fame) and Lorenzo (MDB2 maintainer). Its clear that the only named parameter supporting database I know does not support dash inside named parameters. Its also dangerous

Re: [PHP-CVS] Re: cvs: php-src /ext/pdo pdo_sql_parser.c pdo_sql_parser.re /ext/pdo/tests bug_43130.phpt

2007-10-31 Thread Lukas Kahwe Smith
On 30.10.2007, at 12:00, Johannes Schlüter wrote: Ilia, I don't think this is right. SQL operators shouldn't be part of a parameter name imo. I talked to Christopher Jones (of Oracle fame) and Lorenzo (MDB2 maintainer). Its clear that the only named parameter supporting database I know

Re: [PHP-CVS] Re: cvs: php-src /ext/pdo pdo_sql_parser.c pdo_sql_parser.re /ext/pdo/tests bug_43130.phpt

2007-10-31 Thread Lorenzo Alberton
Lukas Kahwe Smith wrote: I talked to Christopher Jones (of Oracle fame) and Lorenzo (MDB2 maintainer). Its clear that the only named parameter supporting database I know does not support dash inside named parameters. Its also dangerous since it means that whitespace typos could have serious

[PHP-CVS] Re: cvs: php-src /ext/pdo pdo_sql_parser.c pdo_sql_parser.re /ext/pdo/tests bug_43130.phpt

2007-10-30 Thread Johannes Schlüter
Ilia, I don't think this is right. SQL operators shouldn't be part of a parameter name imo. johannes On Mon, 2007-10-29 at 22:37 +, Ilia Alshanetsky wrote: iliaa Mon Oct 29 22:37:44 2007 UTC Modified files: /php-src/ext/pdo pdo_sql_parser.re

Re: [PHP-CVS] Re: cvs: php-src /ext/pdo pdo_sql_parser.c pdo_sql_parser.re /ext/pdo/tests bug_43130.phpt

2007-10-30 Thread Ilia Alshanetsky
I do not see a reason why - character should be disallowed in the operator name, even if it can be an operator. On 30-Oct-07, at 7:00 AM, Johannes Schlüter wrote: Ilia, I don't think this is right. SQL operators shouldn't be part of a parameter name imo. johannes On Mon, 2007-10-29 at