Commit:    dc1138b102b8fde7a119cb8f7ceb30b26dfdf6b3
Author:    Felipe Pena <felipe...@gmail.com>         Sun, 19 Aug 2012 12:13:48 
-0300
Parents:   8b87c6df8408b95a1bfae4a82958a48e3a220b5a
Branches:  PHP-5.3 PHP-5.4 master

Link:       
http://git.php.net/?p=php-src.git;a=commitdiff;h=dc1138b102b8fde7a119cb8f7ceb30b26dfdf6b3

Log:
- Value stored to var is never read

Changed paths:
  M  ext/dom/element.c


Diff:
diff --git a/ext/dom/element.c b/ext/dom/element.c
index 9792741..33002fa 100644
--- a/ext/dom/element.c
+++ b/ext/dom/element.c
@@ -832,7 +832,7 @@ PHP_FUNCTION(dom_element_set_attribute_ns)
                        }
 
                        if (errorcode == 0 && is_xmlns == 0) {
-                               attr = xmlSetNsProp(elemp, nsptr, (xmlChar 
*)localname, (xmlChar *)value);
+                               xmlSetNsProp(elemp, nsptr, (xmlChar 
*)localname, (xmlChar *)value);
                        }
                } else {
                        name_valid = xmlValidateName((xmlChar *) localname, 0);
@@ -844,7 +844,7 @@ PHP_FUNCTION(dom_element_set_attribute_ns)
                                if (attr != NULL && attr->type != 
XML_ATTRIBUTE_DECL) {
                                        node_list_unlink(attr->children 
TSRMLS_CC);
                                }
-                               attr = xmlSetProp(elemp, (xmlChar *)localname, 
(xmlChar *)value);
+                               xmlSetProp(elemp, (xmlChar *)localname, 
(xmlChar *)value);
                        }
                }
        }


--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to