pajoye Tue Jul 7 11:06:21 2009 UTC
Modified files: (Branch: PHP_5_2)
/php-src/ext/gd/libgd gd.c
Log:
- MF53: #45905, imagefilledrectangle() clipping error
kalle Tue Jun 23 07:09:19 2009 UTC
Modified files: (Branch: PHP_5_2)
/php-src/ext/gd/libgd gd.c
Log:
Whops, nobody saw this :)
http://cvs.php.net/viewvc.cgi/php-src/ext/gd/libgd/gd.c?r1=1.90.2.1.2.28r2=1.90.2.1.2.29diff_format=u
Index:
kalle Mon Jun 22 15:51:13 2009 UTC
Modified files: (Branch: PHP_5_2)
/php-src/ext/gd/libgd gd.c
Log:
MFH: Use correct data types here, and gdImageSaveAlpha for the alpha flag
kalle Mon Jun 22 15:52:59 2009 UTC
Modified files: (Branch: PHP_5_2)
/php-src/ext/gd/libgd gd.c
Log:
Should have been in previous commit
http://cvs.php.net/viewvc.cgi/php-src/ext/gd/libgd/gd.c?r1=1.90.2.1.2.27r2=1.90.2.1.2.28diff_format=u
Index:
tabeThu Apr 23 16:28:39 2009 UTC
Modified files: (Branch: PHP_5_2)
/php-src/ext/gd/libgd gd.c
Log:
MFH: check non-null before any use.
http://cvs.php.net/viewvc.cgi/php-src/ext/gd/libgd/gd.c?r1=1.90.2.1.2.25r2=1.90.2.1.2.26diff_format=u
Index:
scottmacWed Dec 10 13:33:10 2008 UTC
Added files: (Branch: PHP_5_2)
/php-src/ext/gd/tests imagerotate_overflow.phpt
Modified files:
/php-src/ext/gd/libgd gd.c
Log:
MFH Fix segfault and potential security issue in
rasmus Thu Jul 31 09:22:17 2008 UTC
Modified files: (Branch: PHP_5_2)
/php-src/ext/gd/libgd gd.c gd_png.c
Log:
Fix for bug #45030
http://cvs.php.net/viewvc.cgi/php-src/ext/gd/libgd/gd.c?r1=1.90.2.1.2.22r2=1.90.2.1.2.23diff_format=u
Index:
mattias Sun Nov 4 23:56:00 2007 UTC
Added files: (Branch: PHP_5_2)
/php-src/ext/gd/tests bug43121.gif bug43121.phpt
Modified files:
/php-src/ext/gd/libgd gd.c
Log:
- Fixed Bug #43121 (gdImageFill with IMG_COLOR_TILED crashes
pajoye Sun Sep 9 13:05:52 2007 UTC
Modified files: (Branch: PHP_5_2)
/php-src/ext/gd/libgd gd.c
Log:
- re-add fix for libgd #106, imagerectangle draws 1x1 rectangles
as 1x3 rectangles
On 6/15/07, Stanislav Malyshev [EMAIL PROTECTED] wrote:
+ pts = (char *) ecalloc(im-sy * im-sx, sizeof(char));
I don't see any overflow checks around, are you sure it's safe?
Checks are done in gdImageCreate*
--Pierre
Ah, exactly. That explains why I wasn't able to crash it :-)
Nuno
pajoye Sun Jun 17 16:51:50 2007 UTC
Modified files: (Branch: PHP_5_2)
/php-src/ext/gd/libgd gd.c
Log:
- Drop useless tests (Daniel Diaz)
http://cvs.php.net/viewvc.cgi/php-src/ext/gd/libgd/gd.c?r1=1.90.2.1.2.15r2=1.90.2.1.2.16diff_format=u
Index:
nlopess Sun Jun 17 19:03:58 2007 UTC
Modified files: (Branch: PHP_5_2)
/php-src/ext/gd/libgd gd.c
Log:
malloc+memset == calloc (sync with libgd)
http://cvs.php.net/viewvc.cgi/php-src/ext/gd/libgd/gd.c?r1=1.90.2.1.2.16r2=1.90.2.1.2.17diff_format=u
Index:
On 6/15/07, Stanislav Malyshev [EMAIL PROTECTED] wrote:
+ pts = (char *) ecalloc(im-sy * im-sx, sizeof(char));
I don't see any overflow checks around, are you sure it's safe?
Checks are done in gdImageCreate*
--Pierre
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit:
nlopess Fri Jun 15 19:47:10 2007 UTC
Modified files: (Branch: PHP_5_2)
/php-src/ext/gd/libgd gd.c
Log:
sync with libgd: improve _gdImageFillTiled()
http://cvs.php.net/viewvc.cgi/php-src/ext/gd/libgd/gd.c?r1=1.90.2.1.2.13r2=1.90.2.1.2.14diff_format=u
Index:
+ pts = (char *) ecalloc(im-sy * im-sx, sizeof(char));
I don't see any overflow checks around, are you sure it's safe?
--
Stanislav Malyshev, Zend Products Engineer
[EMAIL PROTECTED] http://www.zend.com/
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit:
Ah! good point, thanks. I'll check it out.
Nuno
- Original Message -
+ pts = (char *) ecalloc(im-sy * im-sx, sizeof(char));
I don't see any overflow checks around, are you sure it's safe?
--
Stanislav Malyshev, Zend Products Engineer
[EMAIL PROTECTED] http://www.zend.com/
--
PHP
pajoye Fri Mar 9 01:18:40 2007 UTC
Modified files: (Branch: PHP_5_2)
/php-src/ext/gd/libgd gd.c
Log:
- #40764, line thickness not respected for horizontal and vertical lines
pajoye Fri Jan 19 15:03:56 2007 UTC
Modified files: (Branch: PHP_5_2)
/php-src/ext/gd/libgd gd.c
Log:
- save/restore the alpha blending mode correctly in imagefill and
imagefilltoborder
As the commit log says, I fixed a few valgrind warnings in the
bug24594.phpt
test (it was reading one past the end of the array). The log is still
available at
http://gcov.php.net/viewer.php?version=PHP_5_2func=valgrindfile=ext%2Fgd%2Ftests%2Fbug24594.phpt
the fix is this part:
- for (; x=wx2
Hello Nuno,
On 1/14/07, Nuno Lopes [EMAIL PROTECTED] wrote:
It is reproducible everywhere, I must say (including my pc). wx2 is the size
of the array, so you can only read from idx 0 to (wx2-1). Reading idx wx2
doesn't make sense.
Right, I was wondering why valgrind don't say a word here,
nlopess Sat Jan 13 11:16:15 2007 UTC
Modified files: (Branch: PHP_5_2)
/php-src/ext/gd/libgd gd.c
Log:
fix valgrind error in test bug24594.phpt
while at it, remove some dead code and change the pts vector to char to save
(much) memory
# Pierre: one more
nlopess Sat Jan 13 11:21:21 2007 UTC
Modified files: (Branch: PHP_5_2)
/php-src/ext/gd/libgd gd.c
Log:
OMG, this line was really bogus (and allocating huge amounts of memory
unecessarly)
Hello Nuno,
On 1/13/07, Nuno Lopes [EMAIL PROTECTED] wrote:
nlopess Sat Jan 13 11:16:15 2007 UTC
Modified files: (Branch: PHP_5_2)
/php-src/ext/gd/libgd gd.c
Log:
fix valgrind error in test bug24594.phpt
while at it, remove some dead code and change the
On 1/13/07, Nuno Lopes [EMAIL PROTECTED] wrote:
nlopess Sat Jan 13 11:16:15 2007 UTC
Modified files: (Branch: PHP_5_2)
/php-src/ext/gd/libgd gd.c
Log:
fix valgrind error in test bug24594.phpt
while at it, remove some dead code and change the pts vector to
Hello Nuno,
On 1/13/07, Nuno Lopes [EMAIL PROTECTED] wrote:
On 1/13/07, Nuno Lopes [EMAIL PROTECTED] wrote:
nlopess Sat Jan 13 11:16:15 2007 UTC
Modified files: (Branch: PHP_5_2)
/php-src/ext/gd/libgd gd.c
Log:
fix valgrind error in test bug24594.phpt
pajoye Tue Nov 14 13:45:24 2006 UTC
Modified files: (Branch: PHP_5_2)
/php-src/ext/gd/libgd gd.c
Log:
- #39508, do not use the 4 neighbors implementation for small images (w4)
test will follow
pajoye Sat Nov 4 02:21:06 2006 UTC
Added files: (Branch: PHP_5_2)
/php-src/ext/gd/tests bug39273.phpt
Modified files:
/php-src/ext/gd/libgd gd.c
Log:
- #39273, imagecopyresized and alpha channel
pajoye Thu Sep 28 08:48:02 2006 UTC
Added files: (Branch: PHP_5_2)
/php-src/ext/gd/tests imagefill_1.phpt
Modified files:
/php-src/ext/gd/libgd gd.c
Log:
- imagefill(), infinite loop with wrong color index
pajoye Sun Jul 23 21:41:12 2006 UTC
Added files: (Branch: PHP_5_2)
/php-src/ext/gd/tests 38179.phpt
Modified files:
/php-src/ext/gd/libgd gd.c
Log:
- #38179, imagecopy, palette to truecolor must use alpha channel too
29 matches
Mail list logo
