[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2009-02-13 Thread Moriyoshi Koizumi
moriyoshi Sat Feb 14 07:00:24 2009 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard string.c Log: - MFH: these should be E_WARNING for consistency with strpos() http://cvs.php.net/viewvc.cgi/php-src/ext/standard/string.c?r1=1.445.2.14.2.

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2009-01-29 Thread Ilia Alshanetsky
iliaa Fri Jan 30 00:17:06 2009 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard string.c Log: MFB: Improved validation checks inside str_pad() http://cvs.php.net/viewvc.cgi/php-src/ext/standard/string.c?r1=1.445.2.14.2.79&r2=1.445.2.14.2.80&

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2008-11-05 Thread Felipe Pena
felipe Wed Nov 5 18:55:02 2008 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard string.c Log: - Fixed bug #45166 (substr() overflow changes) (now synced with other branches) http://cvs.php.net/viewvc.cgi/php-src/ext/standard/string.c?r1=1.445.

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c /ext/standard/tests/strings bug45485.phpt

2008-07-11 Thread Felipe Pena
felipe Fri Jul 11 12:16:06 2008 UTC Added files: (Branch: PHP_5_2) /php-src/ext/standard/tests/strings bug45485.phpt Modified files: /php-src/ext/standard string.c Log: - Fixed bug #45485 (strip_tags and http://cvs.php.net/viewvc.cgi/

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2008-05-09 Thread Scott MacVicar
scottmacFri May 9 12:59:42 2008 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard string.c Log: MFH: Fix compile error if _GNU_SOURCE is defined http://cvs.php.net/viewvc.cgi/php-src/ext/standard/string.c?r1=1.445.2.14.2.73&r2=1.445.2.14.

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2007-12-13 Thread Antony Dovgal
tony2001Thu Dec 13 22:30:28 2007 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard string.c Log: MFH http://cvs.php.net/viewvc.cgi/php-src/ext/standard/string.c?r1=1.445.2.14.2.70&r2=1.445.2.14.2.71&diff_format=u Index: php-src/ext/stan

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2007-09-07 Thread Pierre-Alain Joye
pajoye Fri Sep 7 18:23:58 2007 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard string.c Log: - #42592, remove ending dot in warning msg http://cvs.php.net/viewvc.cgi/php-src/ext/standard/string.c?r1=1.445.2.14.2.68&r2=1.445.2.14.2.69&diff_f

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c /ext/standard/tests/strings str_pad.phpt

2007-07-23 Thread Jani Taskinen
janiMon Jul 23 13:27:59 2007 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard string.c /php-src/ext/standard/tests/strings str_pad.phpt Log: MFH: Fixed str_pad() when passed huge negative pad length. http://cvs.php.net/viewvc.cgi/php-

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2007-06-06 Thread Antony Dovgal
tony2001Wed Jun 6 21:53:54 2007 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard string.c Log: MFH http://cvs.php.net/viewvc.cgi/php-src/ext/standard/string.c?r1=1.445.2.14.2.62&r2=1.445.2.14.2.63&diff_format=u Index: php-src/ext/stan

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2007-06-06 Thread Stanislav Malyshev
stasWed Jun 6 18:15:42 2007 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard string.c Log: fix the chunks fix http://cvs.php.net/viewvc.cgi/php-src/ext/standard/string.c?r1=1.445.2.14.2.61&r2=1.445.2.14.2.62&diff_format=u Index: php-src/e

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2007-06-06 Thread Stanislav Malyshev
stasWed Jun 6 17:59:08 2007 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard string.c Log: Fix chunk_split fix - avoid using floats Fix money_format - don't give strfmon more arguments then supplied Fix str[c]spn integer overflow http

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2007-06-05 Thread Antony Dovgal
tony2001Tue Jun 5 13:35:26 2007 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard string.c Log: fix folding http://cvs.php.net/viewvc.cgi/php-src/ext/standard/string.c?r1=1.445.2.14.2.59&r2=1.445.2.14.2.60&diff_format=u Index: php-src/

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2007-05-24 Thread Rasmus Lerdorf
rasmus Thu May 24 21:29:27 2007 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard string.c Log: Uh, only meant to remove the null check, not the assignment http://cvs.php.net/viewvc.cgi/php-src/ext/standard/string.c?r1=1.445.2.14.2.56&r2=1.445

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2007-05-24 Thread Rasmus Lerdorf
rasmus Thu May 24 20:53:05 2007 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard string.c Log: Avoid running off the end of a non-null terminated string. Not that we should have any of those, but a mistake in an extension could hit this and th

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2007-03-12 Thread Antony Dovgal
tony2001Mon Mar 12 23:42:26 2007 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard string.c Log: return false instead of empty string when -length is greater than (len - offset) http://cvs.php.net/viewvc.cgi/php-src/ext/standard/string

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2007-03-10 Thread Ilia Alshanetsky
iliaa Sat Mar 10 20:07:51 2007 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard string.c Log: Re-added check removed by the previous patch http://cvs.php.net/viewvc.cgi/php-src/ext/standard/string.c?r1=1.445.2.14.2.51&r2=1.445.2.14.2.52&diff

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c /ext/standard/tests/strings bug40754.phpt

2007-03-09 Thread Antony Dovgal
tony2001Fri Mar 9 10:04:59 2007 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard string.c /php-src/ext/standard/tests/strings bug40754.phpt Log: fix substr() it's perfectly legal to do substr("str", 0, 100); http://cvs.php.

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2007-03-07 Thread Stanislav Malyshev
stasThu Mar 8 00:47:04 2007 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard string.c Log: clarify checks and error messages http://cvs.php.net/viewvc.cgi/php-src/ext/standard/string.c?r1=1.445.2.14.2.48&r2=1.445.2.14.2.49&diff_format=u I

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2007-03-07 Thread Ilia Alshanetsky
iliaa Thu Mar 8 00:18:11 2007 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard string.c Log: Improved length parameter validation http://cvs.php.net/viewvc.cgi/php-src/ext/standard/string.c?r1=1.445.2.14.2.47&r2=1.445.2.14.2.48&diff_format=

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2007-03-07 Thread Ilia Alshanetsky
iliaa Thu Mar 8 00:06:41 2007 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard string.c Log: Improved offset validation http://cvs.php.net/viewvc.cgi/php-src/ext/standard/string.c?r1=1.445.2.14.2.46&r2=1.445.2.14.2.47&diff_format=u Index: p

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2007-03-07 Thread Stanislav Malyshev
stasWed Mar 7 18:15:46 2007 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard string.c Log: fix MOPB#14 # The error message seems wrong, so maybe better fix is needed http://cvs.php.net/viewvc.cgi/php-src/ext/standard/string.c?r1=1.445.2

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c /ext/standard/tests/strings bug40704.phpt

2007-03-03 Thread Ilia Alshanetsky
iliaa Sat Mar 3 15:46:29 2007 UTC Added files: (Branch: PHP_5_2) /php-src/ext/standard/tests/strings bug40704.phpt Modified files: /php-src/ext/standard string.c Log: Fixed bug #40704 (strip_tags() does not handle single quotes c

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2007-02-26 Thread Ilia Alshanetsky
iliaa Tue Feb 27 00:15:21 2007 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard string.c Log: Fixed bug #40637 (Regression in strip_tags() in relation so quote handling) http://cvs.php.net/viewvc.cgi/php-src/ext/standard/string.c?r1=1.445

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2007-02-13 Thread Ilia Alshanetsky
iliaa Tue Feb 13 23:55:20 2007 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard string.c Log: Make sure p is not pointing to the start of the buffer http://cvs.php.net/viewvc.cgi/php-src/ext/standard/string.c?r1=1.445.2.14.2.40&r2=1.445.2

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2007-02-09 Thread Antony Dovgal
tony2001Sat Feb 10 00:48:28 2007 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard string.c Log: MFH http://cvs.php.net/viewvc.cgi/php-src/ext/standard/string.c?r1=1.445.2.14.2.38&r2=1.445.2.14.2.39&diff_format=u Index: php-src/ext/stan

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2007-02-01 Thread Antony Dovgal
tony2001Thu Feb 1 13:45:25 2007 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard string.c Log: fix leaks on error http://cvs.php.net/viewvc.cgi/php-src/ext/standard/string.c?r1=1.445.2.14.2.37&r2=1.445.2.14.2.38&diff_format=u Index: p

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2007-01-08 Thread Ilia Alshanetsky
iliaa Mon Jan 8 14:24:59 2007 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard string.c Log: Use safe_emalloc() rather then emalloc() http://cvs.php.net/viewvc.cgi/php-src/ext/standard/string.c?r1=1.445.2.14.2.36&r2=1.445.2.14.2.37&diff_

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2006-12-20 Thread Antony Dovgal
tony2001Wed Dec 20 23:36:56 2006 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard string.c Log: MFH http://cvs.php.net/viewvc.cgi/php-src/ext/standard/string.c?r1=1.445.2.14.2.34&r2=1.445.2.14.2.35&diff_format=u Index: php-src/ext/stan

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2006-12-20 Thread Antony Dovgal
tony2001Wed Dec 20 23:30:30 2006 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard string.c Log: MFH http://cvs.php.net/viewvc.cgi/php-src/ext/standard/string.c?r1=1.445.2.14.2.33&r2=1.445.2.14.2.34&diff_format=u Index: php-src/ext/stan

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2006-12-13 Thread Ilia Alshanetsky
iliaa Wed Dec 13 15:39:12 2006 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard string.c Log: Removed deadcode found by Ron Korving http://cvs.php.net/viewvc.cgi/php-src/ext/standard/string.c?r1=1.445.2.14.2.30&r2=1.445.2.14.2.31&diff_format

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2006-10-11 Thread Ilia Alshanetsky
iliaa Wed Oct 11 14:19:55 2006 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard string.c Log: Catch empty strings right away. http://cvs.php.net/viewvc.cgi/php-src/ext/standard/string.c?r1=1.445.2.14.2.26&r2=1.445.2.14.2.27&diff_format=u Ind

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c /ext/standard/tests/strings str_word_count.phpt str_word_count1.phpt

2006-10-11 Thread Antony Dovgal
tony2001Wed Oct 11 13:15:30 2006 UTC Added files: (Branch: PHP_5_2) /php-src/ext/standard/tests/strings str_word_count1.phpt Modified files: /php-src/ext/standard string.c /php-src/ext/standard/tests/strings str_word_count.phpt

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2006-10-05 Thread Andrei Zmievski
andrei Thu Oct 5 18:23:21 2006 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard string.c Log: Increment replace count value for case-sensitive single char searches. http://cvs.php.net/viewvc.cgi/php-src/ext/standard/string.c?r1=1.445.2.14.2.

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2006-10-02 Thread Andrei Zmievski
andrei Mon Oct 2 20:07:14 2006 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard string.c Log: Use php_error_docref() instead. http://cvs.php.net/viewvc.cgi/php-src/ext/standard/string.c?r1=1.445.2.14.2.21&r2=1.445.2.14.2.22&diff_format=u Ind

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2006-10-02 Thread Andrei Zmievski
andrei Mon Oct 2 19:58:15 2006 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard string.c Log: More offset fixes. Added E_NOTICE where appropriate. http://cvs.php.net/viewvc.cgi/php-src/ext/standard/string.c?r1=1.445.2.14.2.20&r2=1.445.2.14.2

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2006-10-02 Thread Andrei Zmievski
andrei Mon Oct 2 19:42:42 2006 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard string.c Log: Fix invalid memory access in strrpos(). http://cvs.php.net/viewvc.cgi/php-src/ext/standard/string.c?r1=1.445.2.14.2.19&r2=1.445.2.14.2.20&diff_form

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2006-08-31 Thread Antony Dovgal
tony2001Thu Aug 31 14:21:21 2006 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard string.c Log: more z/Z fixes http://cvs.php.net/viewvc.cgi/php-src/ext/standard/string.c?r1=1.445.2.14.2.18&r2=1.445.2.14.2.19&diff_format=u Index: php-s

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2006-08-29 Thread Ilia Alshanetsky
iliaa Tue Aug 29 19:50:05 2006 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard string.c Log: Corrected problems introduced by previous commit. # Issue found by Stefan http://cvs.php.net/viewvc.cgi/php-src/ext/standard/string.c?r1=1.445

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2006-08-29 Thread Ilia Alshanetsky
iliaa Tue Aug 29 14:32:16 2006 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard string.c Log: Finalize implode() patch http://cvs.php.net/viewvc.cgi/php-src/ext/standard/string.c?r1=1.445.2.14.2.16&r2=1.445.2.14.2.17&diff_format=u Index: php

Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2006-08-29 Thread Derick Rethans
On Tue, 29 Aug 2006, Antony Dovgal wrote: > On 29.08.2006 17:29, Stefan Esser wrote: > > > > It actually doesn't matter what you meant. > > > I'll take this as "sorry", but you really need to learn to say it > > > yourself. > > > > > Antony, you are unbelievable. Do you think you are funny? Do yo

Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2006-08-29 Thread Stefan Esser
> First of all, change your attitude NOW. I'm not your son and you're > not my father to tell me what to do and how. > > And next time when your groundless attack fails, be so smart to > apologize. Groundless attack? Ohh... Okay that obviously means, you cannot see the overflow. Okay I will fix it

Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2006-08-29 Thread Antony Dovgal
On 29.08.2006 17:29, Stefan Esser wrote: It actually doesn't matter what you meant. I'll take this as "sorry", but you really need to learn to say it yourself. Antony, you are unbelievable. Do you think you are funny? Do you think it is funny to have overflows all over the code because people

Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2006-08-29 Thread Stefan Esser
>> It actually doesn't matter what you meant. > I'll take this as "sorry", but you really need to learn to say it > yourself. > Antony, you are unbelievable. Do you think you are funny? Do you think it is funny to have overflows all over the code because people like you are commiting this crap co

Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2006-08-29 Thread Antony Dovgal
On 29.08.2006 17:15, Stefan Esser wrote: Your imagination is just fabulous. "so please think twice before optimizing" means "be careful and do not try to optimize this code, even though it looks like it can be optimized by moving the emalloc() call to the beginning of the function". Please try to

Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2006-08-29 Thread Stefan Esser
> Your imagination is just fabulous. > "so please think twice before optimizing" means "be careful and do not > try to optimize this code, even though it looks like it can be > optimized by moving the emalloc() call to the beginning of the function". > Please try to understand what I've really sai

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2006-08-29 Thread Antony Dovgal
tony2001Tue Aug 29 12:20:18 2006 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard string.c Log: fix win32 build EG(precision) can be changed in runtime, even in php_implode() (hint: __toString()), so please think twice before optimizing

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2006-08-28 Thread Antony Dovgal
tony2001Mon Aug 28 09:56:29 2006 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard string.c Log: fix ZTS build http://cvs.php.net/viewvc.cgi/php-src/ext/standard/string.c?r1=1.445.2.14.2.13&r2=1.445.2.14.2.14&diff_format=u Index: php-sr

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2006-08-27 Thread Ilia Alshanetsky
iliaa Sun Aug 27 19:06:09 2006 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard string.c Log: Optimize the operation of implode() on non-string parameters http://cvs.php.net/viewvc.cgi/php-src/ext/standard/string.c?r1=1.445.2.14.2.12&r2=1.44

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c

2006-08-22 Thread Antony Dovgal
tony2001Tue Aug 22 19:55:56 2006 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard string.c Log: fix implode() function (see http://news.php.net/php.qa/26876) add test http://cvs.php.net/viewvc.cgi/php-src/ext/standard/string.c?r1=1.4

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c /ext/standard/tests/strings strings001.phpt

2006-08-08 Thread Antony Dovgal
tony2001Tue Aug 8 10:22:26 2006 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/standard string.c /php-src/ext/standard/tests/strings strings001.phpt Log: use memrchr/zend_memrchr instead of strrchr http://cvs.php.net/viewvc.cgi/php-src/

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c /ext/standard/tests/strings pathinfo.phpt

2006-07-16 Thread Antony Dovgal
tony2001Mon Jul 17 06:45:08 2006 UTC Added files: (Branch: PHP_5_2) /php-src/ext/standard/tests/strings pathinfo.phpt Modified files: /php-src/ext/standard string.c Log: MFH http://cvs.php.net/viewvc.cgi/php-src/ext/stand

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard string.c /ext/standard/tests/strings stripos.phpt

2006-07-12 Thread Antony Dovgal
tony2001Wed Jul 12 12:33:48 2006 UTC Added files: (Branch: PHP_5_2) /php-src/ext/standard/tests/strings stripos.phpt Modified files: /php-src/ext/standard string.c Log: fix invalid read - no need to compare strings if haystack