[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c /ext/standard/tests/array array_multisort_variation11.phpt

2009-05-15 Thread Christopher Jones
sixdFri May 15 16:46:23 2009 UTC Added files: (Branch: PHP_5_3) /php-src/ext/standard/tests/array array_multisort_variation11.phpt Modified files: /php-src/ext/standard array.c Log: MFH: New array_multisort() test and code

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c

2009-05-15 Thread Moriyoshi Koizumi
moriyoshi Fri May 15 17:03:03 2009 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/standard array.c Log: * MFH: Roll it back. http://cvs.php.net/viewvc.cgi/php-src/ext/standard/array.c?r1=1.308.2.21.2.37.2.55r2=1.308.2.21.2.37.2.56diff_format=u

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c

2009-05-10 Thread Etienne Kneuss
colder Sun May 10 16:45:21 2009 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/standard array.c Log: MFB: Fix #48224 (Remove incorrect shuffle)

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c

2009-05-10 Thread Johannes Schlüter
On Sun, 2009-05-10 at 16:45 +, Etienne Kneuss wrote: colderSun May 10 16:45:21 2009 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/standard array.c Log: MFB: Fix #48224 (Remove incorrect shuffle) Any chance to cover this in a test? - I

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c

2009-05-10 Thread Etienne Kneuss
2009/5/10 Johannes Schlüter johan...@php.net: On Sun, 2009-05-10 at 16:45 +, Etienne Kneuss wrote: colder                Sun May 10 16:45:21 2009 UTC   Modified files:              (Branch: PHP_5_3)     /php-src/ext/standard     array.c   Log:   MFB: Fix #48224 (Remove incorrect

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c

2009-02-13 Thread Andrei Zmievski
andrei Fri Feb 13 22:34:15 2009 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/standard array.c Log: Revert bogus fix for #47370. http://cvs.php.net/viewvc.cgi/php-src/ext/standard/array.c?r1=1.308.2.21.2.37.2.52r2=1.308.2.21.2.37.2.53diff_format=u

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c

2009-02-12 Thread Moriyoshi Koizumi
moriyoshi Thu Feb 12 18:57:55 2009 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/standard array.c Log: * MFH: Fix bug #47370 (BC breakage of array_unique())

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c /ext/standard/tests/array bug46873.phpt

2008-12-26 Thread Arnaud Le Blanc
lbarnaudSat Dec 27 03:06:57 2008 UTC Added files: (Branch: PHP_5_3) /php-src/ext/standard/tests/array bug46873.phpt Modified files: /php-src/ext/standard array.c Log: MFH: Fixed bug #46873 (extract($foo) crashes if

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c

2008-12-12 Thread Andrei Zmievski
andrei Fri Dec 12 19:20:49 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/standard array.c Log: MFH http://cvs.php.net/viewvc.cgi/php-src/ext/standard/array.c?r1=1.308.2.21.2.37.2.47r2=1.308.2.21.2.37.2.48diff_format=u Index:

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c

2008-12-12 Thread Hannes Magnusson
Could you maybe fix the at-least-four-tests that broke, and maybe add a new test for this feature? :) And NEWS entry, [DOC], update the wiki... -Hannes On Fri, Dec 12, 2008 at 20:20, Andrei Zmievski and...@php.net wrote: andrei Fri Dec 12 19:20:49 2008 UTC Modified files:

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c

2008-12-12 Thread Andrei Zmievski
Easy, there. I realized that there were 4 tests that broke after committing it. The issue is that I made SORT_REGULAR to be the default, which is not what the tests were expecting. The easiest way to fix the tests is to make them pass SORT_STRING to array_unique(), I guess. The rest is

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c basic_functions.c

2008-11-25 Thread Antony Dovgal
On 24.11.2008 21:12, Stanislav Malyshev wrote: stas Mon Nov 24 18:12:17 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/standard array.c basic_functions.c Log: restore BC for arrays [DOC] natsort, natcasesort, usort, uasort, uksort,

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c basic_functions.c

2008-11-25 Thread Stanislav Malyshev
Hi! All these tests fail after your patch: /local/qa/5_3.zts/ext/standard/tests/array/array_key_exists.phpt /local/qa/5_3.zts/ext/standard/tests/array/array_key_exists_object1.phpt /local/qa/5_3.zts/ext/standard/tests/array/array_key_exists_object2.phpt

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c basic_functions.c

2008-11-25 Thread Antony Dovgal
On 25.11.2008 12:15, Stanislav Malyshev wrote: Hi! All these tests fail after your patch: ... These tests expect BC breakage, which this patch fixes. So they need to be fixed, I guess. Does this mean you didn't run the tests before applying the patch? Or does this mean you've just ignored

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c /ext/standard/tests/array extract_variation10.phpt extract_variation11.phpt

2008-11-25 Thread Arnaud Le Blanc
lbarnaudWed Nov 26 00:59:41 2008 UTC Added files: (Branch: PHP_5_3) /php-src/ext/standard/tests/array extract_variation10.phpt extract_variation11.phpt Modified files: /php-src/ext/standard

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c basic_functions.c

2008-11-24 Thread Stanislav Malyshev
stasMon Nov 24 18:12:17 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/standard array.c basic_functions.c Log: restore BC for arrays [DOC] natsort, natcasesort, usort, uasort, uksort, array_flip, array_unique still won't work with objects

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c assert.c basic_functions.c browscap.c crypt.c file.c filestat.c head.c html.c http.c info.c mail.c math.c proc_open.c rand.c streamsfuncs.c st

2008-10-22 Thread Nuno Lopes
always look to the code first to check if the initialization is really needed. Thanks, Nuno - Original Message - From: Arnaud Le Blanc [EMAIL PROTECTED] To: php-cvs@lists.php.net Sent: Tuesday, October 21, 2008 11:08 PM Subject: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c assert.c basic_functions.c browscap.c crypt.c file.c filestat.c head.c html.c http.c info.c mail.c math.c proc_open.c rand.c streamsfuncs.c string

2008-10-21 Thread Arnaud Le Blanc
lbarnaudTue Oct 21 22:08:39 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/standard array.c assert.c basic_functions.c browscap.c crypt.c file.c filestat.c head.c html.c http.c

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c /ext/standard/tests/array max.phpt max_error.phpt min.phpt min_error.phpt

2008-08-10 Thread Felipe Pena
felipe Sun Aug 10 17:50:45 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/standard array.c /php-src/ext/standard/tests/array max.phpt max_error.phpt min.phpt min_error.phpt Log: - MFH: New parameter

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c basic_functions.c php_array.h /ext/standard/tests array_replace.phpt

2008-07-31 Thread Johannes Schlüter
johannesThu Jul 31 20:18:17 2008 UTC Added files: (Branch: PHP_5_3) /php-src/ext/standard/tests array_replace.phpt Modified files: /php-src/ext/standard array.c basic_functions.c php_array.h Log: MFH (DOC] Add

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c

2008-07-23 Thread Felipe Pena
felipe Wed Jul 23 16:28:46 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/standard array.c Log: - MFH: Fixed bug #45605 (array_uintersect_assoc gives incorrect error message)

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c

2008-07-23 Thread Felipe Pena
felipe Thu Jul 24 03:07:23 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/standard array.c Log: - MFH: Improved parameter handling

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c

2008-07-09 Thread Etienne Kneuss
colder Wed Jul 9 21:29:53 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/standard array.c Log: MFH: Fix resolution rule of count vs. handler

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c

2008-06-02 Thread Matt Wilmas
mattwil Mon Jun 2 11:20:59 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/standard array.c Log: MFH: Initialize with length instead of 0

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c string.c var_unserializer.re ZendEngine2 zend_API.c zend_API.h zend_builtin_functions.c zend_object_handlers.c

2008-06-02 Thread Antony Dovgal
Please do not forget to run Valgrind when you commit patches like this (i.e. affecting the basics of the engine). If you're a Windows user, you can either wait for gcov.php.net reports or ask me about it (I do valgrind runs every day anyway). On 27.05.2008 14:29, Matt Wilmas wrote: mattwil

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c

2008-06-02 Thread Antony Dovgal
tony2001Mon Jun 2 10:27:55 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/standard array.c Log: fix uninitialized variable

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c

2008-05-30 Thread Matt Wilmas
mattwil Fri May 30 10:55:15 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/standard array.c Log: MFH: Only check args once in php_array_diff_key/intersect_key, not on each iteration. This also makes sure ALL args are checked (pre-5.2.5 behavior) -

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c /ext/standard/tests/array array_slice_variation6.phpt

2008-05-18 Thread Felipe Pena
felipe Sun May 18 15:42:09 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/standard array.c /php-src/ext/standard/tests/array array_slice_variation6.phpt Log: - Making compatible with 64bit plataform

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c

2008-05-04 Thread Antony Dovgal
tony2001Sun May 4 11:26:51 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/standard array.c Log: fix compile warnings http://cvs.php.net/viewvc.cgi/php-src/ext/standard/array.c?r1=1.308.2.21.2.37.2.28r2=1.308.2.21.2.37.2.29diff_format=u

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c /ext/standard/tests/array bug42177.phpt

2008-03-12 Thread Felipe Pena
felipe Wed Mar 12 19:18:42 2008 UTC Added files: (Branch: PHP_5_3) /php-src/ext/standard/tests/array bug42177.phpt Modified files: /php-src/ext/standard array.c Log: MFB: Fixed bug #42177 (Warning array_merge_recursive(): recursion

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c

2008-02-22 Thread Felipe Pena
felipe Fri Feb 22 13:28:40 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/standard array.c Log: Fixed Bug #44212 (array_diff_assoc not reporting missing arguments)

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c

2008-02-15 Thread Antony Dovgal
tony2001Fri Feb 15 09:33:09 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/standard array.c Log: MFH: recursion protection in count()

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c

2008-02-14 Thread Dmitry Stogov
dmitry Thu Feb 14 08:46:25 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/standard array.c Log: Fixed memory leak http://cvs.php.net/viewvc.cgi/php-src/ext/standard/array.c?r1=1.308.2.21.2.37.2.22r2=1.308.2.21.2.37.2.23diff_format=u Index:

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c

2008-02-14 Thread Felipe Pena
felipe Thu Feb 14 14:08:22 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/standard array.c Log: MFB: Fixed Bug #42838 (Wrong results in array_diff_uassoc)

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c

2008-02-12 Thread Felipe Pena
Em Ter, 2008-02-12 às 18:50 +0100, Hannes Magnusson escreveu: On Feb 12, 2008 2:31 AM, Felipe Pena [EMAIL PROTECTED] wrote: felipe Tue Feb 12 01:31:12 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/standard array.c Log: array_slice() -

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c

2008-02-12 Thread Hannes Magnusson
On Feb 12, 2008 2:31 AM, Felipe Pena [EMAIL PROTECTED] wrote: felipe Tue Feb 12 01:31:12 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/standard array.c Log: array_slice() - Fixed behavior when NULL is given in third parameter (BC) This is

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c

2008-02-11 Thread Antony Dovgal
tony2001Mon Feb 11 13:34:42 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/standard array.c Log: MFH http://cvs.php.net/viewvc.cgi/php-src/ext/standard/array.c?r1=1.308.2.21.2.37.2.20r2=1.308.2.21.2.37.2.21diff_format=u Index:

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c

2008-02-11 Thread Felipe Pena
felipe Tue Feb 12 01:31:12 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/standard array.c Log: array_slice() - Fixed behavior when NULL is given in third parameter (BC)

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c

2008-01-28 Thread Antony Dovgal
tony2001Tue Jan 29 00:39:46 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/standard array.c Log: MFH: fix #43596 (array_slice(): $length arg ignored when it is 0)

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c

2008-01-25 Thread Antony Dovgal
tony2001Fri Jan 25 13:42:36 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/standard array.c Log: MFH: endless loop (and stack overflow) protection in compact()

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c

2008-01-25 Thread Rob Richards
rrichards Fri Jan 25 15:52:48 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/standard array.c Log: MFH: fix zts build http://cvs.php.net/viewvc.cgi/php-src/ext/standard/array.c?r1=1.308.2.21.2.37.2.16r2=1.308.2.21.2.37.2.17diff_format=u

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c /ext/standard/tests/array bug42850.phpt

2008-01-14 Thread Brian Shire
shire Mon Jan 14 22:09:52 2008 UTC Added files: (Branch: PHP_5_3) /php-src/ext/standard/tests/array bug42850.phpt Modified files: /php-src/ext/standard array.c Log: MFH: Fix bug #42850 array_walk_recursive() leaves references,

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c /ext/standard/tests/array array_slice.phpt bug43541.phpt

2007-12-11 Thread Jani Taskinen
janiTue Dec 11 09:47:21 2007 UTC Added files: (Branch: PHP_5_3) /php-src/ext/standard/tests/array bug43541.phpt Modified files: /php-src/ext/standard array.c /php-src/ext/standard/tests/array array_slice.phpt Log: MFH: -

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c /ext/standard/tests/array array_slice.phpt bug43541.phpt

2007-12-11 Thread Steph Fox
PROTECTED] To: php-cvs@lists.php.net Sent: Tuesday, December 11, 2007 9:47 AM Subject: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c /ext/standard/tests/array array_slice.phpt bug43541.phpt jani Tue Dec 11 09:47:21 2007 UTC Added files: (Branch: PHP_5_3) /php-src

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c /ext/standard/tests/array bug43495.phpt

2007-12-05 Thread Ilia Alshanetsky
iliaa Wed Dec 5 19:55:32 2007 UTC Added files: (Branch: PHP_5_3) /php-src/ext/standard/tests/array bug43495.phpt Modified files: /php-src/ext/standard array.c Log: Fixed bug #43495 (array_merge_recursive() crashes with recursive

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c

2007-12-03 Thread Ilia Alshanetsky
iliaa Mon Dec 3 14:13:27 2007 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/standard array.c Log: MFB: Fixed bug #43482 (array_pad() does not warn on very small pad numbers).

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c

2007-11-25 Thread Ilia Alshanetsky
iliaa Sun Nov 25 15:56:07 2007 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/standard array.c Log: Fixed bug #43386 (array_globals not reset to 0 properly on init)

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c /ext/standard/tests/array array_intersect_assoc_error.phpt array_intersect_assoc_variation1.phpt array_intersect_assoc_variation2.phpt

2007-11-06 Thread Jani Taskinen
janiTue Nov 6 13:26:59 2007 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/standard array.c /php-src/ext/standard/tests/array array_intersect_assoc_error.phpt array_intersect_assoc_variation1.phpt

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c

2007-11-05 Thread Ilia Alshanetsky
iliaa Mon Nov 5 23:53:23 2007 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/standard array.c Log: Fixed bug #43197 (array_intersect_assoc() does not emit warning messages for error inputs)

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c /ext/standard/tests/array max.phpt min.phpt /ext/standard/tests/file fgetc_basic.phpt fgetc_variation4.phpt

2007-10-31 Thread Jani Taskinen
janiWed Oct 31 13:39:26 2007 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/standard array.c /php-src/ext/standard/tests/array max.phpt min.phpt /php-src/ext/standard/tests/filefgetc_basic.phpt

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c

2007-10-18 Thread Scott MacVicar
scottmacThu Oct 18 14:33:14 2007 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/standard array.c Log: Fixed bug #43020 (Warning message is missing with shuffle() and more than one argument)

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c

2007-10-02 Thread Antony Dovgal
tony2001Tue Oct 2 10:04:38 2007 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/standard array.c Log: MF5_2: improved recursion detection in array_walk() fixes #42752, though the leaks are still there

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard array.c php_var.h

2007-10-01 Thread Jani Taskinen
janiMon Oct 1 12:34:19 2007 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/standard array.c php_var.h Log: MFH: sync (adds php_prefix_varname() API function)