[PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ NEWS

2011-05-25 Thread Rasmus Lerdorf
rasmus Wed, 25 May 2011 19:58:41 + Revision: http://svn.php.net/viewvc?view=revisionrevision=311421 Log: This isn't in Changed paths: U php/php-src/branches/PHP_5_4/NEWS Modified: php/php-src/branches/PHP_5_4/NEWS

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/ext/standard/filestat.c branches/PHP_5_4/ext/standard/tests/file/userstreams_007.phpt branches/PHP_5_4/main/php_streams.h branch

2011-05-25 Thread Hannes Magnusson
There seem to be a lot of unrelated code cleanup here, and I am in general a bit confused in this code. Could you review http://php.net/streamwrapper and write up the changes to it? -Hannes On Wed, May 25, 2011 at 23:03, Stanislav Malyshev s...@php.net wrote: stas                                

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/ext/standard/filestat.c branches/PHP_5_4/ext/standard/tests/file/userstreams_007.phpt branches/PHP_5_4/main/php_streams.h branch

2011-05-25 Thread Stas Malyshev
Hi! There seem to be a lot of unrelated code cleanup here, and I am in general a bit confused in this code. Could you review http://php.net/streamwrapper and write up the changes to it? There shouldn't be any changes except for adding one stream handler (see rfc:

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/ext/standard/filestat.c branches/PHP_5_4/ext/standard/tests/file/userstreams_007.phpt branches/PHP_5_4/main/php_streams.h branch

2011-05-25 Thread Pierre Joye
hi, Besides that, did we even approve that change? Gustavo and I were two that did not like the current implemenation/design. Cheers, On Wed, May 25, 2011 at 11:24 PM, Stas Malyshev smalys...@gmail.com wrote: Hi! There seem to be a lot of unrelated code cleanup here, and I am in general a

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/ext/standard/filestat.c branches/PHP_5_4/ext/standard/tests/file/userstreams_007.phpt branches/PHP_5_4/main/php_streams.h branch

2011-05-25 Thread Stas Malyshev
Hi! Besides that, did we even approve that change? Gustavo and I were two that did not like the current implemenation/design. There were no objections and/or proposals for improving it since I posted the patch, which as about 2 months ago, so I assumed it's ok. If you have any specific

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/standard/filestat.c trunk/ext/standard/filestat.c

2011-05-25 Thread Felipe Pena
felipe Wed, 25 May 2011 22:23:48 + Revision: http://svn.php.net/viewvc?view=revisionrevision=311423 Log: - Fixed ZTS build and removed unused vars Changed paths: U php/php-src/branches/PHP_5_4/ext/standard/filestat.c U

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/ext/standard/filestat.c branches/PHP_5_4/ext/standard/tests/file/userstreams_007.phpt branches/PHP_5_4/main/php_streams.h branch

2011-05-25 Thread Pierre Joye
On Thu, May 26, 2011 at 12:04 AM, Stas Malyshev smalys...@sugarcrm.com wrote: Hi! Besides that, did we even approve that change? Gustavo and I were two that did not like the current implemenation/design. There were no objections and/or proposals for improving it since I posted the patch,

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/ext/standard/filestat.c branches/PHP_5_4/ext/standard/tests/file/userstreams_007.phpt branches/PHP_5_4/main/php_streams.h branch

2011-05-25 Thread Stas Malyshev
Hi! No time to actually proper design and propose alternatives yet. That does mean we have to accept something just because it is ready. Sorry No, I think if we have working solution for a real problem, even if it's not perfect - it is the reason to use it and I can vaguely imagine