[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/win32/build/libs_version.txt branches/PHP_5_4/win32/build/libs_version.txt trunk/win32/build/libs_version.txt

2011-07-19 Thread Pierre Joye
pajoye Tue, 19 Jul 2011 10:22:42 + Revision: http://svn.php.net/viewvc?view=revision&revision=313417 Log: - update libpng to 1.2.46 Changed paths: U php/php-src/branches/PHP_5_3/win32/build/libs_version.txt U php/php-src/branches/PHP_5_4/win32/bu

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/php.ini-development branches/PHP_5_4/php.ini-production trunk/php.ini-development trunk/php.ini-production

2011-07-19 Thread Pierre Joye
pajoye Tue, 19 Jul 2011 12:02:22 + Revision: http://svn.php.net/viewvc?view=revision&revision=313421 Log: - cleanup Changed paths: U php/php-src/branches/PHP_5_4/php.ini-development U php/php-src/branches/PHP_5_4/php.ini-production U php/ph

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/sapi/cli/php_cli_server.c trunk/sapi/cli/php_cli_server.c

2011-07-19 Thread Moriyoshi Koizumi
moriyoshiTue, 19 Jul 2011 17:47:34 + Revision: http://svn.php.net/viewvc?view=revision&revision=313441 Log: - Print HTTP method as well in the log. - Print response code also when the request is processed by a script. - Those changes partly closes #55109. Bug:

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/sapi/cli/php_cli_server.c trunk/sapi/cli/php_cli_server.c

2011-07-19 Thread Moriyoshi Koizumi
moriyoshiTue, 19 Jul 2011 18:00:16 + Revision: http://svn.php.net/viewvc?view=revision&revision=313442 Log: - Buffers are local to the blocks where they belong. Changed paths: U php/php-src/branches/PHP_5_4/sapi/cli/php_cli_server.c U php/php-src/t

[PHP-CVS] svn: /SVNROOT/ global_avail

2011-07-19 Thread David Soria Parra
dsp Tue, 19 Jul 2011 18:08:09 + Revision: http://svn.php.net/viewvc?view=revision&revision=313443 Log: give fa php-src karma to commit cli-webserver patches Changed paths: U SVNROOT/global_avail Modified: SVNROOT/global_avail ==

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/sapi/cli/php_cli_server.c trunk/sapi/cli/php_cli_server.c

2011-07-19 Thread Moriyoshi Koizumi
moriyoshiTue, 19 Jul 2011 18:17:25 + Revision: http://svn.php.net/viewvc?view=revision&revision=313444 Log: - Fixed bug #55107 (Null bytes in URL cause insecure behavior (code execution / code disclosure)). Bug: https://bugs.php.net/55107 (Verified) Null byte

[PHP-CVS] svn: /php/php-src/trunk/ext/interbase/ ibase_query.c

2011-07-19 Thread Popa Adrian Marius
mariuz Tue, 19 Jul 2011 20:08:42 + Revision: http://svn.php.net/viewvc?view=revision&revision=313445 Log: Fix for bug http://bugs.php.net/54426 Checks for NULL are wrong as the values can be provided by the triggers Changed paths: U php/php-src/trunk/

[PHP-CVS] svn: /php/php-src/branches/PHP_5_4/ext/interbase/ ibase_query.c

2011-07-19 Thread Popa Adrian Marius
mariuz Tue, 19 Jul 2011 20:23:26 + Revision: http://svn.php.net/viewvc?view=revision&revision=313446 Log: Fix for bug http://bugs.php.net/54426 Checks for NULL are wrong as the values can be provided by the triggers Changed paths: U php/php-src/branch

[PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ext/interbase/ ibase_query.c

2011-07-19 Thread Popa Adrian Marius
mariuz Tue, 19 Jul 2011 20:25:51 + Revision: http://svn.php.net/viewvc?view=revision&revision=313447 Log: Fix for bug http://bugs.php.net/54426 Checks for NULL are wrong as the values can be provided by the triggers Changed paths: U php/php-src/branch

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/standard/php_crypt_r.c branches/PHP_5_4/ext/standard/php_crypt_r.c trunk/ext/standard/php_crypt_r.c

2011-07-19 Thread Felipe Pena
felipe Tue, 19 Jul 2011 22:12:13 + Revision: http://svn.php.net/viewvc?view=revision&revision=313452 Log: - Fixed bug #55231 (Unsatisfied symbols __sync_fetch_and_add_4) Bug: https://bugs.php.net/55231 (Feedback) Unsatisfied symbols __sync_fetch_and_add_4

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/openssl/openssl.c branches/PHP_5_4/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2011-07-19 Thread Scott MacVicar
scottmac Tue, 19 Jul 2011 22:15:56 + Revision: http://svn.php.net/viewvc?view=revision&revision=313453 Log: openssl_encrypt() / openssl_decrypt() were flawed and truncated the key to the default size for the case of a variable key length cipher. The result is

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2011-07-19 Thread Scott MacVicar
scottmac Tue, 19 Jul 2011 22:29:55 + Revision: http://svn.php.net/viewvc?view=revision&revision=313455 Log: Revert change to use a special Windows version of openssl_random_pseudo_bytes(). Lets discuss this on internals first. We're advertising something from

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/sapi/fpm/fpm/fpm_conf.c trunk/sapi/fpm/fpm/fpm_conf.c

2011-07-19 Thread Jérôme Loyet
fat Tue, 19 Jul 2011 22:38:04 + Revision: http://svn.php.net/viewvc?view=revision&revision=313456 Log: - Dropped restriction of not setting the same value multiple times, the last one holds (giovanni at giacobbi dot net) Changed paths: U php/php-sr

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2011-07-19 Thread Pierre Joye
Please restore that, now. That's not your cup of tea and it is the way it should have been in the 1st place. On Wed, Jul 20, 2011 at 12:29 AM, Scott MacVicar wrote: > scottmac                                 Tue, 19 Jul 2011 22:29:55 + > > Revision: http://svn.php.net/viewvc?view=revision&rev

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2011-07-19 Thread Pierre Joye
pajoye Tue, 19 Jul 2011 23:01:41 + Revision: http://svn.php.net/viewvc?view=revision&revision=313457 Log: - re apply the rng change specific to windows, long term it should be a std function but as this function was badly introduced in the 1st place, we have

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2011-07-19 Thread Scott MacVicar
Why isn't this fixed upstream? This is a horrible idea to make core changes like this without a discussion. I'll revert this again so we can at least have the opportunity to discuss this. S On 19 Jul 2011, at 15:55, Pierre Joye wrote: > Please restore that, now. That's not your cup of tea and

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2011-07-19 Thread Pierre Joye
Why did you not ask in the 1st place before reverting it? Please don't waste our time with such things. Users expect this (tested) fix in the next releases. Now, openssl has lower minimum windows version support that we do, and does all possible things to improve the entropy, which is not require

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2011-07-19 Thread Scott MacVicar
Why did you even commit such a change without discussing it? I understand your logic for doing this but there was no RFC or discussion around the impact of this. OpenSSL has been FIPS certified, your change has changed this contract and it's calling back into a Windows API. Has it been reviewed

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2011-07-19 Thread Pierre Joye
hi, On Wed, Jul 20, 2011 at 1:50 AM, Scott MacVicar wrote: > Why did you even commit such a change without discussing it? I maintain this part of the OpenSsl extension and the php windows port. There was a horrible bug and slowdown with this code and I fixed it. Users tested it and are happy wit

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2011-07-19 Thread Pierre Joye
On Wed, Jul 20, 2011 at 1:50 AM, Scott MacVicar wrote: > OpenSSL has been FIPS certified, your change has changed this contract and > it's calling back into a Windows API. Has it been reviewed for correctness? And by the way, the CryptoAPI for the windows versions we support is certified as well

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/sapi/cli/php_cli_server.c trunk/sapi/cli/php_cli_server.c

2011-07-19 Thread Moriyoshi Koizumi
moriyoshiWed, 20 Jul 2011 04:34:01 + Revision: http://svn.php.net/viewvc?view=revision&revision=313464 Log: - Fixed bug #55073 (PHP-CLI-webserver does not listen on ipv6 interfaces), letting getaddrinfo(3) validate IPv6 addresses. Bug: https://bugs.php.net/55