[PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/zend_API.c trunk/NEWS trunk/Zend/zend_API.c

2012-02-27 Thread Xinchen Hui
On Tue, Feb 28, 2012 at 10:38 AM, Xinchen Hui wrote: > On Tue, Feb 28, 2012 at 1:10 AM, Anthony Ferrara wrote: >> I initially looked at the final fix when I discovered the issue. >> Follow me out on this.  This is the current code as-implemented in >> r323563: >> >>    265                 zval *o

[PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/zend_API.c trunk/NEWS trunk/Zend/zend_API.c

2012-02-27 Thread Xinchen Hui
On Tue, Feb 28, 2012 at 1:10 AM, Anthony Ferrara wrote: > I initially looked at the final fix when I discovered the issue. > Follow me out on this.  This is the current code as-implemented in > r323563: > >    265                 zval *obj; >    266                 MAKE_STD_ZVAL(obj); >    267    

[PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/zend_API.c trunk/NEWS trunk/Zend/zend_API.c

2012-02-27 Thread Anthony Ferrara
I initially looked at the final fix when I discovered the issue. Follow me out on this. This is the current code as-implemented in r323563: 265 zval *obj; 266 MAKE_STD_ZVAL(obj); 267 if (Z_OBJ_HANDLER_P(*arg, cast_object)(*arg, obj, type

[PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/zend_API.c trunk/NEWS trunk/Zend/zend_API.c

2012-02-27 Thread Xinchen Hui
Sent from my iPad 在 2012-2-28,0:10,Anthony Ferrara 写道: > Out of curiosity, why are you changing it to copy the object for the > result of the cast operation? cast_object should init the result > zval, so why go through the step of copying the starting object to plz look at the final fix: r32356

[PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/zend_API.c trunk/NEWS trunk/Zend/zend_API.c

2012-02-27 Thread Anthony Ferrara
Out of curiosity, why are you changing it to copy the object for the result of the cast operation? cast_object should init the result zval, so why go through the step of copying the starting object to it? Wouldn't it be easier just to do: if (Z_OBJ_HANDLER_PP(arg, cast_object)) {

[PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/zend_API.c trunk/NEWS trunk/Zend/zend_API.c

2012-02-27 Thread Richard Lynch
On Mon, February 27, 2012 2:31 am, Laruence wrote: > On Mon, Feb 27, 2012 at 4:00 PM, Dmitry Stogov > wrote: >> Hi Laruence, >> >> The attached patch looks wired. The patch on top of it (r323563) >> makes it >> better. However, in my opinion it fixes a common problem just in a >> single >> place.

[PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWSbranches/PHP_5_4/ext/session/config.m4 branches/PHP_5_4/ext/session/config.w32branches/PHP_5_4/ext/session/mod_user.c bran

2011-09-14 Thread Ferenc Kovacs
no problem, I just mentioned because it is easier to remember, and it should take care of the similar problems. On Wed, Sep 14, 2011 at 9:08 AM, Christian Stocker wrote: > > > On 14.09.11 09:00, Ferenc Kovacs wrote: >> ./vcsclean && ./buildconf --force > > ok, that helped. Thanks a lot and I shou

[PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWSbranches/PHP_5_4/ext/session/config.m4 branches/PHP_5_4/ext/session/config.w32branches/PHP_5_4/ext/session/mod_user.c bran

2011-09-14 Thread Christian Stocker
On 14.09.11 09:00, Ferenc Kovacs wrote: > ./vcsclean && ./buildconf --force ok, that helped. Thanks a lot and I should have known that chregu > > On Wed, Sep 14, 2011 at 8:07 AM, Laruence wrote: >> Hi, >> FYI, you might should delete the autom4te.cache folder too :-) >> >> thanks >> >> 2011

[PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWSbranches/PHP_5_4/ext/session/config.m4 branches/PHP_5_4/ext/session/config.w32branches/PHP_5_4/ext/session/mod_user.c bran

2011-09-14 Thread Ferenc Kovacs
./vcsclean && ./buildconf --force On Wed, Sep 14, 2011 at 8:07 AM, Laruence wrote: > Hi, >  FYI, you might should delete the autom4te.cache folder too :-) > > thanks > > 2011/9/14 Christian Stocker : >> Hi >> >> I still have this. even after re-running buildconf (and deleting >> configure before)

[PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/tests/bug53727.phpt branches/PHP_5_3/Zend/tests/is_a.phpt branches/PHP_

2011-07-08 Thread Daniel Convissor
Hi Folks: On Thu, Jul 07, 2011 at 02:20:50PM -0700, Stas Malyshev wrote: > > In fact, I'm not sure why would we need such warning at all. Unknown > class - return false, who cares? +1 Thanks, --Dan -- T H E A N A L Y S I S A N D S O L U T I O N S C O M P A N Y data intens

Re: [PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/tests/bug53727.phpt branches/PHP_5_3/Zend/tests/is_a.phpt branches/PHP_5_3/Zend/zend_builtin_fu

2011-07-07 Thread Stas Malyshev
Hi! On 7/7/11 2:08 PM, Johannes Schlüter wrote: On Thu, 2011-07-07 at 20:27 +0200, Pierre Joye wrote: what kind of troubles do they see? https://pear.php.net/bugs/bug.php?id=18656 Even if the Warning is good it's questionable for 5.3, especially during RC. Yes, I had problem with it too in

[PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/tests/bug53727.phpt branches/PHP_5_3/Zend/tests/is_a.phpt branches/PHP_5_3/Zend/zend_builtin_functi

2011-07-07 Thread Johannes Schlüter
On Thu, 2011-07-07 at 20:27 +0200, Pierre Joye wrote: > what kind of troubles do they see? https://pear.php.net/bugs/bug.php?id=18656 Even if the Warning is good it's questionable for 5.3, especially during RC. (note that warnings not only cause the error being reported, which can be switched off

[PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/tests/bug53727.phpt branches/PHP_5_3/Zend/tests/is_a.phpt branches/PHP_5_3/Zend/zend_builtin_functi

2011-07-07 Thread Pierre Joye
what kind of troubles do they see? 2011/7/7 Johannes Schlüter : > Hi, > > I was told (didn't verify) that this causes lots of trouble with PEAR > and other applications. We're in final RC phase of 5.3.7. I don't think > it is critical for 5.3.7 and I wonder whether we need it for 5.3 at all. > > j

Re: [PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_2/Zend/tests/bug51421.phpt branches/PHP_5_2/Zend/zend_compile.c branches/PHP_5_3/Zend/tests/bug51421.phpt branches/PHP_5_3

2010-06-28 Thread Etienne Kneuss
Hi, On Mon, Jun 28, 2010 at 20:17, Stas Malyshev wrote: > Hi! > > 1) arguments can be gathered dynamically in the function, using >> func_get_args. For that reason, PHP gracefully allow a call with too many >> arguments. >> > > Isn't it the case today? > It's the case at the time of the calls.

Re: [PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_2/Zend/tests/bug51421.phpt branches/PHP_5_2/Zend/zend_compile.c branches/PHP_5_3/Zend/tests/bug51421.phpt branches/PHP_5_3

2010-06-28 Thread Stas Malyshev
Hi! 1) arguments can be gathered dynamically in the function, using func_get_args. For that reason, PHP gracefully allow a call with too many arguments. Isn't it the case today? Maybe also we can add some syntax like: function foo($a, $b, ...) - where ... means "I'll deal with those arguments

[PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_2/Zend/tests/bug51421.phpt branches/PHP_5_2/Zend/zend_compile.c branches/PHP_5_3/Zend/tests/bug51421.phpt branches/PHP_5_3/Zen

2010-06-28 Thread Etienne Kneuss
Hi, 2010/6/28 Johannes Schlüter > Hi, > > On Sat, 2010-06-26 at 22:05 +, Felipe Pena wrote: > > felipe Sat, 26 Jun 2010 22:05:13 + > > > > Revision: http://svn.php.net/viewvc?view=revision&revision=300770 > > > > Log: > > - Fixed bug #51421 (Abstract __c

[PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/pdo/pdo_dbh.c branches/PHP_5_3/ext/pdo/php_pdo_driver.h branches/PHP_5_3/ext/pdo_pgsql/pdo_pgsql.c

2010-06-14 Thread Pierre Joye
> Here you are changing a structure which is allocated and initialized in > a driver and then read from the PDO core. PDO core will therefore read > invalid memory when a driver compiled against 5.3.2 is used in 5.3.3 > while we usually guarantee binary compatibility in bug fix releases. > > This f

[PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/branches/

2010-03-12 Thread Ferenc Kovacs
where did that mail come from? imho it should have been addressed to the mailing list directly. I agree that he was short-tempered, but I think that the progress worth it. Tyrael On Fri, Mar 12, 2010 at 3:43 PM, Pierre Joye wrote: > On Fri, Mar 12, 2010 at 3:38 PM, Lukas Kahwe Smith > wrote: