Re: [PHP-CVS] com php-src: Fix conversion from unsigned char to char: sapi/cgi/cgi_main.c

2013-04-29 Thread Stas Malyshev
Hi! Are you sure about this change? Because this actually changes the semantics of the code. The following piece of code will now evaluate differently than before: *p = ' ' I also don't understand this change - this means 0xFF would now be skipped as space while before it was not. Is it the

Re: [PHP-CVS] com php-src: Fix conversion from unsigned char to char: sapi/cgi/cgi_main.c

2013-04-29 Thread David Soria Parra
On 04/29/2013 12:49 AM, Stas Malyshev wrote: Hi! Are you sure about this change? Because this actually changes the semantics of the code. The following piece of code will now evaluate differently than before: *p = ' ' I also don't understand this change - this means 0xFF would now be

Re: [PHP-CVS] com php-src: Fix conversion from unsigned char to char: sapi/cgi/cgi_main.c

2013-04-27 Thread Nuno Lopes
Subject: [PHP-CVS] com php-src: Fix conversion from unsigned char to char: sapi/cgi/cgi_main.c Commit:bc50ba4bf971c62a1ff5b915a0c9f890b04c1087 Author:David Soria Parra d...@php.net Fri, 26 Apr 2013 10:55:52 +0200 Parents: 75cec90d8cc2ea34ab9e5e7146cb6b3bf29430a9 Branches: PHP

[PHP-CVS] com php-src: Fix conversion from unsigned char to char: sapi/cgi/cgi_main.c

2013-04-26 Thread David Soria Parra
Commit:bc50ba4bf971c62a1ff5b915a0c9f890b04c1087 Author:David Soria Parra d...@php.net Fri, 26 Apr 2013 10:55:52 +0200 Parents: 75cec90d8cc2ea34ab9e5e7146cb6b3bf29430a9 Branches: PHP-5.5 master Link: