[PHP-CVS] com php-src: Test for #63336, xfail now: Zend/tests/bug63336.phpt

2012-10-23 Thread Xinchen Hui
Commit:0b8b26410797921eaa44583273db938a15b7e837
Author:Xinchen Hui larue...@php.net Tue, 23 Oct 2012 16:35:56 
+0800
Parents:   74228c515197c8a3bda878a077d30c9b14482eb2
Branches:  PHP-5.4

Link:   
http://git.php.net/?p=php-src.git;a=commitdiff;h=0b8b26410797921eaa44583273db938a15b7e837

Log:
Test for #63336, xfail now

Bugs:
https://bugs.php.net/63336

Changed paths:
  A  Zend/tests/bug63336.phpt


Diff:
diff --git a/Zend/tests/bug63336.phpt b/Zend/tests/bug63336.phpt
new file mode 100644
index 000..3141290
--- /dev/null
+++ b/Zend/tests/bug63336.phpt
@@ -0,0 +1,24 @@
+--TEST--
+Bug #63336 (invalid E_NOTICE error occur)
+--XFAIL--
+Bug is not fixed yet
+--FILE--
+?php
+error_reporting(E_ALL | E_NOTICE );
+define(TEST, 123);
+class Base {
+const DUMMY = XXX;
+public function foo($var=TEST, $more=null) { return true; }
+public function bar($var, $more=self::DUMMY) { return true; }
+}
+
+class Child extends Base {
+const DUMMY = DDD;
+public function foo($var=TEST) { return true; }
+public function bar() { return true; }
+}
+?
+--EXPECT--
+Strict Standards: Declaration of Child::foo() should be compatible with 
Base::foo($var = '123', $more = NULL) in %sbug63336.php on line %d
+
+Strict Standards: Declaration of Child::bar() should be compatible with 
Base::bar($var, $more = 'XXX') in %sbug63336.php on line %d


--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] com php-src: Test for #63336, xfail now: Zend/tests/bug63336.phpt

2012-10-23 Thread Stas Malyshev
Hi!

 +class Base {
 +const DUMMY = XXX;
 +public function foo($var=TEST, $more=null) { return true; }
 +public function bar($var, $more=self::DUMMY) { return true; }
 +}
 +
 +class Child extends Base {
 +const DUMMY = DDD;
 +public function foo($var=TEST) { return true; }
 +public function bar() { return true; }
 +}
 +?
 +--EXPECT--
 +Strict Standards: Declaration of Child::foo() should be compatible with 
 Base::foo($var = '123', $more = NULL) in %sbug63336.php on line %d
 +
 +Strict Standards: Declaration of Child::bar() should be compatible with 
 Base::bar($var, $more = 'XXX') in %sbug63336.php on line %d

I don't think these are good examples for E_STRICT errors. bar()
traditionally has been used in PHP as function accepting any arguments,
so even if current implementation of PHP (wrongly) says it's not
compatible it may be fixed in the future. I'd rather use more obvious
cases where the extension is clearly wrong - like adding non-optional
arguments or types. This bug has very little to do with compatibility
resolution, so I do not think it is good to peg it to a particular way
of doing it.
-- 
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] com php-src: Test for #63336, xfail now: Zend/tests/bug63336.phpt

2012-10-23 Thread Laruence
On Tue, Oct 23, 2012 at 4:46 PM, Stas Malyshev smalys...@sugarcrm.com wrote:
 Hi!

 +class Base {
 +const DUMMY = XXX;
 +public function foo($var=TEST, $more=null) { return true; }
 +public function bar($var, $more=self::DUMMY) { return true; }
 +}
 +
 +class Child extends Base {
 +const DUMMY = DDD;
 +public function foo($var=TEST) { return true; }
 +public function bar() { return true; }
 +}
 +?
 +--EXPECT--
 +Strict Standards: Declaration of Child::foo() should be compatible with 
 Base::foo($var = '123', $more = NULL) in %sbug63336.php on line %d
 +
 +Strict Standards: Declaration of Child::bar() should be compatible with 
 Base::bar($var, $more = 'XXX') in %sbug63336.php on line %d

 I don't think these are good examples for E_STRICT errors. bar()
 traditionally has been used in PHP as function accepting any arguments,
 so even if current implementation of PHP (wrongly) says it's not
 compatible it may be fixed in the future. I'd rather use more obvious
 cases where the extension is clearly wrong - like adding non-optional
 arguments or types. This bug has very little to do with compatibility
 resolution, so I do not think it is good to peg it to a particular way
 of doing it.
Hey:
   so you mean, this test script should not been committed?

thanks  :)

 --
 Stanislav Malyshev, Software Architect
 SugarCRM: http://www.sugarcrm.com/
 (408)454-6900 ext. 227



-- 
Laruence  Xinchen Hui
http://www.laruence.com/

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php