[PHP-CVS] com php-src: Two tests deactivated until #63688 was fixed: tests/lang/034.phpt tests/lang/bug30638.phpt

2012-12-05 Thread Anatoliy Belsky
Commit:94cbd6374adcb3e2ac15303dd47a212953f93e98 Author:Anatoliy Belsky a...@php.net Wed, 5 Dec 2012 09:55:49 +0100 Parents: 31ab57e052925305008c20e787f514c159d3469d Branches: PHP-5.3 PHP-5.4 PHP-5.5 master Link:

Re: [PHP-CVS] com php-src: Two tests deactivated until #63688 was fixed: tests/lang/034.phpt tests/lang/bug30638.phpt

2012-12-05 Thread Stas Malyshev
Hi! Commit:94cbd6374adcb3e2ac15303dd47a212953f93e98 Author:Anatoliy Belsky a...@php.net Wed, 5 Dec 2012 09:55:49 +0100 Parents: 31ab57e052925305008c20e787f514c159d3469d Branches: PHP-5.3 PHP-5.4 PHP-5.5 master Link:

Re: [PHP-CVS] com php-src: Two tests deactivated until #63688 was fixed: tests/lang/034.phpt tests/lang/bug30638.phpt

2012-12-05 Thread Pierre Joye
On Wed, Dec 5, 2012 at 10:25 AM, Stas Malyshev smalys...@sugarcrm.com wrote: Why removing tests and not putting them as XFAIL? There is no platfrom specific XFAIL. I asked if we could add that to run-tests some time ago, that would be very handy. -- Pierre @pierrejoye |

Re: [PHP-CVS] com php-src: Two tests deactivated until #63688 was fixed: tests/lang/034.phpt tests/lang/bug30638.phpt

2012-12-05 Thread Anatoliy Belsky
That's a windows specific fail, the tests still pass on linux. XFAIL would mark that wrong on linux, that's why. Regards Anatoliy On Wed, 2012-12-05 at 01:25 -0800, Stas Malyshev wrote: Hi! Commit:94cbd6374adcb3e2ac15303dd47a212953f93e98 Author:Anatoliy Belsky a...@php.net

Re: [PHP-CVS] com php-src: Two tests deactivated until #63688 was fixed: tests/lang/034.phpt tests/lang/bug30638.phpt

2012-12-05 Thread Stas Malyshev
Hi! Why removing tests and not putting them as XFAIL? There is no platfrom specific XFAIL. I asked if we could add that to run-tests some time ago, that would be very handy. Yes, looks like it. I'll try to look into in on the weekend and see if I can figure out how to add it. Maybe we

Re: [PHP-CVS] com php-src: Two tests deactivated until #63688 was fixed: tests/lang/034.phpt tests/lang/bug30638.phpt

2012-12-05 Thread Christopher Jones
On 12/05/2012 01:40 AM, Anatoliy Belsky wrote: That's a windows specific fail, the tests still pass on linux. XFAIL would mark that wrong on linux, that's why. Regards Anatoliy Please leave them enabled in the meantime. Otherwise we have 0 coverage. Chris --

Re: [PHP-CVS] com php-src: Two tests deactivated until #63688 was fixed: tests/lang/034.phpt tests/lang/bug30638.phpt

2012-12-05 Thread Adam Harvey
On 6 December 2012 06:24, Christopher Jones christopher.jo...@oracle.com wrote: On 12/05/2012 01:40 AM, Anatoliy Belsky wrote: That's a windows specific fail, the tests still pass on linux. XFAIL would mark that wrong on linux, that's why. Regards Anatoliy Please leave them enabled in

Re: [PHP-CVS] com php-src: Two tests deactivated until #63688 was fixed: tests/lang/034.phpt tests/lang/bug30638.phpt

2012-12-05 Thread Pierre Joye
Again the change is win only. It does not affect other platforms at all. Also see stas reply, we should really do that :) On Dec 5, 2012 11:25 PM, Christopher Jones christopher.jo...@oracle.com wrote: