Re: [PHP-CVS] com php-src: double test timeout for travis: .travis.yml

2013-09-16 Thread Michael Wallner
On 16 September 2013 11:38, Nikita Popov  wrote:
> On Mon, Sep 16, 2013 at 9:35 AM, Michael Wallner  wrote:
>>
>>  # Run PHPs run-tests.php
>> -script: ./sapi/cli/php run-tests.php -p `pwd`/sapi/cli/php -g
>> "FAIL,XFAIL,BORK,WARN,LEAK,SKIP" --show-diff
>> +script: ./sapi/cli/php run-tests.php -p `pwd`/sapi/cli/php -g
>> "FAIL,XFAIL,BORK,WARN,LEAK,SKIP" --show-diff --set-timeout 120
>
>
> Are you sure this is the right thing to do? If we have tests that run longer
> than 60 seconds, we should drop those tests or make sure that they're
> faster. Build times on Travis are already pretty long.

Well, yes I guess. Unless you've got a better idea why this test times out :)
https://travis-ci.org/php/php-src/builds/11404125


-- 
Regards,
Mike

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] com php-src: double test timeout for travis: .travis.yml

2013-09-16 Thread Nikita Popov
On Mon, Sep 16, 2013 at 9:35 AM, Michael Wallner  wrote:

> Commit:b5283b9b7abecde841eb268c4b158cd76630d53b
> Author:Michael Wallner  Mon, 16 Sep 2013
> 09:35:08 +0200
> Parents:   1916aaa272a19e118eae7ad53622174a3fd4a15e
> Branches:  master
>
> Link:
> http://git.php.net/?p=php-src.git;a=commitdiff;h=b5283b9b7abecde841eb268c4b158cd76630d53b
>
> Log:
> double test timeout for travis
>
> Changed paths:
>   M  .travis.yml
>
>
> Diff:
> diff --git a/.travis.yml b/.travis.yml
> index d149772..0765304 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -29,4 +29,4 @@ before_script:
>  - . ./travis/ext/pdo_pgsql/setup.sh
>
>  # Run PHPs run-tests.php
> -script: ./sapi/cli/php run-tests.php -p `pwd`/sapi/cli/php -g
> "FAIL,XFAIL,BORK,WARN,LEAK,SKIP" --show-diff
> +script: ./sapi/cli/php run-tests.php -p `pwd`/sapi/cli/php -g
> "FAIL,XFAIL,BORK,WARN,LEAK,SKIP" --show-diff --set-timeout 120
>

Are you sure this is the right thing to do? If we have tests that run
longer than 60 seconds, we should drop those tests or make sure that
they're faster. Build times on Travis are already pretty long.

Nikita


[PHP-CVS] com php-src: double test timeout for travis: .travis.yml

2013-09-16 Thread Michael Wallner
Commit:b5283b9b7abecde841eb268c4b158cd76630d53b
Author:Michael Wallner  Mon, 16 Sep 2013 09:35:08 
+0200
Parents:   1916aaa272a19e118eae7ad53622174a3fd4a15e
Branches:  master

Link:   
http://git.php.net/?p=php-src.git;a=commitdiff;h=b5283b9b7abecde841eb268c4b158cd76630d53b

Log:
double test timeout for travis

Changed paths:
  M  .travis.yml


Diff:
diff --git a/.travis.yml b/.travis.yml
index d149772..0765304 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -29,4 +29,4 @@ before_script:
 - . ./travis/ext/pdo_pgsql/setup.sh
 
 # Run PHPs run-tests.php 
-script: ./sapi/cli/php run-tests.php -p `pwd`/sapi/cli/php -g 
"FAIL,XFAIL,BORK,WARN,LEAK,SKIP" --show-diff
+script: ./sapi/cli/php run-tests.php -p `pwd`/sapi/cli/php -g 
"FAIL,XFAIL,BORK,WARN,LEAK,SKIP" --show-diff --set-timeout 120


--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php