subject:"\[PHP\-CVS\] com php\-src\: fix for bug#18556 \- use simple tolower\(\) function for internal things\: Zend\/zend_operators.c ext\/standard\/string.c"

Re: [PHP-CVS] com php-src: fix for bug#18556 - use simple tolower() function for internal things: Zend/zend_operators.c ext/standard/string.c

2012-07-14 Thread Nuno Lopes

Hi, Just a few minor nitpicks: +static unsigned char tolower_map[256] = { This should be const. +#define zend_tolower_ascii(c) (tolower_map[(c)]) I suggest casting to unsigned char to prevent overflows and negative chars problems (128-255): #define zend_tolower_ascii(c) (tolower_map[(u

[PHP-CVS] com php-src: fix for bug#18556 - use simple tolower() function for internal things: Zend/zend_operators.c ext/standard/string.c

2012-07-14 Thread Stanislav Malyshev

Commit:582514d4c7b216dbdc7a8429962cf3e5776206f0 Author:Stanislav Malyshev Tue, 10 Jul 2012 18:12:13 -0700 Parents: d2beb0fc050baa752a93ae07585a4488e3dcf053 Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=582514d4c7b216dbdc7a8429962cf3e5776206f0