Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/pcntl pcntl.c /ext/pcntl/tests pcntl_signal.phpt

2009-03-28 Thread Matteo Beccati 

Antony Dovgal ha scritto:

On 28.03.2009 04:32, Matteo Beccati wrote:

mbeccatiSat Mar 28 01:32:51 2009 UTC

  Modified files:  (Branch: PHP_5_3)
/php-src/ext/pcntl	pcntl.c 
/php-src/ext/pcntl/tests	pcntl_signal.phpt 
  Log:

  MFH:
  - Fixed pcntl_signal() returning NULL when passing wrong parameters


"Fixed"? Since when standard behavior is "broken"? 
What's wrong with that?


Sorry about that. I've reverted a few minutes later after Arnaud pointed 
me to the standard behaviour.



Cheers

--
Matteo Beccati

OpenX - http://www.openx.org

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/pcntl pcntl.c /ext/pcntl/tests pcntl_signal.phpt

2009-03-28 Thread Antony Dovgal 
On 28.03.2009 04:32, Matteo Beccati wrote:
> mbeccati  Sat Mar 28 01:32:51 2009 UTC
> 
>   Modified files:  (Branch: PHP_5_3)
> /php-src/ext/pcntlpcntl.c 
> /php-src/ext/pcntl/tests  pcntl_signal.phpt 
>   Log:
>   MFH:
>   - Fixed pcntl_signal() returning NULL when passing wrong parameters

"Fixed"? Since when standard behavior is "broken"? 
What's wrong with that?

-- 
Wbr, 
Antony Dovgal

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/pcntl pcntl.c /ext/pcntl/tests pcntl_signal.phpt

2009-03-27 Thread Matteo Beccati 
mbeccatiSat Mar 28 03:12:52 2009 UTC

  Modified files:  (Branch: PHP_5_3)
/php-src/ext/pcntl  pcntl.c 
/php-src/ext/pcntl/testspcntl_signal.phpt 
  Log:
  MFH:
  - Reverting: pcntl_signal() returning NULL when passing wrong parameters
  
  
http://cvs.php.net/viewvc.cgi/php-src/ext/pcntl/pcntl.c?r1=1.48.2.2.2.4.2.18&r2=1.48.2.2.2.4.2.19&diff_format=u
Index: php-src/ext/pcntl/pcntl.c
diff -u php-src/ext/pcntl/pcntl.c:1.48.2.2.2.4.2.18 
php-src/ext/pcntl/pcntl.c:1.48.2.2.2.4.2.19
--- php-src/ext/pcntl/pcntl.c:1.48.2.2.2.4.2.18 Sat Mar 28 01:32:50 2009
+++ php-src/ext/pcntl/pcntl.c   Sat Mar 28 03:12:52 2009
@@ -16,7 +16,7 @@
+--+
  */
 
-/* $Id: pcntl.c,v 1.48.2.2.2.4.2.18 2009/03/28 01:32:50 mbeccati Exp $ */
+/* $Id: pcntl.c,v 1.48.2.2.2.4.2.19 2009/03/28 03:12:52 mbeccati Exp $ */
 
 #define PCNTL_DEBUG 0
 
@@ -757,7 +757,7 @@
zend_bool restart_syscalls = 1;
 
if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "lz|b", &signo, 
&handle, &restart_syscalls) == FAILURE) {
-   RETURN_FALSE;
+   return;
}
 
if (!PCNTL_G(spares)) {
http://cvs.php.net/viewvc.cgi/php-src/ext/pcntl/tests/pcntl_signal.phpt?r1=1.1.2.3&r2=1.1.2.4&diff_format=u
Index: php-src/ext/pcntl/tests/pcntl_signal.phpt
diff -u php-src/ext/pcntl/tests/pcntl_signal.phpt:1.1.2.3 
php-src/ext/pcntl/tests/pcntl_signal.phpt:1.1.2.4
--- php-src/ext/pcntl/tests/pcntl_signal.phpt:1.1.2.3   Sat Mar 28 01:32:51 2009
+++ php-src/ext/pcntl/tests/pcntl_signal.phpt   Sat Mar 28 03:12:52 2009
@@ -25,7 +25,7 @@
 signal dispatched
 
 Warning: pcntl_signal() expects at least 2 parameters, 0 given in %s
-bool(false)
+NULL
 bool(true)
 
 Warning: pcntl_signal(): Invalid value for handle argument specified in %s



-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/pcntl pcntl.c /ext/pcntl/tests pcntl_signal.phpt

2009-03-27 Thread Matteo Beccati 
mbeccatiSat Mar 28 01:32:51 2009 UTC

  Modified files:  (Branch: PHP_5_3)
/php-src/ext/pcntl  pcntl.c 
/php-src/ext/pcntl/testspcntl_signal.phpt 
  Log:
  MFH:
  - Fixed pcntl_signal() returning NULL when passing wrong parameters
  
  
http://cvs.php.net/viewvc.cgi/php-src/ext/pcntl/pcntl.c?r1=1.48.2.2.2.4.2.17&r2=1.48.2.2.2.4.2.18&diff_format=u
Index: php-src/ext/pcntl/pcntl.c
diff -u php-src/ext/pcntl/pcntl.c:1.48.2.2.2.4.2.17 
php-src/ext/pcntl/pcntl.c:1.48.2.2.2.4.2.18
--- php-src/ext/pcntl/pcntl.c:1.48.2.2.2.4.2.17 Wed Mar 25 23:34:08 2009
+++ php-src/ext/pcntl/pcntl.c   Sat Mar 28 01:32:50 2009
@@ -16,7 +16,7 @@
+--+
  */
 
-/* $Id: pcntl.c,v 1.48.2.2.2.4.2.17 2009/03/25 23:34:08 lbarnaud Exp $ */
+/* $Id: pcntl.c,v 1.48.2.2.2.4.2.18 2009/03/28 01:32:50 mbeccati Exp $ */
 
 #define PCNTL_DEBUG 0
 
@@ -757,7 +757,7 @@
zend_bool restart_syscalls = 1;
 
if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "lz|b", &signo, 
&handle, &restart_syscalls) == FAILURE) {
-   return;
+   RETURN_FALSE;
}
 
if (!PCNTL_G(spares)) {
http://cvs.php.net/viewvc.cgi/php-src/ext/pcntl/tests/pcntl_signal.phpt?r1=1.1.2.2&r2=1.1.2.3&diff_format=u
Index: php-src/ext/pcntl/tests/pcntl_signal.phpt
diff -u php-src/ext/pcntl/tests/pcntl_signal.phpt:1.1.2.2 
php-src/ext/pcntl/tests/pcntl_signal.phpt:1.1.2.3
--- php-src/ext/pcntl/tests/pcntl_signal.phpt:1.1.2.2   Fri Sep 12 19:49:46 2008
+++ php-src/ext/pcntl/tests/pcntl_signal.phpt   Sat Mar 28 01:32:51 2009
@@ -25,7 +25,7 @@
 signal dispatched
 
 Warning: pcntl_signal() expects at least 2 parameters, 0 given in %s
-NULL
+bool(false)
 bool(true)
 
 Warning: pcntl_signal(): Invalid value for handle argument specified in %s



-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php