Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/spl spl_heap.c /ext/spl/tests heap_007.phpt pqueue_003.phpt

2008-11-22 Thread Pierre Joye
On Sat, Nov 22, 2008 at 11:48 PM, Marcus Boerger <[EMAIL PROTECTED]> wrote: > Hello Kalle, > > Saturday, November 22, 2008, 3:25:05 PM, you wrote: > >> 2008/11/22 David Coallier <[EMAIL PROTECTED]>: >>> davidc Sat Nov 22 14:19:47 2008 UTC >>> >>> Modified files: (Branch: PHP_

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/spl spl_heap.c /ext/spl/tests heap_007.phpt pqueue_003.phpt

2008-11-22 Thread David Coallier
>> Hmm, shouldn't this have a NEWS entry? > > Since when do we add NEWS entries that fix stuff that was never released? > > David, please revert that entry. Otherwise it is hard to drop those entries > prior to releasing. > Done. -- Slan, David -- PHP CVS Mailing List (http://www.php.net/) To

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/spl spl_heap.c /ext/spl/tests heap_007.phpt pqueue_003.phpt

2008-11-22 Thread Marcus Boerger
Hello Kalle, Saturday, November 22, 2008, 3:25:05 PM, you wrote: > 2008/11/22 David Coallier <[EMAIL PROTECTED]>: >> davidc Sat Nov 22 14:19:47 2008 UTC >> >> Modified files: (Branch: PHP_5_3) >>/php-src/ext/splspl_heap.c >>/php-src/ext/spl/tests heap_007.p

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/spl spl_heap.c /ext/spl/tests heap_007.phpt pqueue_003.phpt

2008-11-22 Thread Kalle Sommer Nielsen
2008/11/22 David Coallier <[EMAIL PROTECTED]>: > 2008/11/22 Kalle Sommer Nielsen <[EMAIL PROTECTED]>: >> 2008/11/22 David Coallier <[EMAIL PROTECTED]>: >>> davidc Sat Nov 22 14:19:47 2008 UTC >>> >>> Modified files: (Branch: PHP_5_3) >>>/php-src/ext/splspl_heap.c >>>

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/spl spl_heap.c /ext/spl/tests heap_007.phpt pqueue_003.phpt

2008-11-22 Thread David Coallier
2008/11/22 Kalle Sommer Nielsen <[EMAIL PROTECTED]>: > 2008/11/22 David Coallier <[EMAIL PROTECTED]>: >> davidc Sat Nov 22 14:19:47 2008 UTC >> >> Modified files: (Branch: PHP_5_3) >>/php-src/ext/splspl_heap.c >>/php-src/ext/spl/tests heap_007.phpt pqueue_003

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/spl spl_heap.c /ext/spl/tests heap_007.phpt pqueue_003.phpt

2008-11-22 Thread Kalle Sommer Nielsen
2008/11/22 David Coallier <[EMAIL PROTECTED]>: > davidc Sat Nov 22 14:19:47 2008 UTC > > Modified files: (Branch: PHP_5_3) >/php-src/ext/splspl_heap.c >/php-src/ext/spl/tests heap_007.phpt pqueue_003.phpt > Log: > - MFH > - Bug #46615 > - Return the count

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/spl spl_heap.c /ext/spl/tests heap_007.phpt pqueue_003.phpt

2008-11-22 Thread David Coallier
davidc Sat Nov 22 14:19:47 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/splspl_heap.c /php-src/ext/spl/tests heap_007.phpt pqueue_003.phpt Log: - MFH - Bug #46615 - Return the count - 1 when invoking SplHeap->key() - Adjusted the test