rasmus Sat, 08 Aug 2009 14:48:47 +0000 Revision: http://svn.php.net/viewvc?view=revision&revision=286931
Log: Doing a strnatcasecmp(chr(128),chr(255)) is completely non-sensical. Logically one might think that chr(128) would collate before chr(255) except this is a case-insensitive comparison and internally we toupper() both args. toupper(chr(128)) is 128. There is no upper-case equivalent of this char. toupper(chr(255)) is 120 so chr(255) collates before chr(128) in this case-insensitive comparison. And these are rather bogus characters to feed to a natsort test anyway. Changed paths: U php/php-src/branches/PHP_5_3/ext/standard/tests/strings/strnatcasecmp_variation1.phpt U php/php-src/trunk/ext/standard/tests/strings/strnatcasecmp_variation1.phpt Modified: php/php-src/branches/PHP_5_3/ext/standard/tests/strings/strnatcasecmp_variation1.phpt =================================================================== --- php/php-src/branches/PHP_5_3/ext/standard/tests/strings/strnatcasecmp_variation1.phpt 2009-08-08 14:39:34 UTC (rev 286930) +++ php/php-src/branches/PHP_5_3/ext/standard/tests/strings/strnatcasecmp_variation1.phpt 2009-08-08 14:48:47 UTC (rev 286931) @@ -36,7 +36,6 @@ echo "*** Testing strnatcasecmp() : variation ***\n"; -str_dump(chr(128), chr(255)); str_dump('0', false); str_dump('fooBar', ''); str_dump('', -1); @@ -48,7 +47,6 @@ ===DONE=== --EXPECT-- *** Testing strnatcasecmp() : variation *** -int(-1) int(1) int(6) int(-2) Modified: php/php-src/trunk/ext/standard/tests/strings/strnatcasecmp_variation1.phpt =================================================================== --- php/php-src/trunk/ext/standard/tests/strings/strnatcasecmp_variation1.phpt 2009-08-08 14:39:34 UTC (rev 286930) +++ php/php-src/trunk/ext/standard/tests/strings/strnatcasecmp_variation1.phpt 2009-08-08 14:48:47 UTC (rev 286931) @@ -36,7 +36,6 @@ echo "*** Testing strnatcasecmp() : variation ***\n"; -str_dump(chr(128), chr(255)); str_dump('0', false); str_dump('fooBar', ''); str_dump('', -1); @@ -48,7 +47,6 @@ ===DONE=== --EXPECT-- *** Testing strnatcasecmp() : variation *** -int(-1) int(1) int(6) int(-2)
-- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php