pajoye                                   Wed, 03 Feb 2010 18:35:58 +0000

Revision: http://svn.php.net/viewvc?view=revision&revision=294434

Log:
- Fixed bug #50576 (XML_OPTION_SKIP_TAGSTART option has no effect).

Bug: http://bugs.php.net/50576 (Closed) XML_OPTION_SKIP_TAGSTART option has no 
effect
      
Changed paths:
    _U  php/php-src/branches/PHP_5_3_2/
    U   php/php-src/branches/PHP_5_3_2/NEWS
    _U  php/php-src/branches/PHP_5_3_2/ext/tidy/tests/
    A + php/php-src/branches/PHP_5_3_2/ext/xml/tests/bug50576.phpt
        (from php/php-src/branches/PHP_5_3/ext/xml/tests/bug50576.phpt:r293146)
    U   php/php-src/branches/PHP_5_3_2/ext/xml/xml.c
    _U  
php/php-src/branches/PHP_5_3_2/tests/security/open_basedir_parse_ini_file.phpt


Property changes on: php/php-src/branches/PHP_5_3_2
___________________________________________________________________
Modified: svn:mergeinfo
   - 
/php/php-src/branches/PHP_5_3:292504,292574,292594-292595,292611,292624,292630,292632-292635,292654,292677,292682-292683,292693,292719,292762,292765,292771,292777,292823,293051,293075,293114,293126,293131,293144,293268,293341,293400,293502,293538,293558,293974
/php/php-src/trunk:284726
   + 
/php/php-src/branches/PHP_5_3:292504,292574,292594-292595,292611,292624,292630,292632-292635,292654,292677,292682-292683,292693,292719,292762,292765,292771,292777,292823,293051,293075,293114,293126,293131,293144,293146,293268,293341,293400,293502,293538,293558,293974
/php/php-src/trunk:284726

Modified: php/php-src/branches/PHP_5_3_2/NEWS
===================================================================
--- php/php-src/branches/PHP_5_3_2/NEWS 2010-02-03 18:29:52 UTC (rev 294433)
+++ php/php-src/branches/PHP_5_3_2/NEWS 2010-02-03 18:35:58 UTC (rev 294434)
@@ -10,6 +10,7 @@

 - Fixed bug #50632 (filter_input() does not return default value if the
   variable does not exist). (Ilia)
+- Fixed bug #50576 (XML_OPTION_SKIP_TAGSTART option has no effect). (Pierrick)
 - Fixed bug #48590 (SoapClient does not honor max_redirects). (Sriram)
 - Fixed bug #48190 (Content-type parameter "boundary" is not case-insensitive
   in HTTP uploads). (Ilia)


Property changes on: php/php-src/branches/PHP_5_3_2/ext/tidy/tests
___________________________________________________________________
Modified: svn:mergeinfo
   - 
/php/php-src/branches/PHP_5_3/ext/tidy/tests:292562,292566,292571,292574,292635,292719,292765,293400,293502,293538,293558
/php/php-src/trunk/ext/tidy/tests:284726,287798-287941
   + 
/php/php-src/branches/PHP_5_3/ext/tidy/tests:292562,292566,292571,292574,292635,292719,292765,293146,293400,293502,293538,293558
/php/php-src/trunk/ext/tidy/tests:284726,287798-287941

Copied: php/php-src/branches/PHP_5_3_2/ext/xml/tests/bug50576.phpt (from rev 
293146, php/php-src/branches/PHP_5_3/ext/xml/tests/bug50576.phpt)
===================================================================
--- php/php-src/branches/PHP_5_3_2/ext/xml/tests/bug50576.phpt                  
        (rev 0)
+++ php/php-src/branches/PHP_5_3_2/ext/xml/tests/bug50576.phpt  2010-02-03 
18:35:58 UTC (rev 294434)
@@ -0,0 +1,133 @@
+--TEST--
+Bug #50576 (XML_OPTION_SKIP_TAGSTART option has no effect)
+--SKIPIF--
+<?php
+require_once("skipif.inc");
+?>
+--FILE--
+<?php
+
+$XML = <<<XML
+<?xml version="1.0"?>
+<ns1:listOfAwards xmlns:ns1="http://www.fpdsng.com/FPDS";>
+<ns1:count>
+<ns1:total>867</ns1:total>
+</ns1:count>
+</ns1:listOfAwards>
+XML;
+
+$xml_parser = xml_parser_create();
+xml_parser_set_option($xml_parser, XML_OPTION_SKIP_TAGSTART, 4);
+xml_parse_into_struct($xml_parser, $XML, $vals, $index);
+echo 'Index array' . PHP_EOL;
+print_r($index);
+echo 'Vals array' . PHP_EOL;
+print_r($vals);
+xml_parser_free($xml_parser);
+
+function startElement($parser, $name, $attribs) { echo $name . PHP_EOL; }
+function endElement($parser, $name) { echo $name . PHP_EOL; }
+$xml_parser = xml_parser_create();
+xml_set_element_handler($xml_parser, 'startElement', 'endElement');
+xml_parser_set_option($xml_parser, XML_OPTION_SKIP_TAGSTART, 4);
+xml_parse($xml_parser, $XML);
+xml_parser_free($xml_parser);
+
+?>
+--EXPECTF--
+Index array
+Array
+(
+    [LISTOFAWARDS] => Array
+        (
+            [0] => 0
+            [1] => 5
+            [2] => 6
+        )
+
+    [COUNT] => Array
+        (
+            [0] => 1
+            [1] => 3
+            [2] => 4
+        )
+
+    [TOTAL] => Array
+        (
+            [0] => 2
+        )
+
+)
+Vals array
+Array
+(
+    [0] => Array
+        (
+            [tag] => LISTOFAWARDS
+            [type] => open
+            [level] => 1
+            [attributes] => Array
+                (
+                    [XMLNS:NS1] => http://www.fpdsng.com/FPDS
+                )
+
+            [value] =>
+
+        )
+
+    [1] => Array
+        (
+            [tag] => COUNT
+            [type] => open
+            [level] => 2
+            [value] =>
+
+        )
+
+    [2] => Array
+        (
+            [tag] => TOTAL
+            [type] => complete
+            [level] => 3
+            [value] => 867
+        )
+
+    [3] => Array
+        (
+            [tag] => COUNT
+            [value] =>
+
+            [type] => cdata
+            [level] => 2
+        )
+
+    [4] => Array
+        (
+            [tag] => COUNT
+            [type] => close
+            [level] => 2
+        )
+
+    [5] => Array
+        (
+            [tag] => LISTOFAWARDS
+            [value] =>
+
+            [type] => cdata
+            [level] => 1
+        )
+
+    [6] => Array
+        (
+            [tag] => LISTOFAWARDS
+            [type] => close
+            [level] => 1
+        )
+
+)
+LISTOFAWARDS
+COUNT
+TOTAL
+TOTAL
+COUNT
+LISTOFAWARDS

Modified: php/php-src/branches/PHP_5_3_2/ext/xml/xml.c
===================================================================
--- php/php-src/branches/PHP_5_3_2/ext/xml/xml.c        2010-02-03 18:29:52 UTC 
(rev 294433)
+++ php/php-src/branches/PHP_5_3_2/ext/xml/xml.c        2010-02-03 18:35:58 UTC 
(rev 294434)
@@ -804,7 +804,7 @@

                if (parser->startElementHandler) {
                        args[0] = _xml_resource_zval(parser->index);
-                       args[1] = _xml_string_zval(tag_name);
+                       args[1] = _xml_string_zval(((char *) tag_name) + 
parser->toffset);
                        MAKE_STD_ZVAL(args[2]);
                        array_init(args[2]);

@@ -884,7 +884,7 @@

                if (parser->endElementHandler) {
                        args[0] = _xml_resource_zval(parser->index);
-                       args[1] = _xml_string_zval(tag_name);
+                       args[1] = _xml_string_zval(((char *) tag_name) + 
parser->toffset);

                        if ((retval = xml_call_handler(parser, 
parser->endElementHandler, parser->endElementPtr, 2, args))) {
                                zval_ptr_dtor(&retval);


Property changes on: 
php/php-src/branches/PHP_5_3_2/tests/security/open_basedir_parse_ini_file.phpt
___________________________________________________________________
Modified: svn:mergeinfo
   - 
/php/php-src/branches/PHP_5_3/tests/security/open_basedir_parse_ini_file.phpt:292562,292566,292571,292574,293400,293502,293538,293558
/php/php-src/trunk/tests/security/open_basedir_parse_ini_file.phpt:265951
   + 
/php/php-src/branches/PHP_5_3/tests/security/open_basedir_parse_ini_file.phpt:292562,292566,292571,292574,293146,293400,293502,293538,293558
/php/php-src/trunk/tests/security/open_basedir_parse_ini_file.phpt:265951

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to