Re: [PHP-CVS] svn: /php/php-src/trunk/ext/standard/tests/strings/ md5_file.phpt

2011-09-14 Thread Hannes Magnusson 
On Tue, Sep 6, 2011 at 19:10, Pierre Joye paj...@php.net wrote:
 pajoye                                   Tue, 06 Sep 2011 17:10:16 +

 Revision: http://svn.php.net/viewvc?view=revisionrevision=316284

 Log:
 - useless skipif

 Changed paths:
    U   php/php-src/trunk/ext/standard/tests/strings/md5_file.phpt

 Modified: php/php-src/trunk/ext/standard/tests/strings/md5_file.phpt
 ===
 --- php/php-src/trunk/ext/standard/tests/strings/md5_file.phpt  2011-09-06 
 16:48:54 UTC (rev 316283)
 +++ php/php-src/trunk/ext/standard/tests/strings/md5_file.phpt  2011-09-06 
 17:10:16 UTC (rev 316284)
 @@ -1,17 +1,5 @@
  --TEST--
  Test md5_file() function with ASCII output and raw binary output
 ---SKIPIF--
 -?php
 -
 -$path = dirname(__FILE__);
 -$data_file = $path/EmptyFile.txt;
 -$data_file1 = $path/DataFile.txt;
 -if !(($fp = fopen($data_file, 'w')) || ($fp1 = fopen($data_file1, 'w'))  {
 -  echo File could not be created ,hence exiting from testcase due to 
 pre-requisite failure\n;
 -}
 -fclose( $fp );
 -fclose( $fp1 );
 -
  --FILE--
  ?php

 @@ -109,8 +97,7 @@
  string(32) d41d8cd98f00b204e9800998ecf8427e

  *** Raw Binary Output for Empty file as Argument ***
 -string(16) Ô ŚŮŹ
 -
 +string(16) Ô ŚŮŹ
  *** Hexadecimal Output for a valid file with some contents ***
  string(32) 7f28ec647825e2a70bf67778472cd4a2


This change broke the test for me...
I suspect your editor doesn't like binary data?

-Hannes

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] svn: /php/php-src/trunk/ext/standard/tests/strings/ md5_file.phpt

2011-09-14 Thread Pierre Joye 
hm, right, fails here too. Let me check again previous revision.

On Wed, Sep 14, 2011 at 10:02 AM, Hannes Magnusson
hannes.magnus...@gmail.com wrote:
 On Tue, Sep 6, 2011 at 19:10, Pierre Joye paj...@php.net wrote:
 pajoye                                   Tue, 06 Sep 2011 17:10:16 +

 Revision: http://svn.php.net/viewvc?view=revisionrevision=316284

 Log:
 - useless skipif

 Changed paths:
    U   php/php-src/trunk/ext/standard/tests/strings/md5_file.phpt

 Modified: php/php-src/trunk/ext/standard/tests/strings/md5_file.phpt
 ===
 --- php/php-src/trunk/ext/standard/tests/strings/md5_file.phpt  2011-09-06 
 16:48:54 UTC (rev 316283)
 +++ php/php-src/trunk/ext/standard/tests/strings/md5_file.phpt  2011-09-06 
 17:10:16 UTC (rev 316284)
 @@ -1,17 +1,5 @@
  --TEST--
  Test md5_file() function with ASCII output and raw binary output
 ---SKIPIF--
 -?php
 -
 -$path = dirname(__FILE__);
 -$data_file = $path/EmptyFile.txt;
 -$data_file1 = $path/DataFile.txt;
 -if !(($fp = fopen($data_file, 'w')) || ($fp1 = fopen($data_file1, 'w'))  {
 -  echo File could not be created ,hence exiting from testcase due to 
 pre-requisite failure\n;
 -}
 -fclose( $fp );
 -fclose( $fp1 );
 -
  --FILE--
  ?php

 @@ -109,8 +97,7 @@
  string(32) d41d8cd98f00b204e9800998ecf8427e

  *** Raw Binary Output for Empty file as Argument ***
 -string(16) Ô ŚŮŹ
 -
 +string(16) Ô ŚŮŹ
  *** Hexadecimal Output for a valid file with some contents ***
  string(32) 7f28ec647825e2a70bf67778472cd4a2


 This change broke the test for me...
 I suspect your editor doesn't like binary data?

 -Hannes

 --
 PHP CVS Mailing List (http://www.php.net/)
 To unsubscribe, visit: http://www.php.net/unsub.php





-- 
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-CVS] svn: /php/php-src/trunk/ext/standard/tests/strings/ md5_file.phpt

2011-09-14 Thread Pierre Joye 
pajoye   Wed, 14 Sep 2011 10:30:31 +

Revision: http://svn.php.net/viewvc?view=revisionrevision=316729

Log:
- fix text (encoding was broken with the previous commit)

Changed paths:
U   php/php-src/trunk/ext/standard/tests/strings/md5_file.phpt

Modified: php/php-src/trunk/ext/standard/tests/strings/md5_file.phpt
===
--- php/php-src/trunk/ext/standard/tests/strings/md5_file.phpt  2011-09-14 
10:25:15 UTC (rev 316728)
+++ php/php-src/trunk/ext/standard/tests/strings/md5_file.phpt  2011-09-14 
10:30:31 UTC (rev 316729)
@@ -97,7 +97,8 @@
 string(32) d41d8cd98f00b204e9800998ecf8427e

 *** Raw Binary Output for Empty file as Argument ***
-string(16) ��ُ
+string(16) ��ُ
+
 *** Hexadecimal Output for a valid file with some contents ***
 string(32) 7f28ec647825e2a70bf67778472cd4a2


-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-CVS] svn: /php/php-src/trunk/ext/standard/tests/strings/ md5_file.phpt

2011-09-06 Thread Pierre Joye 
pajoye   Tue, 06 Sep 2011 17:10:16 +

Revision: http://svn.php.net/viewvc?view=revisionrevision=316284

Log:
- useless skipif

Changed paths:
U   php/php-src/trunk/ext/standard/tests/strings/md5_file.phpt

Modified: php/php-src/trunk/ext/standard/tests/strings/md5_file.phpt
===
--- php/php-src/trunk/ext/standard/tests/strings/md5_file.phpt  2011-09-06 
16:48:54 UTC (rev 316283)
+++ php/php-src/trunk/ext/standard/tests/strings/md5_file.phpt  2011-09-06 
17:10:16 UTC (rev 316284)
@@ -1,17 +1,5 @@
 --TEST--
 Test md5_file() function with ASCII output and raw binary output
---SKIPIF--
-?php
-
-$path = dirname(__FILE__);
-$data_file = $path/EmptyFile.txt;
-$data_file1 = $path/DataFile.txt;
-if !(($fp = fopen($data_file, 'w')) || ($fp1 = fopen($data_file1, 'w'))  {
-  echo File could not be created ,hence exiting from testcase due to 
pre-requisite failure\n;
-}
-fclose( $fp );
-fclose( $fp1 );
-
 --FILE--
 ?php

@@ -109,8 +97,7 @@
 string(32) d41d8cd98f00b204e9800998ecf8427e

 *** Raw Binary Output for Empty file as Argument ***
-string(16) ��ُ
-
+string(16) ��ُ
 *** Hexadecimal Output for a valid file with some contents ***
 string(32) 7f28ec647825e2a70bf67778472cd4a2


-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php